This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 152575 - Extend org.netbeans.modules.xml.multiview.ui.SimpleDialogPanel.DialogDescriptor to support labels with &X mnemonics
Summary: Extend org.netbeans.modules.xml.multiview.ui.SimpleDialogPanel.DialogDescript...
Status: RESOLVED FIXED
Alias: None
Product: xml
Classification: Unclassified
Component: XML Multiview (show other bugs)
Version: 6.x
Hardware: All All
: P3 blocker (vote)
Assignee: pslechta
URL:
Keywords: API, API_REVIEW_FAST
Depends on:
Blocks: 86181
  Show dependency tree
 
Reported: 2008-11-06 20:38 UTC by pslechta
Modified: 2009-02-19 23:31 UTC (History)
0 users

See Also:
Issue Type: DEFECT
Exception Reporter:

Attachments
proposed change (diff) (2.62 KB, text/plain)
2008-11-06 20:40 UTC, pslechta 		Details
proposed changes 2 (diff) (12.77 KB, text/plain)
2008-11-19 12:38 UTC, pslechta 		Details
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description pslechta 2008-11-06 20:38:56 UTC 
Today, org.netbeans.modules.xml.multiview.ui.SimpleDialogPanel.DialogDescriptor does not support labels with &X
mnemonics (like &Name, Pa&rameter, etc.)

Thus, I18N and L10N is impacted (it is more complex that it should be) and mnemonics issues connected with this
component cannot be fixed (e.g. Issue 86181, see the latest comments).

The proposed fix for this problem is to extend DialogDescriptor with new constructor where caller can specify if labels
do contain mnemonics information or not. Also code of SimpleDialogPanel class should be changed little bit. Please see
attached diff for details.

This change is very simple (addition of one constructor) and has no impact on backward compatibility.
Comment 1 pslechta 2008-11-06 20:40:53 UTC 
Created attachment 73395 [details]
proposed change (diff)
Comment 2 pslechta 2008-11-06 20:42:57 UTC 
Hello API reviewers, please review this simple change to xml.multiview API. Thanks!
Comment 3 Jaroslav Tulach 2008-11-08 17:52:45 UTC 
Welcome among API designers!

Y01 Increment spec version of the module
Y02 in apichanges.xml (I guess you need to create one) document note that since version X.Y the behaviour is enhanced
Y03 write a simple test to verify that the behaviour remains as expected?
Comment 4 pslechta 2008-11-19 12:37:03 UTC 
API review timeout expired.

Attaching latest diff that incorporates comments from Jarda (Y01 -- Y03).

Please let me know if you have any objections. If not, I'm going to integrate this change tomorrow. Thanks!
Comment 5 pslechta 2008-11-19 12:38:02 UTC 
Created attachment 73902 [details]
proposed changes 2 (diff)
Comment 6 Jaroslav Tulach 2008-11-20 11:31:49 UTC 
Y04 you probably do not want to show "public JLabel[] getLabels()" in the API. Make it package private.

Otherwise OK and thanks.
Comment 7 pslechta 2008-11-20 14:02:30 UTC 
The change was pushed into main. (Y04 comment included)

http://hg.netbeans.org/main/rev/d4e47111f128
Comment 8 pslechta 2008-11-20 14:05:00 UTC 
Marking as fixed.
Comment 9 Quality Engineering 2008-11-22 04:49:33 UTC 
Integrated into 'main-golden', will be available in build *200811220201* on http://bits.netbeans.org/dev/nightly/ (upload may still be in progress)
Changeset: http://hg.netbeans.org/main/rev/d4e47111f128
User: pslechta@netbeans.org
Log: #152575 Extend org.netbeans.modules.xml.multiview.ui.SimpleDialogPanel.DialogDescriptor to support labels with &X mnemonics