This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 151668 - I18N : "Navigate" of context menu on YAML editor is not from Bundle
Summary: I18N : "Navigate" of context menu on YAML editor is not from Bundle
Status: VERIFIED FIXED
Alias: None
Product: editor
Classification: Unclassified
Component: CSL (API & infrastructure) (show other bugs)
Version: 6.x
Hardware: All All
: P2 blocker (vote)
Assignee: issues@editor
URL:
Keywords: I18N
: 127161 (view as bug list)
Depends on:
Blocks:
 
Reported: 2008-10-29 08:06 UTC by Masaki Katakai
Modified: 2009-04-20 04:53 UTC (History)
3 users (show)

See Also:
Issue Type: DEFECT
Exception Reporter:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Masaki Katakai 2008-10-29 08:06:19 UTC 
It seems that the message "Navigate" of context menu on YAML editor
is not from Bundle.properties. Could you please check?
A similar issue has been filed against JSON file as bug 148909.
Comment 1 Masaki Katakai 2009-04-02 07:10:47 UTC 
In current dev build, this issue happens against "JSON" and "YAML" file.
Comment 2 Erno Mononen 2009-04-15 16:37:05 UTC 
Passing to csl. I guess the following should fix this, but isn't this a problem for some other MIME types as well (PHP 
comes to mind)?:

--- a/csl.api/anttask/src/org/netbeans/modules/csl/CslJar.java	Wed Apr 15 16:31:15 2009 +0200
+++ b/csl.api/anttask/src/org/netbeans/modules/csl/CslJar.java	Wed Apr 15 17:35:29 2009 +0200
@@ -554,6 +554,8 @@
             if (mimeType.equals("text/x-ruby") || // NOI18N
                     mimeType.equals("text/x-css") || // NOI18N
                     mimeType.equals("text/x-groovy") || // NOI18N
+                    mimeType.equals("text/x-yaml") || // NOI18N
+                    mimeType.equals("text/x-json") || // NOI18N
                     mimeType.equals("text/javascript")) { // NOI18N
                 setFileAttribute(doc, gotoFolder, "SystemFileSystem.localizingBundle", STRINGVALUE, 
"org.netbeans.modules.csl.core.Bundle");
             } else {
diff -r dd91dc336838 csl.api/src/org/netbeans/modules/csl/core/Bundle.properties
--- a/csl.api/src/org/netbeans/modules/csl/core/Bundle.properties	Wed Apr 15 16:31:15 2009 +0200
+++ b/csl.api/src/org/netbeans/modules/csl/core/Bundle.properties	Wed Apr 15 17:35:29 2009 +0200
@@ -27,6 +27,8 @@
 Editors/text/javascript/Popup/goto=Navigate
 Editors/text/x-css/Popup/goto=Navigate
 Editors/text/x-groovy/Popup/goto=Navigate
+Editors/text/x-yaml/Popup/goto=Navigate
+Editors/text/x-json/Popup/goto=Navigate
Comment 3 Jan Lahoda 2009-04-15 16:42:59 UTC 
Re PHP: see issue #127161.
Comment 4 Vitezslav Stejskal 2009-04-16 13:19:04 UTC 
http://hg.netbeans.org/jet-main/rev/7c424577c8ed
http://hg.netbeans.org/jet-main/rev/5fdf17bb40de

Hopefully fixed once and for all.
Comment 5 Vitezslav Stejskal 2009-04-16 13:19:39 UTC 
*** Issue 127161 has been marked as a duplicate of this issue. ***
Comment 6 Vitezslav Stejskal 2009-04-16 13:20:55 UTC 
Marku, in this fix I effectively reverted your 97126a60291b, which is no longer neccessary.
Comment 7 Quality Engineering 2009-04-17 08:39:55 UTC 
Integrated into 'main-golden', will be available in build *200904170201* on http://bits.netbeans.org/dev/nightly/ (upload may still be in progress)
Changeset: http://hg.netbeans.org/main-golden/rev/7c424577c8ed
User: Vita Stejskal <vstejskal@netbeans.org>
Log: #151668 - using a special "displayName" attribute rather then SystemFileSystem.localizingBundle
Comment 8 Masaki Katakai 2009-04-20 04:53:42 UTC 
Thank you for fixing! Verified on 200904180201.