This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.
Product Version: NetBeans IDE Dev (Build 200810150101) Java: 1.6.0_10-beta; Java HotSpot(TM) Client VM 11.0-b12 System: Windows XP version 5.1 running on x86; Cp1251; ru_RU (nb) 1. Create Java Application. 2. Add Purchase order sample schema. 3. Generate sample XML for created schema with purchaseOrder as root element. 4. Generate DTD for XML. 5. Generate DOM tree scanner for DTD. NB will produce completely empty Java source file NewPurchaseOrderScanner.java.
The first thing I want to know is, do you have automated tests for this and if they are part of commit validation? If not, why not? We have to have more and more automated tests so that we don't discover these issues after code-freeze.
I almost forgot, Sonali is on vacation. I'll look into it.
Yes we have automated tests for this and this issue found using them. Do you think we need to replace short commit validation with all existing tests?
No. I would pick tests on various actions and not the fine-grained tests such as creating a substitution-group in a schema. I think all top-level actions should be included in the CV.
> Yes we have automated tests for this and this issue found using them. Are you saying that, this was only found in 200810150101 and was working in all earlier builds?
Commit validation tests we have now created long time ago and nobody care about incomplete content of them. The only time you asked about new test was about two week ago and test added next day if you remember. Anyway it's incorrect to move test into commit validation in case of any found issue. This is not purpose of CV. Well, if you have concerns about CV set we can discuss.
>> Yes we have automated tests for this and this issue found using them. > Are you saying that, this was only found in 200810150101 and was working in all earlier builds? No, this is not true. We have kind of RC1 today so I recheck tests more closer then usually. Well, I think you agree this is not typical regression: file created but content is empty so there was no such check in then corresponding test just because it is impossible to forecast all kinds of errors, so some of them can pass checking for some time. But finally one new issue found. It's better then one not found.
I wonder if this was ever tested! In any case, I have a fix that will work. Stay tuned...
Depends on that do you mean by "this".
This may not be the best possible solution but this will do the job. Fixed in trunk: http://hg.netbeans.org/main/rev/71f96b4c6841.
Michael, you could use the attached jar to test this. You do not have to wait for a build, but it is up to you.
I believe this jar will help, but my worry is about time this fix will come into RC.
Created attachment 71897 [details] java2/modules/org-netbeans-modules-xml-tools-java.jar
You may want to add the keyword 65_HR_FIX. As soon as you verify, I'll send an approval email.
Okey, I see.
Confirmed in RC1...will test patch now. Product Version: NetBeans IDE 6.5 RC1 (Build 200810151402) Java: 1.6.0_07; Java HotSpot(TM) 64-Bit Server VM 1.6.0_07-b06-57 System: Mac OS X version 10.5.5 running on x86_64; MacRoman; en_US (nb)
Verified that the patch works (see screen shot) I approve the fix.
Created attachment 71912 [details] Fixed with new jar
The new jar file fixes the issue.
Integrated into 'main-golden', will be available in build *200810160201* on http://bits.netbeans.org/dev/nightly/ (upload may still be in progress) Changeset: http://hg.netbeans.org/main/rev/71f96b4c6841 User: samaresh@netbeans.org Log: #150210 Unable to create DOM tree scaner
Please, push the fix in release65 clone.
Sorry, forgot to update the issue. It has been done. http://hg.netbeans.org/release65?cmd=changeset;node=f7fc281624ce.
Fix Verified Product Version: NetBeans IDE 6.5 RC1 (Build 200810171318) Java: 1.6.0_07; Java HotSpot(TM) 64-Bit Server VM 1.6.0_07-b06-57 System: Mac OS X version 10.5.5 running on x86_64; MacRoman; en_US (nb)