This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 146656 - Don't use bolding for required fields
Summary: Don't use bolding for required fields
Status: VERIFIED FIXED
Alias: None
Product: db
Classification: Unclassified
Component: Code (show other bugs)
Version: 6.x
Hardware: All All
: P4 blocker (vote)
Assignee: Rob Englander
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-09-09 14:53 UTC by Petr Blaha
Modified: 2008-09-12 12:14 UTC (History)
2 users (show)

See Also:
Issue Type: DEFECT
Exception Reporter:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Petr Blaha 2008-09-09 14:53:46 UTC
Use the information icons for required fields and also remove bolding for 'Database' field. See the InformationIcons
spec: http://wiki.netbeans.org/InformationIcons
Comment 1 Rob Englander 2008-09-10 13:19:08 UTC
I have the fix ready, I just want to make sure I've followed the guidelines.  For each required field, the initial
message to the user will be an info icon with black text since that's the way we default the field.  Once the user
begins inputting into a field, if the user clears the input we show an error icon with red text for that field.

That's my interpretation of how the guideline applies to this dialog.

Do you agree?
Comment 2 Petr Blaha 2008-09-10 13:34:20 UTC
Jano, can you please comment this? Thanks
Comment 3 Rob Englander 2008-09-10 14:35:44 UTC
I just realized that I was reading the proposal part of that page.  Has that proposal been generally accepted?
If not, I'll just use the error format as is used elsewhere in netbeans.
Comment 4 Petr Blaha 2008-09-10 14:54:56 UTC
Yes. For instance, try to register Tomcat 6.0 and you should see this information icons in the dialog.
Comment 5 Rob Englander 2008-09-10 15:01:24 UTC
I see.  My interpretation was too complicated.  Invalid data should be marked as an error, while
a required empty field is marked as info.

Just a minor tweak to what I've got.  

Thanks for following up.
Comment 6 Rob Englander 2008-09-10 15:58:18 UTC
The change is complete.  Does this require a late UI change request?
Comment 7 Rob Englander 2008-09-10 17:43:19 UTC
e518d0496d61
Comment 8 Quality Engineering 2008-09-11 17:39:39 UTC
Integrated into 'main-golden', will be available in build *200809111401* on http://bits.netbeans.org/dev/nightly/ (upload may still be in progress)
Changeset: http://hg.netbeans.org/main/rev/e518d0496d61
User: Rob Englander <mindstream@netbeans.org>
Log: #146656 Added standard NetBeans error/info message display to New Connection dialog instead of using Bold field labels to indicate required fields.  The dialog now properly shows an info icon and info text when required fields have no values, and shows an error icon and red text when an error condition is found, such as a bad url format.

An ErrorInfoPanel component has been created so that other db explorer dialogs can eventually be updated as well without having to create the icon and text widget functionality all over again.
Comment 9 Roman Mostyka 2008-09-11 17:43:17 UTC
Verified with build 080910.
Comment 10 Rob Englander 2008-09-11 19:32:18 UTC
Reopened to add conformance to netbeans standards.
Comment 11 Rob Englander 2008-09-11 19:32:39 UTC
152c752ca0df
Comment 12 Quality Engineering 2008-09-12 05:59:48 UTC
Integrated into 'main-golden', will be available in build *200809120201* on http://bits.netbeans.org/dev/nightly/ (upload may still be in progress)
Changeset: http://hg.netbeans.org/main/rev/152c752ca0df
User: Rob Englander <mindstream@netbeans.org>
Log: #146656 Added license header and adopted netbeans UI standards.
Comment 13 Roman Mostyka 2008-09-12 12:14:04 UTC
Verified with build 080911.