This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 14634 - Property sheet closes immediately after modifying any property
Summary: Property sheet closes immediately after modifying any property
Status: CLOSED FIXED
Alias: None
Product: utilities
Classification: Unclassified
Component: Properties (show other bugs)
Version: -FFJ-
Hardware: PC All
: P4 blocker (vote)
Assignee: issues@utilities
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2001-08-21 16:22 UTC by vnemec
Modified: 2003-07-01 14:20 UTC (History)
1 user (show)

See Also:
Issue Type: DEFECT
Exception Reporter:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description vnemec 2001-08-21 16:22:47 UTC 
a) open bundle property properties editor
    i) expand resource bundle node in editor
   ii) select some key
  iii) in contextual menu select 'Properties'

b) in properties editor edit some property - you can 'propagate' the changes by
pressing <Enter> or by selecting other property -> in both cases the Peoperties
Editor window will close immediately
Comment 1 Tomas Pavek 2001-11-22 12:27:00 UTC 
This was caused by inconvenient and ineffective updates made after 
changes of item node properties. I've tried to fix it a bit...

Changed files:

Element.java rev. 1.24
KeyNode.java rev. 1.23
PropertiesFileEntry.java rev. 1.37
PropertiesParser.java rev. 1.25
PropertiesStructure.java rev. 1.30
Comment 2 Martin Roskanin 2001-12-04 10:08:27 UTC 
Reopened. 
The fix caused serious problems and was rolled back.
Comment 3 Martin Roskanin 2002-06-21 10:02:41 UTC 
fixed in [maintrunk]

Tomas,
thank you for your patch. I have integrated all your changes except
PropertiesParser. The parser seems to follow "butterfly effect". Minor
change can cause a big and unexpected behaviour ;-)
Mato

/cvs/properties/src/org/netbeans/modules/properties/Element.java,v 
<--  Element.java
new revision: 1.26; previous revision: 1.25

/cvs/properties/src/org/netbeans/modules/properties/KeyNode.java,v 
<--  KeyNode.java
new revision: 1.25; previous revision: 1.24

/cvs/properties/src/org/netbeans/modules/properties/PropertiesEditorSupport.java,v
 <--  PropertiesEditorSupport.java
new revision: 1.61; previous revision: 1.60

/cvs/properties/src/org/netbeans/modules/properties/PropertiesFileEntry.java,v
 <--  PropertiesFileEntry.java
new revision: 1.39; previous revision: 1.38

/cvs/properties/src/org/netbeans/modules/properties/PropertiesStructure.java,v
 <--  PropertiesStructure.java
new revision: 1.32; previous revision: 1.31
Comment 4 Martin Roskanin 2002-07-18 15:49:32 UTC 
Unfortunatelly, I have to reopen this issue again. The same problem
has been found as before, the fix causes a serious bug #18269.
Comment 5 _ pkuzel 2003-02-05 18:07:24 UTC 
Evaluation:

KeyNode would rather listen on its model then recreating it by calling
refreshKey() on every ITEM_CHANGE event handled by
PropertieFileEntry.PropKeysChildren.
Comment 6 _ pkuzel 2003-02-06 13:15:53 UTC 
Children.Keys.refreshKey() call avoided. Now it gets closed only on
key property change. I could make this property read-only if required.

KeyNode.java new revision: 1.28
PropertiesFileEntry.java new revision: 1.42 PropertiesStructure.java
new revision: 1.37
Comment 7 pfelenda 2003-03-24 18:23:56 UTC 
Verified in dev 200303240100.
Comment 8 Quality Engineering 2003-07-01 14:20:55 UTC 
Resolved for 3.4.x or earlier, no new info since then -> closing.