Created attachment 68556 [details]
Adds OpenBSD to OS_UNIX_MASK

Is this correct? 

if (osName.equals("OpenBSD")) 

What does System.getProperty("os.name"); returns on OpenBSD?

On my OpenBSD 4.4-current, all of my jdk's System.getProperty("os.name") returns "OpenBSD".


$ cat avaProperties.java
import java.util.Properties;

public class JavaProperties {
  public static void main(String[] args) {
    Properties properties = System.getProperties();
    properties.list(System.out);
  }
}
$ for jdk in /usr/local/jdk*; do echo $jdk && $jdk/bin/javac JavaProperties.java && $jdk/bin/java JavaProperties | grep
^os.; done 
/usr/local/jdk-1.5.0
os.arch=amd64
os.name=OpenBSD
os.version=4.4
/usr/local/jdk-1.6.0
os.arch=amd64
os.name=OpenBSD
os.version=4.4
/usr/local/jdk-1.7.0
os.arch=amd64
os.name=OpenBSD
os.version=4.4

OK, thanks. Instead of changing API I added a check that if File.pathSeparatorChar == ':' it is detected as unix.

http://hg.netbeans.org/core-main/rev/eb978ede9fe9

Integrated into 'main-golden', will be available in build *200809061401* on http://bits.netbeans.org/dev/nightly/ (upload may still be in progress)
Changeset: http://hg.netbeans.org/main/rev/eb978ede9fe9
User: Jiri Skrivanek <jskrivanek@netbeans.org>
Log: #145462 - If File.pathSeparatorChar == ':', detect OS as unix, if not resolved before.

This needs better fix with API review.

As jglick stated the previous change means that module code compiled against an older version of
org-openide-utilities.jar will not consider OpenBSD to be Unix if it uses OS_UNIX_MASK directly.
Please, review a new patch. It adds new public fields OS_OPENBSD and OS_UNIX_OTHER. It also deprecates OS_WINDOWS_MASK
and OS_UNIX_MASK fields and suggests to use isWindows() or isUnix() instead.

Created attachment 69384 [details]
API change patch.

Looks OK I think.

Will be implemented.

Fixed.

Integrated into 'main-golden', will be available in build *200809170201* on http://bits.netbeans.org/dev/nightly/ (upload may still be in progress)
Changeset: http://hg.netbeans.org/main/rev/f68864248915
User: Jiri Skrivanek <jskrivanek@netbeans.org>
Log: #145462 - Added a new Utilities.OS_OPENBSD and OS_UNIX_OTHER fields. Deprecated OS_WINDOWS_MASK and OS_UNIX_MASK.