This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 143505 - SQLExecutor doesn't support '#' comments.
Summary: SQLExecutor doesn't support '#' comments.
Status: VERIFIED FIXED
Alias: None
Product: db
Classification: Unclassified
Component: Code (show other bugs)
Version: 6.x
Hardware: All All
: P3 blocker (vote)
Assignee: David Vancouvering
URL:
Keywords:
Depends on:
Blocks: 134307
  Show dependency tree
 
Reported: 2008-08-11 17:30 UTC by David Vancouvering
Modified: 2008-08-14 15:51 UTC (History)
0 users

See Also:
Issue Type: DEFECT
Exception Reporter:


Attachments
sakila schema script (22.57 KB, text/plain)
2008-08-13 01:45 UTC, John Baker
Details

Note You need to log in before you can comment on or make changes to this bug.
Description David Vancouvering 2008-08-11 17:30:29 UTC
MySQL scripts can use '--' as well as '#" to delineate a line comment.  To be compatible with SQL scripts, we should
support this.
Comment 1 David Vancouvering 2008-08-11 17:32:49 UTC
1eb5eb8e0860
Comment 2 John Baker 2008-08-13 01:42:02 UTC
a command that follows a comment fails

Passes:
-- hello

Passes:
DELIMITER;;

Fails:
-- hello
DELIMITER;
Comment 3 John Baker 2008-08-13 01:45:16 UTC
Created attachment 67200 [details]
sakila schema script
Comment 4 John Baker 2008-08-13 01:46:11 UTC
please make sure the attached script executes successfully
Comment 5 Roman Mostyka 2008-08-13 12:37:43 UTC
I guess that John reopened wrong issue. I tried with pointed changeset and '#' works like a comment.
Comment 6 Roman Mostyka 2008-08-13 12:38:28 UTC
Verified with build 080812.
Comment 7 John Baker 2008-08-13 18:27:15 UTC
I'm also using the 080812 but the attached sakila schema script fails to execute as mentioned in desc3 
Comment 8 David Vancouvering 2008-08-13 18:36:13 UTC
The Sakila schema script works for me.  I had to make some adjustments to the standard script - in particular it has
problems with some of the delimiter statements.  The # comments work fine.

If you can reproduce this issue outside of the Sakila schema script, using a simple reproduction, please attach and re-open.
Comment 9 John Baker 2008-08-13 18:39:35 UTC
It looks like I meant to reopen 143250

Comment 10 Quality Engineering 2008-08-14 15:47:45 UTC
Integrated into 'main-golden', available in build *200808141419* on http://bits.netbeans.org/dev/nightly/
Changeset: http://hg.netbeans.org/main/rev/1eb5eb8e0860
User: David Van Couvering <davidvc@netbeans.org>
Log: #143505 - SQLExecutor and SQL Editor doesn't support '#' comments
Comment 11 Roman Mostyka 2008-08-14 15:50:27 UTC
This issue was filed by David and the n was fixed and verified by me with his changeset.
Comment 12 Roman Mostyka 2008-08-14 15:51:25 UTC
Fixed.
Comment 13 Roman Mostyka 2008-08-14 15:51:59 UTC
Verified.