This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.
open UI for Platform and Suite selection, used in first wizard step UI panel through friend package. According to issue 136248 vmd.componentssupport should have the same first UI for module platform and suite selection as apisupport.project. To reuse existing implementation it would be good to have panel with platform and suite selection UI exposed through friend package. See attached image for expected panel UI elements.
Created attachment 66093 [details] panel UI proposal
Created attachment 66094 [details] patch proposal
I think it is OK. Would be easier to evaluate if the patch included the intended usage in vmd.componentsupport. I assume you want this in for M2 based on the milestone for the dependent issue. Passing to Richard (new apisupport maintainer) in case he has any comments. Some minor comments: [JG01] Check license headers, at least missing in TypeChooserPanelImpl.java. (Should be set to CDDL+GPL automatically when you create any source file in a nb.org module. No? The date of creation says July 22 if my Cyrillic is right.) [JG02] Avoid static getMessage method; should use an explicit call to NbBundle.getMessage for each distinct localizable string. [JG03] initAccessibility should be replaced by the Accessibility properties in Matisse - makes it easier for future developers to see and tweak A11Y values. [JG04] Why is SUITE_ROOT a String? What would be the value?
thanks. I have tried to follow existing implementation. [JG01]fixed [JG02] fixed. But it seems to be a common practice. getMessage() is private, so shouldn't be dangerous. code became less readable after fix. [JG03] fixed [JG04] Why is SUITE_ROOT a String? What would be the value? String was used in original implementation and it suites needs well. i mean: org.netbeans.modules.apisupport.project.ui.wizard.NewModuleProjectData#setSuiteRoot(String)
Created attachment 66286 [details] patch for apisupport.project
Created attachment 66290 [details] please use this patch for apisupport.project instead. Previous has not one update lost because of http://www.selenic.com/mercurial/bts/issue961
Created attachment 66291 [details] patch for vmd.componentssupport to use API exposed by fix of 142283
Created attachment 66292 [details] both patches as bundle. attaching for the case you have same problem as me because of http://www.selenic.com/mercurial/bts/issue961
Looks OK. I'd rather create anonymous inner PropertyChangeListener than let BasicInfoVisualPanel implement it publicly, but that's no big deal. Just out of curiosity, how will your ModuleTypeChooserPanel differ from the standard one? Mobile Designer Components projects will all be standalone? I also suppose you've checked that the wizard still works for regular NBM projects :)? Tonda will address if and when could we actually commit this.
> Tonda will address if and when could we actually commit this. Too late for such a large change for 6.5 Beta. There is no time left now to test the functionality after integration of such a big patch. A separate repository will be created for Beta on Monday, leaving main repository open for further bugfixing. Then this change can be integrated. Anyway, the change has to go through API review process. Fast track review is OK.
> how will your ModuleTypeChooserPanel differ from the standard one? Mobile Designer Components projects will all be standalone? what do you call standard? I have just extracted panel from org.netbeans.modules.apisupport.project.ui.wizard.BasicInfoVisualPanel With a few changes for internal usage and with different read/store process for users outside apisupport.project Is it answer for your question? > I also suppose you've checked that the wizard still works for regular NBM projects :)? have tested all cases I have realized during code editing. Of course we can be sure only after QE testing. > Anyway, the change has to go through API review process. Fast track review is OK. does API opened to friends only needs API review process?
API changes affecting communication between different clusters deserve API review.
API review process is passed. see issue 144060. Latest patch version is available as attachment to issue 144060. rmichalsky has suggested me to apply patch myself.
BTW it was unnecessary to open a separate issue just for the API review; adds clutter to IZ. Better to have marked this issue API API_REVIEW_FAST, with apireviews on CC, and when review is done close as FIXED while committing the actual change.
fixed. http://hg.netbeans.org/main/rev/173c162bd62a module specification version is increased to 1.23.0
Integrated into 'main-golden', available in build *200808300201* on http://bits.netbeans.org/dev/nightly/ Changeset: http://hg.netbeans.org/main/rev/173c162bd62a User: akorostelev@netbeans.org Log: patch for issue #142283 - expose Module type and suite selection panel