This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 140525 - A11Y - Variables dialog issues
Summary: A11Y - Variables dialog issues
Status: RESOLVED WORKSFORME
Alias: None
Product: projects
Classification: Unclassified
Component: Generic Projects UI (show other bugs)
Version: 6.x
Hardware: PC Linux
: P3 blocker (vote)
Assignee: David Konecny
URL:
Keywords: A11Y
Depends on:
Blocks:
 
Reported: 2008-07-17 14:04 UTC by Tomas Danek
Modified: 2008-08-07 08:04 UTC (History)
0 users

See Also:
Issue Type: DEFECT
Exception Reporter:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Tomas Danek 2008-07-17 14:04:40 UTC
P1 according to bug priority guidelines, sorry:(

Variables dialog has following issues:
- missing label with mnemonic that would be binded with treeview
- missing a11y descriptions
- missing mnemonics

see full output:
 No Accessible name :

Class
    org.openide.explorer.view.BeanTreeView { | } 
Class
    org.openide.explorer.view.TreeView$ExplorerTree { | } 

No Accessible description :

Class
    javax.swing.JButton { Add | } 
Class
    javax.swing.JButton { Edit | } 
Class
    javax.swing.JButton { OK | } 
Class
    javax.swing.JButton { Remove | } 
Class
    org.netbeans.core.windows.services.NbDialog { Manage Variables | } 
Class
    org.openide.explorer.view.BeanTreeView { | } 
Class
    org.openide.explorer.view.TreeView$ExplorerTree { | } 

Label with LABEL_FOR not set : - none.

Components with no LABEL_FOR pointing to it :

Class
    org.openide.explorer.view.TreeView$ExplorerTree { | } 

Components with no mnemonic :

Class
    javax.swing.JButton { Add | } 
Class
    javax.swing.JButton { Edit | } 
Class
    javax.swing.JButton { Remove | } 

Components with wrong mnemonic (mnemonic isn't ASCII , label doesn't contain mnemonic): - none.
Comment 1 David Konecny 2008-07-17 20:59:34 UTC
Since when A11Y issues are P1 defects?!
Comment 2 Tomas Danek 2008-07-18 13:37:20 UTC
since http://qa.netbeans.org/bugzilla/bug_priority_guidelines.html ,

QUOT: Neither Accessible Name nor Accessible Description is set - P1
Comment 3 David Konecny 2008-07-23 07:02:17 UTC
Fixed as bd29ac551f57. Please verify everything is as expected. I installed A11Y Test module but it was complaining
about mnemonics being missing despite mnemonics are there so I do not know how to verify it. Thanks.
Comment 4 Tomas Danek 2008-07-29 10:53:35 UTC
Have to reopen, two things are still missing (minor things):

 No Accessible description :
   Class: org.netbeans.core.windows.services.NbDialog {  Manage Variables |  }

 Components with no LABEL_FOR pointing to it :
   Class: org.openide.explorer.view.TreeView$ExplorerTree {  Variables: |  N/A }

Basically just add a11y description for dialog, and bind label "Variables:" to point at treeview. You can verify this
that by ALT+V is focus moved to the treeview.
Comment 5 David Konecny 2008-07-30 04:12:41 UTC
Re. "Components with no LABEL_FOR pointing to it" - but org.openide.explorer.view.TreeView$ExplorerTree has associated label

Re. "No Accessible description : Class: org.netbeans.core.windows.services.NbDialog" - all I'm doing right now is
DialogDisplayer.getDefault().notify(new DialogDescriptor(new VariablesPanel(), ...)). Where do you want me to set a11y
description? VariablesPanel has both name and desc set.
Comment 6 Tomas Danek 2008-07-30 13:54:45 UTC
Re. label - You are right focus is there, my mistake, sorry.

Re. desc - I suppose you are doing this correctly, Dialog should obtain a11y desc from panel, so all you have to do is
to call 

 getAccessibleContext().setAccessibleDescription(...)

in constructor of panel. E.g. this (http://hg.netbeans.org/core-main/rev/f302b2f7cfba) works perfectly.
Comment 7 David Konecny 2008-07-30 22:17:47 UTC
Re. desc - both name and desc are already set on the panel. The value is N/A as I assume dialog title should "override"
them.
Comment 8 David Konecny 2008-08-07 08:04:19 UTC
Any comments on my last note?