This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 140499 - Align Options Panel wizard with new type of registration
Summary: Align Options Panel wizard with new type of registration
Status: RESOLVED FIXED
Alias: None
Product: apisupport
Classification: Unclassified
Component: Templates (show other bugs)
Version: 6.x
Hardware: All All
: P3 blocker (vote)
Assignee: Max Sauer
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-07-17 12:22 UTC by Max Sauer
Modified: 2008-09-24 05:57 UTC (History)
0 users

See Also:
Issue Type: DEFECT
Exception Reporter:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Max Sauer 2008-07-17 12:22:28 UTC
Wizard for Option Panel has to be updated in order to create options panels in declarative way.
Comment 1 Max Sauer 2008-09-18 14:16:21 UTC
Fixed.
---
http://hg.netbeans.org/main/rev/5f06aeacf11e
Comment 2 Jesse Glick 2008-09-19 12:05:04 UTC
And since when is this declarative registration style available? If only in 6.5 (which seems likely given the use of
'bundlevalue'), then people developing modules against a 6.0 or earlier platform will find that the wizard generates
unusable code - and since your patch does not appear to change the required versions of any dependent modules, the
user's module project will just throw errors at runtime, with no prior warning. At a minimum you need to check that the
platform is actually capable of supporting the code you are about to generate, and forbid the wizard to be completed if not.
Comment 3 Max Sauer 2008-09-19 12:10:24 UTC
Yes, only in 6.5. I'll have a look.
Comment 4 Quality Engineering 2008-09-19 17:35:43 UTC
Integrated into 'main-golden', will be available in build *200809191401* on http://bits.netbeans.org/dev/nightly/ (upload may still be in progress)
Changeset: http://hg.netbeans.org/main/rev/5f06aeacf11e
User: Max Sauer <msauer@netbeans.org>
Log: #140499: Align Options Panel wizard with new type of registration
Comment 5 Max Sauer 2008-09-23 13:20:42 UTC
I've added a check that prevents user form completing wizard in case selected platform is < 6.5. Please reopen in case you think there is a large number of 
users using 6.5 and developing Options panels for 6.1 and older platform.
---
http://hg.netbeans.org/main/rev/c616c4bdded8
Comment 6 Jesse Glick 2008-09-23 13:39:41 UTC
The idea of the fix is fine, but the actual fix is not. Never call NbPlatform.setHarnessLocation outside of the NetBeans
Platform Manager - you will silently reset people's platform preferences! (And, in this case, to a nondefault value.)

You cannot make this check based on the harness version, which is completely irrelevant (you can use the 6.5 platform
with the 6.1 harness or vice-versa); you need to check the specification version number of the Options API module (or
whatever it is your code will depend on) in the platform, using getModule.
Comment 7 Max Sauer 2008-09-23 15:14:01 UTC
Hopefully OK now..
---
http://hg.netbeans.org/main/rev/7dbd2f152738
Comment 8 Quality Engineering 2008-09-24 05:57:52 UTC
Integrated into 'main-golden', will be available in build *200809240201* on http://bits.netbeans.org/dev/nightly/ (upload may still be in progress)
Changeset: http://hg.netbeans.org/main/rev/c616c4bdded8
User: Max Sauer <msauer@netbeans.org>
Log: #140499: Preventing platform <6.5