This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 139950 - Missing schema for editor-bookmarks
Summary: Missing schema for editor-bookmarks
Status: RESOLVED FIXED
Alias: None
Product: editor
Classification: Unclassified
Component: Navigation (show other bugs)
Version: 6.x
Hardware: All All
: P3 blocker (vote)
Assignee: issues@editor
URL:
Keywords: SIMPLEFIX
Depends on:
Blocks:
 
Reported: 2008-07-14 21:43 UTC by Jesse Glick
Modified: 2008-07-17 09:09 UTC (History)
0 users

See Also:
Issue Type: DEFECT
Exception Reporter:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jesse Glick 2008-07-14 21:43:13 UTC 
The namespace http://www.netbeans.org/ns/editor-bookmarks/1 is defined in BookmarksXMLHandler, yet there is no XML
schema defining its contents. You should create a schema to validate this section, and register it in
ProjectXMLCatalog/editor-bookmarks/1.xsd in your layer.
Comment 1 Vitezslav Stejskal 2008-07-16 13:17:21 UTC 
http://hg.netbeans.org/main/rev/b0ab9b18e582
Comment 2 Jesse Glick 2008-07-16 16:25:09 UTC 
Looks good.

Is it correct that

<file>
  <url>...</url>
</file>

(with no <line>) is valid, or would <file>s always be deleted in case the last bookmark in them is deleted?

BTW minOccurs="1" maxOccurs="1" are both unnecessary as these are the defaults.
Comment 3 Quality Engineering 2008-07-17 04:29:43 UTC 
Integrated into 'main-golden', available in NB_Trunk_Production #324 build
Changeset: http://hg.netbeans.org/main/rev/b0ab9b18e582
User: Vita Stejskal <vstejskal@netbeans.org>
Log: #139950 (fixed): adding XML schema for editor-bookmarks
Comment 4 Vitezslav Stejskal 2008-07-17 08:56:05 UTC 
Good point. I checked the saving logic and there should never be the <file> element with only <url/> and no <line/>
elements. I'll update the schema. Thanks
Comment 5 Vitezslav Stejskal 2008-07-17 09:09:17 UTC 
Improved schema - http://hg.netbeans.org/main/rev/6d632f04c62f