This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 139253 - Simplify loader unit test template to account for declarative MIME resolvers
Summary: Simplify loader unit test template to account for declarative MIME resolvers
Status: RESOLVED FIXED
Alias: None
Product: apisupport
Classification: Unclassified
Component: Project (show other bugs)
Version: 6.x
Hardware: All All
: P3 blocker (vote)
Assignee: rmichalsky
URL:
Keywords:
Depends on:
Blocks: 138846
  Show dependency tree
 
Reported: 2008-07-08 14:27 UTC by Jesse Glick
Modified: 2008-09-16 14:52 UTC (History)
0 users

See Also:
Issue Type: DEFECT
Exception Reporter:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Jesse Glick 2008-07-08 14:27:29 UTC
As of issue #138846, XML MIME resolvers should be loaded even from unit tests. Therefore there is no need to call the
deprecated FileUtil.setMIMEType from the unit test template.

Also, for XML-based file types the unit test currently does not work.

I would recommend simply deleting the unit test from the loader template. It does not test anything interesting anyway.
If someone wants to write a meaningful unit test, they can now just do so, with no special setup required.
Comment 1 rmichalsky 2008-07-08 14:51:25 UTC
I'd vote for keeping the test there - it is already written, it IMO bothers nobody and gives a newbie module developer
an example how easy it is to write module tests :). Of course a test in apisupport ensuring that the generated test for
new file type succeeds would be proper, but only a basic api is used there that is not likely to change.

Of course I'll delete FileUtil.setMIMEType and allow for XML resolvers as soon as issue #138846 is ready.
Comment 2 Jesse Glick 2008-07-08 15:07:30 UTC
Would prefer to delete generated tests that do not test anything useful. They just add noise. But no strong opinion.
Comment 3 Jesse Glick 2008-07-25 14:24:05 UTC
"I'll delete FileUtil.setMIMEType and allow for XML resolvers as soon as issue #138846 is ready" - did this happen?
Comment 4 rmichalsky 2008-07-28 09:32:27 UTC
Not yet, thanks for reminder.
Comment 5 rmichalsky 2008-09-04 15:12:42 UTC
fixed locally, changeset #4d68f3075a4e
Comment 6 Quality Engineering 2008-09-05 06:07:27 UTC
Integrated into 'main-golden', will be available in build *200809050201* on http://bits.netbeans.org/dev/nightly/ (upload may still be in progress)
Changeset: http://hg.netbeans.org/main/rev/4d68f3075a4e
User: Richard Michalsky <rmichalsky@netbeans.org>
Log: #139253: Simplify loader unit test template