This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 138772 - Do not use reflection from contrib/modulemanager -> o.n.bootstrap/core.startup
Summary: Do not use reflection from contrib/modulemanager -> o.n.bootstrap/core.startup
Status: RESOLVED FIXED
Alias: None
Product: contrib
Classification: Unclassified
Component: Module Manager (show other bugs)
Version: 6.x
Hardware: All All
: P2 blocker (vote)
Assignee: Jiri Rechtacek
URL:
Keywords: ARCH
Depends on:
Blocks:
 
Reported: 2008-07-02 03:31 UTC by Jesse Glick
Modified: 2008-09-25 14:51 UTC (History)
0 users

See Also:
Issue Type: DEFECT
Exception Reporter:

Attachments
Initial patch for main repo (3.71 KB, patch)
2008-07-02 03:35 UTC, Jesse Glick 		Details | Diff
Initial patch for contrib repo (9.00 KB, patch)
2008-07-02 03:40 UTC, Jesse Glick 		Details | Diff
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jesse Glick 2008-07-02 03:31:37 UTC 
There is a lot of reflection in contrib/modulemanager, which makes it difficult to see what it is really using from the
module system. I don't see any particular reason to use reflection this way. Should be simpler to just have a friend
dep. Will attach start of patch. If completed, Hacks would disappear altogether.
Comment 1 Jesse Glick 2008-07-02 03:35:53 UTC 
Created attachment 63790 [details]
Initial patch for main repo
Comment 2 Jesse Glick 2008-07-02 03:40:34 UTC 
Created attachment 63791 [details]
Initial patch for contrib repo
Comment 3 Jiri Rechtacek 2008-07-02 08:49:38 UTC 
Sure. I'll take care of it after my vacation. I thought I shouldn't introduce a new friend contract for contrib modules
thus I have used such hacks. This patch will improve the code a lot.
Comment 4 Jesse Glick 2008-07-02 16:13:44 UTC 
I don't think it really matters whether the "friend" is in contrib or not. It still gets built every 8 hours by
javadoc-nbms, so with a simple friend dep, any incompatible changes to core.startup that affect modulemanager will be
reported quickly and can get fixed.