This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.
UI Spec: http://wiki.netbeans.org/GotoSpringBeanUISpecification Please note. This feature has is to be delivered for 6.5 M1.
Thanks for writing the spec and filing the review request! I have a few clarifying questions. If the user hits enter in the Go To dialog, the IDE would open a spring configuration file and put the cursor on the line in the editor where the bean is defined. Is that correct? This feature - implemented as a separate dialog with special shortcut - seems to me as too heavyweight for jumping inside an XML file. Do we cover navigation between the source file and bean definition in the configuration file (and vice versa)? If we have that, is there still a need to jump into the XML file without having the bean file open? I'm not against the feature, just looking at the big picture we're introducing more and more "Go to <something>" dialogs that do essentially the same. The user types a name and from the results selects the file to jump into. A special dialog and shortcut, for all kinds of things to jump into, adds a huge complexity into the IDE (length of menus, more shortcuts). If it cannot be solve otherwise, I'm okay with the change. Please let me know what you think about it. Ccing Ondrej to see another item that can be integrated into the QuickSearch feature. Hopefully in the future we will replace all Go To dialogs with a single concise feature with easy to remember shortcut.
Yes, on hitting Enter, the IDE would open a spring configuration file and put the cursor on the line in the editor where the bean is defined. Spring projects will typically have many Spring configuration XML files. So the dialog is more for jumping to one of the beans in several XML files in the open Spring project(s) than jumping in a single XML file. Yes, we cover navigation between a bean and it's java source file through hyperlinking in the XML configuration file, but there is no way to navigate from a source file to it's corresponding bean (please note that a single java source file can be associated with multiple bean definitions, but not vice versa). IMO, there is no other way of doing this.
Yes, there's probably no other way around it at the moment. Maybe another idea would be to integrate it into the Go to Type dialog. The user types a bean name and based on the icon and maybe some other textual clues she would distinguish it from other items and get to the bean definition. How about that?
My initial implementation was an integration with the existing Go to Type dialog. I am reproducing Andrei Badea's review comments on the same (I agree with both comments totally): - when you need to search for beans you only want to see beans -- you don't want to see types. - when you want types, you only want types -- not Spring beans. Moreover, users will mostly search for types, so by plugging into GtT you are actually slowing it down. The second issue is extremely important, and became painfully visible when I implemented the initial prototype which integrated with GtT instead of a new dialog.
Regarding the speed, that's the matter of proper implementation I would say. How many beans users normally have in their projects? Is it thousands? I'm sure they have powerful-enough machines to search through it fast. I see your point about types versus beans. I still hope in one point we would get to a single dialog/shortcut the user would use to search through everything and it will actually be fast. Currently it works like this: - do you want to open a java class file, use this shortcut - do you want to open a properties file, use another shortcut - do you want to open an xml file, use the same shortcut as in the case of properties file - do you want to open a bean file and select the bean, use yet another shortcut I'm sure users would eventually learn it and become productive, but I don't think it really matches their expectations. To come up with better solution, it would need some prototyping that's already under way. We'll see how it goes. For 6.5 let's go with a separate dialog. I've updated the permanent UI spec: http://wiki.netbeans.org/MainMenu Thanks for submitting the spec for review!