This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.
Create a wrapper module for Apache Commons Net in IDE cluster. The reason for this is that we would like to use Commons Net in PHP cluster but because commons-net.jar (and jakarta-oro.jar) is already used in Mobility, it has to be in IDE cluster (I don't want to have these 2 jars in 2 places). I will provide 2 patches - one for wrapper module, one for mobility.deployment.ftpscp module.
Created attachment 62058 [details] patch for wrapper module
Created attachment 62059 [details] patch for mobility.deployment.ftpscp module
If anyone has any comments/ideas/objections, please let me know, thanks.
[JG01] Perhaps jakarta-oro.jar belongs in a different module? I don't see what it is doing here. [JG02] The change removes jakarta-oro.jar from the Ant CP - intentional?
[JG01] Archive jakarta-oro.jar is a required dependency for apache-commons.jar and I would prefer to create a separate module for it after some other module needs it. Am I missing something? [JG02] Definitely not - in fact I spent about 2 hours yesterday evening by solving this and wasn't really sure how to put jakarta-oro.jar to the Ant CP - apparently no success. What is the correct way to do this Jesse, please? I tried to run FTP task (in mobile application) and it was OK after adding jakarta-oro.jar to the project.xml and project.properties so I hoped that it is OK. Sorry about that. Jesse, thanks a lot for the review.
JG01 - generally I would not encourage dumping unrelated libraries into one library wrapper module. JG02 - you are already adding commons-net.jar to the Ant CP in the correct fashion (using AutomaticExtraClasspath.url); I was just asking why you did not do the same for jakarta-oro.jar as well (as the current code does in the oddly named FtpScpClasspathProvider).
[JG01] New wrapper module for Jakarta ORO created. [JG02] Fixed, you are right, of course. Attaching refreshed patch.
Created attachment 62105 [details] updated patch for wrapper modules
Look good for me now.
One minor change/improvement - Jakarta ORO doesn't provide public API but only friend API (the only client is Commons Net). Attaching updated patch.
Created attachment 62253 [details] updated patch for wrapper modules
If there are no objections, I'll push this on monday.
Integrated. http://hg.netbeans.org/main/rev/ed1e66937c3f http://hg.netbeans.org/main/rev/a464866c2d26
Integrated into 'main-golden', available in NB_Trunk_Production #251 build Changeset: http://hg.netbeans.org/main/rev/ed1e66937c3f User: Tomas Mysik <tmysik@netbeans.org> Log: #135990: Create a wrapper module for Apache Commons Net in IDE cluster [Part 1]