This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 131175 - Nonsensical API
Summary: Nonsensical API
Status: RESOLVED FIXED
Alias: None
Product: cnd
Classification: Unclassified
Component: Debugger (show other bugs)
Version: 6.x
Hardware: All All
: P2 blocker (vote)
Assignee: _ gordonp
URL:
Keywords: API
Depends on:
Blocks:
 
Reported: 2008-03-26 15:06 UTC by Jesse Glick
Modified: 2009-06-25 10:59 UTC (History)
1 user (show)

See Also:
Issue Type: DEFECT
Exception Reporter:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Jesse Glick 2008-03-26 15:06:14 UTC
Trunk #1312 failed to generate signature tests:

[sigtest] Hidden class found: org.netbeans.modules.cnd.debugger.gdb.IOManager$Line in method public void
org.netbeans.modules.cnd.debugger.gdb.IOManager.println(java.lang.String,org.netbeans.modules.cnd.debugger.gdb.IOManager$Line)
in class org.netbeans.modules.cnd.debugger.gdb.IOManager

In fact manual inspection confirms that this method makes no sense. It is a public method in a public class in a public
package, yet the type of one of its arguments is package-private. You must make the Line class public, or make the
method package-private, etc.
Comment 1 _ gordonp 2008-03-26 15:53:57 UTC
I'll make the change, but I'm not sure why its a fire drill 5 days before an FCS
code freeze. The IOManager in gdb was copied almost verbatim from the JPDA version
which has used this exact same construct since 2/2004 (and still does:-).

If it suddenly caused a test failure then I suggest looking at the test, especially
if it flagged gdb but not debugger.jpda.ui.
Comment 2 Jesse Glick 2008-03-26 16:00:49 UTC
debugger.jpda.ui does not try to make a public package out of it. You are trying to do so. While the code in
debugger.jpda.ui would be eligible for some kind of lint warning to reduce access scope (the public method in the public
class could not in fact be called by a class in another package in that module anyway), it is not part of an exposed API.
Comment 3 _ gordonp 2008-03-26 17:46:26 UTC
Fixed with http://hg.netbeans.org/main?cmd=changeset;node=351994d214e3.