This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.
see 130235 - Maros requested I file issue for refactoring for that situation.
For what situation? Issue 130235 is fixed. Please follow rules. Thanks. http://qa.netbeans.org/bugzilla/rules.html
AFAIK Ken tested the scenario in Refactoring and characters did not display correctly, you should probably attach those screenshots here.
to clarify there might be 2 separate things here 1. to do the fix for 130235 for refactoring; Maros can give you the info on that. 2. but also, on mac, was seen what is in attached gif, which may or may not be related to the fix for 130235 - if its separate, a separate issue can be filed. ken.frank@sun.com
Created attachment 58608 [details] image
more on the case for mac local history and the refactor preview diff view does not show the multibyte ok for one of the 2 diff windows of each. using utf-8 or mac-roman(an euc-jp) encoding - local history - current view mbyte is ok; previous one is not refactor preview - current view is ok; to be refactored window is not attached is gif.
I will try to adopt the fix from local history.
This is not P2 according bug priority guidelines. Just incorrect visual appearance. Anyway Dan will fix it for 6.1.
I have investigated the related code. I have found there is no need to make a fix for issue 130235 in refactoring preview. Local history and the versioning modules create temporary files when displaying diffs. There was a problem that these files have not been associated with the proper encoding. On the other hand, refactoring preview does not store content of new sources in temporary files, it writes the content into editor documents, so we do not need to handle encoding like the local history does. As for the second problem reported against Mac, it seems it is a different issue, perhaps something wrong in editor. Issue 130235 reports missing Japanese characters in both views (old source view, new source view). When examining the attached gif, there are only some Japanese characters (not all) missing in one view. Have you managed to reproduce this problem also on another platform?
am marking as incomplete now; since we are talking just about the mac part, I can't replicate this on new leopard installed os, using both utf8 or euc-jp project encodings. (was using 10.4 mac before) I will keep looking at this , but for now, lets waive it or move to p3 unless incomplete keyword is enough to keep from dashboard for 6.1 ken.frank@sun.com
moving opened issues from TM <= 6.1 to TM=Dev
based on below comments, can this one be closed, if the fix related to 130235 is not needed here ? ken.frank@sun.com
Sure, closing as INVALID since it was not a refactoring bug.