This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 129121 - Show annotations - Revision numbers not displayed
Summary: Show annotations - Revision numbers not displayed
Status: VERIFIED FIXED
Alias: None
Product: versioncontrol
Classification: Unclassified
Component: Code (show other bugs)
Version: 6.x
Hardware: All All
: P1 blocker (vote)
Assignee: issues@versioncontrol
URL:
Keywords:
: 131244 132462 (view as bug list)
Depends on:
Blocks:
 
Reported: 2008-03-04 13:02 UTC by kate
Modified: 2008-04-09 23:59 UTC (History)
3 users (show)

See Also:
Issue Type: DEFECT
Exception Reporter:


Attachments
screenshot (revision numbers are missing in the left column) (52.66 KB, image/png)
2008-03-04 13:03 UTC, kate
Details

Note You need to log in before you can comment on or make changes to this bug.
Description kate 2008-03-04 13:02:24 UTC
Product Version: NetBeans IDE Dev (Build 200803031206)
Java: 1.6.0_01; Java HotSpot(TM) Client VM 1.6.0_01-b06
System: SunOS version 5.11 running on x86; ISO646-US; en (nb)

On Solaris, I cannot see revision numbers (for source code lines) in the left column after I select 'Show annotations'
for that file. On the other hand, in the right column there are version 'stripes' related to different versions of this
file. 

Please, is there any way how to get revision numbers to the annotations column? 
On other platforms, revision numbers are displayed implicitly after 'Show annotations', I think.
Comment 1 kate 2008-03-04 13:03:29 UTC
Created attachment 57726 [details]
screenshot (revision numbers are missing in the left column)
Comment 2 Tomas Stupka 2008-03-04 13:16:57 UTC
could you please check if this is also reproducible with another vcs? cvs or mercurial.

thanks
Comment 3 Tomas Stupka 2008-03-04 13:20:08 UTC
ok. ppis reproduced on solaris 10, jdk1.5.0_12
Comment 4 Peter Pis 2008-03-05 10:20:07 UTC
Doesn't work all VCS integrations.
Comment 5 Maros Sandor 2008-03-05 10:35:36 UTC
I took a look inside AnnotationBar.paintComponent() and the bar's location as returned by JComponent.getLocation()
method is [59, 2700] which is why the bar is not completely visible. AFAIK I am not setting the location explicitly,
editor please evaluate.
Comment 6 novakm 2008-03-05 11:41:04 UTC
*** Issue 129263 has been marked as a duplicate of this issue. ***
Comment 7 Vitezslav Stejskal 2008-03-05 11:51:58 UTC
Ok, I'm going to investigate this.
Comment 8 Vitezslav Stejskal 2008-03-05 14:51:59 UTC
I'm not sure why this got broken without any apparent change, but the AnnotationBar component seems to override
getMaximumSize() and provide wrong dimensions, which confuses the layout manager. I was able to restore correct behavior
simply by commenting out this method. I'm going to check annotation panels in the other VCS modules as well and commit
the changes.
Comment 9 Vitezslav Stejskal 2008-03-06 08:56:50 UTC
I pushed the changes. VCS guys please review.
http://hg.netbeans.org/main/rev/2832dd1eab96
Comment 10 Vitezslav Stejskal 2008-03-06 08:58:18 UTC
.
Comment 11 Maros Sandor 2008-03-06 09:05:31 UTC
I have no problems with changes made as long as they solve the issue. Thanks for the effort. I wonder why it suddenly
stopped working after 2 years.
Comment 12 kate 2008-03-17 11:11:59 UTC
verified for CVS on

Product Version: NetBeans IDE Dev (Build 200803170003)
Java: 1.6.0_01; Java HotSpot(TM) Client VM 1.6.0_01-b06
System: SunOS version 5.11 running on x86; ISO646-US; en (nb)
Comment 13 Maros Sandor 2008-04-01 10:02:51 UTC
*** Issue 131244 has been marked as a duplicate of this issue. ***
Comment 14 Maros Sandor 2008-04-01 10:04:47 UTC
Still reproducible in current trunk.
Comment 15 Vitezslav Stejskal 2008-04-01 10:32:06 UTC
Ok, I'll have a look again...
Comment 16 Vitezslav Stejskal 2008-04-01 11:17:23 UTC
Strange, it's working fine in my build from this morning. I also downloaded the build from release61 clone and checked
that it's working there again.
Comment 17 Maros Sandor 2008-04-01 11:56:18 UTC
I can always reproduce it on Windows XP SP2 with JDK 6.0u4, what is your setup?
Comment 18 Peter Pis 2008-04-01 12:06:36 UTC
Reopen. Try to view annotations for org.netbeans.modules.form.FormUtils
for example.
Comment 19 Vitezslav Stejskal 2008-04-01 17:21:15 UTC
For some reason the max size was still not right. It looks like it's set to 32767 by default, which is not enough for
long documents. So I changed the four AnnotationBar classes I am aware of to set the max size explicitly to
Integer.MAX_VALUE. I tested it only with Mercurial and the FormUtils file, which Petr suggested. Somebody should test
the other VCSes too.

I assume that this needs to be merged to release61 clone. But I'll leave this to VCS folks since the defect was actually
in their code. :-)

http://hg.netbeans.org/main/rev/3d9e60f2bbd4
Comment 20 Vitezslav Stejskal 2008-04-01 17:21:54 UTC
Fixed in the main.
Comment 21 Peter Pis 2008-04-02 14:36:05 UTC
Verified for CVS and Subversion.
Comment 22 Maros Sandor 2008-04-02 16:19:20 UTC
Integrated into release61.
08a7fa039c4c
Comment 23 kate 2008-04-07 12:33:10 UTC
verified in rc 200804040802 (Solaris - subversion, cvs)
Comment 24 janicki 2008-04-09 23:59:52 UTC
*** Issue 132462 has been marked as a duplicate of this issue. ***