This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 127239 - Layer folder marked as invalid
Summary: Layer folder marked as invalid
Status: RESOLVED FIXED
Alias: None
Product: platform
Classification: Unclassified
Component: Data Systems (show other bugs)
Version: 6.x
Hardware: All All
: P1 blocker (vote)
Assignee: Jaroslav Tulach
URL: http://deadlock.netbeans.org/hudson/j...
Keywords: TEST
: 126521 127295 (view as bug list)
Depends on:
Blocks:
 
Reported: 2008-02-12 22:56 UTC by Jesse Glick
Modified: 2008-12-22 11:37 UTC (History)
2 users (show)

See Also:
Issue Type: DEFECT
Exception Reporter:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Jesse Glick 2008-02-12 22:56:36 UTC
uml.parser.java/src/org/netbeans/modules/uml/parser/java/resources/layer.xml defines a folder parsers/ with some
children. VLCT is choking trying to check it for folder ordering:

java.lang.IllegalArgumentException: org.openide.loaders.DataObjectNotFoundException: MultiFileObject@b99561[parsers]
	at org.openide.loaders.DataFolder.findFolder(DataFolder.java:517)
	at org.netbeans.core.projects.ValidateLayerConsistencyTest.loadChildren(ValidateLayerConsistencyTest.java:559)
	at org.netbeans.core.projects.ValidateLayerConsistencyTest.testFolderOrdering(ValidateLayerConsistencyTest.java:523)
	[...]
Caused by: org.openide.loaders.DataObjectNotFoundException: MultiFileObject@b99561[parsers]
	at org.openide.loaders.DataObject.find(DataObject.java:498)
	at org.openide.loaders.DataFolder.findFolder(DataFolder.java:515)
Caused by: org.openide.filesystems.FileStateInvalidException: MultiFileObject@b99561[parsers]
	at org.openide.loaders.DataObject.find(DataObject.java:478)
Comment 1 rmatous 2008-02-13 11:55:59 UTC
Now url points to:
at org.openide.loaders.FolderList.getChildrenList(FolderList.java:268)
at org.openide.loaders.FolderList.getChildren(FolderList.java:247)
at org.openide.loaders.DataFolder.getChildren(DataFolder.java:278)
at org.netbeans.core.projects.ValidateLayerConsistencyTest.loadChildren(ValidateLayerConsistencyTest.java:559)
at org.netbeans.core.projects.ValidateLayerConsistencyTest.testFolderOrdering(ValidateLayerConsistencyTest.java:553)

P2 for me. 
Comment 3 rmatous 2008-02-13 14:20:25 UTC
Third way how this test crashes: 
java.lang.NullPointerException
at org.netbeans.core.projects.ValidateLayerConsistencyTest$3.findResourceOn(ValidateLayerConsistencyTest.java:548)
Comment 4 Jesse Glick 2008-02-13 17:37:45 UTC
Persistently failing commit validation is P1 to me.

Where do you see the NPE from ValidateLayerConsistencyTest$3.findResourceOn? Probably this should read

FileObject f = fs.findResource(path + '/' + res);
return f != null && Boolean.TRUE.equals(f.getAttribute("hidden")) ? null : f;
       ^^^^^^^^^^^^

though I am not sure why this exception would never have been thrown before.
Comment 5 Jesse Glick 2008-02-14 01:26:30 UTC
Now says

org.openide.filesystems.FileStateInvalidException:
MultiFileObject@13634d8[org-netbeans-api-project-libraries/LibraryTypeProviders] parent:
MultiFileObject@cdd17f[org-netbeans-api-project-libraries] validFlag: false validRoot: MultiFileObject@1ddd83c[root of
SystemFileSystem[org.netbeans.core.startup.layers.SystemFileSystem@14563aa]] isValidRoot: true
	at org.openide.loaders.DataObject.find(DataObject.java:478)

but I can't see anything wrong in

java.j2seplatform/src/org/netbeans/modules/java/j2seplatform/resources/layer.xml
project.libraries/src/org/netbeans/modules/project/libraries/resources/mf-layer.xml
visualweb.project.jsf/src/org/netbeans/modules/visualweb/project/jsf/resources/layer.xml

Note that I cannot reproduce on my own build using cluster.config=basic.
Comment 6 rmatous 2008-02-14 09:18:22 UTC
MFS, MFO code no touched for month maybe years, so regression caused by usage it. 
I think this issue could be evaluated in DS, probably caused by latest perf.effort. Yarda is aware of it AFAIK.
Comment 7 Jaroslav Tulach 2008-02-14 12:52:14 UTC
changeset:   67410:96b51a8a798b
parent:      67405:1c3feb8e3d88
user:        Jaroslav Tulach <jtulach@netbeans.org>
date:        Thu Feb 14 13:49:25 2008 +0100
summary:     #127239: Likely fix. It keeps the cache in memory, instead of re-reading it from disk, but under certain, 
yet unknown condition, the re-read is causing quite a big mess by loosing filebojects
Comment 8 Jaroslav Tulach 2008-02-20 14:17:38 UTC
*** Issue 127295 has been marked as a duplicate of this issue. ***
Comment 9 Jaroslav Tulach 2008-02-23 11:52:53 UTC
*** Issue 126521 has been marked as a duplicate of this issue. ***