This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 126974 - https:// is missing for hint in Clone Other.
Summary: https:// is missing for hint in Clone Other.
Status: VERIFIED FIXED
Alias: None
Product: versioncontrol
Classification: Unclassified
Component: Mercurial (show other bugs)
Version: 6.x
Hardware: All All
: P1 blocker (vote)
Assignee: issues@versioncontrol
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-02-08 08:45 UTC by Peter Pis
Modified: 2008-02-15 09:07 UTC (History)
1 user (show)

See Also:
Issue Type: DEFECT
Exception Reporter:


Attachments
Proposed patch (13.53 KB, text/plain)
2008-02-09 00:26 UTC, John Rice
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Peter Pis 2008-02-08 08:45:09 UTC
Product Version: NetBeans IDE 6.0 (Build 200711261600)
Java: 1.6.0_03; Java HotSpot(TM) Client VM 1.6.0_03-b05
System: Windows XP version 5.1 running on x86; Cp1252; en_GB (nb)
Userdir: D:\ide\6.0\user

Steps:
1. Invoke "Versioning | Mercurial | Clone Other...".
2. For "Repository URL" enter valid "https://" location.

Push "Next". 

https:// is connection allowed and therefore the hint displayed underneath doesn't list https://. Please add it there too.
Comment 1 John Rice 2008-02-08 11:25:28 UTC
Changes required:

diff -r aa7aba9b3692 mercurial/src/org/netbeans/modules/mercurial/ui/repository/Repository.java
--- a/mercurial/src/org/netbeans/modules/mercurial/ui/repository/Repository.java        Thu Feb 07 09:52:51 2008 +0000
+++ b/mercurial/src/org/netbeans/modules/mercurial/ui/repository/Repository.java        Fri Feb 08 11:22:52 2008 +0000
@@ -195,7 +195,7 @@ public class Repository implements Actio
             // templates for supported connection methods        
             recentRoots.add(new RepositoryConnection("file:///"));      // NOI18N
             recentRoots.add(new RepositoryConnection("http://"));       // NOI18N
-            //recentRoots.add(new RepositoryConnection("https://"));      // NOI18N
+            recentRoots.add(new RepositoryConnection("https://"));      // NOI18N
             recentRoots.add(new RepositoryConnection("static-http://"));        // NOI18N
             recentRoots.add(new RepositoryConnection("ssh://"));        // NOI18N
         };
@@ -400,10 +400,10 @@ public class Repository implements Actio
             repositoryPanel.tipLabel.setText(HTTP_URL_HELP);
             authFields = true;
             proxyFields = true;
-        //} else if(selectedUrlString.startsWith("https:")) {                     // NOI18N
-            //repositoryPanel.tipLabel.setText(HTTPS_URL_HELP);
+        } else if(selectedUrlString.startsWith("https:")) {                     // NOI18N
+            repositoryPanel.tipLabel.setText(HTTPS_URL_HELP);
             //authFields = true;
-            //proxyFields = true;
+            proxyFields = true;
         } else if(selectedUrlString.startsWith("static-http:")) {                       // NOI18N
             repositoryPanel.tipLabel.setText(STATIC_HTTP_URL_HELP);
             authFields = true;
@@ -415,8 +415,8 @@ public class Repository implements Actio
             repositoryPanel.tipLabel.setText(LOCAL_URL_HELP);
         } else {
             repositoryPanel.tipLabel.setText(NbBundle.getMessage(Repository.class, "MSG_Repository_Url_Help", new
Object [] { // NOI18N
-                //LOCAL_URL_HELP, HTTP_URL_HELP, HTTPS_URL_HELP, STATIC_HTTP_URL_HELP, SSH_URL_HELP
-                LOCAL_URL_HELP, HTTP_URL_HELP, STATIC_HTTP_URL_HELP, SSH_URL_HELP
+                LOCAL_URL_HELP, HTTP_URL_HELP, HTTPS_URL_HELP, STATIC_HTTP_URL_HELP, SSH_URL_HELP
+                //LOCAL_URL_HELP, HTTP_URL_HELP, STATIC_HTTP_URL_HELP, SSH_URL_HELP
             }));
         }
 
Comment 2 John Rice 2008-02-09 00:26:11 UTC
Created attachment 56369 [details]
Proposed patch
Comment 3 John Rice 2008-02-09 00:37:40 UTC
Comitted to head - this is the patch that should be applied to the release601_fixes for the release of the NetBeans
plugin on the UC NOT the diff I initially pasted below, it does not take account of the requried RepositoryPanel
resizing and bundle file changes.

changeset:   66637:ed52e1a38d86
user:        jrice@netbeans.org
date:        Sat Feb 09 00:20:05 2008 +0000
files:       mercurial/src/org/netbeans/modules/mercurial/ui/repository/Bundle.properties
mercurial/src/org/netbeans/modules/mercurial/ui/repository/Repository.java
mercurial/src/org/netbeans/modules/mercurial/ui/repository/RepositoryPanel.form
mercurial/src/org/netbeans/modules/mercurial/ui/repository/RepositoryPanel.java
description:
#126974 & #126975: Require tooltip for https and Clone Other dialog needs some resizing to diaplay the tooltip - fixes
both issues.
Comment 4 Peter Pis 2008-02-12 08:14:49 UTC
Verified in latest mercurial nbm. Anyway, has it been already integrated into release601_fixes branch?
Comment 5 Padraig Obriain 2008-02-12 11:01:36 UTC
Yes. These changes were in the NBM I sent you yesterday.
Comment 6 John Rice 2008-02-12 23:15:23 UTC
Committed to head and changes for release601_fixes branch tared and sent.
Comment 7 Peter Pis 2008-02-15 09:07:33 UTC
Verified.