Please use the Apache issue tracking system for new NetBeans issues (https://issues.apache.org/jira/projects/NETBEANS0/issues) !!
Bug 126495 - missing save before commit
missing save before commit
Status: RESOLVED FIXED
Product: versioncontrol
Classification: Unclassified
Component: Mercurial
6.x
All All
: P3 (vote)
: TBD
Assigned To: issues@versioncontrol
issues@versioncontrol
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2008-02-01 13:25 UTC by Tomas Stupka
Modified: 2008-02-05 08:56 UTC (History)
0 users

See Also:
Issue Type: DEFECT
:


Attachments
proposed patch (45.20 KB, patch)
2008-02-01 16:11 UTC, Padraig Obriain
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Tomas Stupka 2008-02-01 13:25:54 UTC
mercurial isn't saving changed files before commit what causes that not all changes visible in the editor will be commited.
Comment 1 Padraig Obriain 2008-02-01 14:07:40 UTC
I have compared the behavior of subversion with mercurial and subversion seems to save changed file before commit dialog
is displayed.

Can you tell me how this is done?
Comment 2 Tomas Stupka 2008-02-01 14:25:40 UTC
ContextAction.performAction() {
   ...
   LifecycleManager.getDefault().saveAll();   
   ...
}

Comment 3 Padraig Obriain 2008-02-01 16:11:41 UTC
Created attachment 55921 [details]
proposed patch
Comment 4 Padraig Obriain 2008-02-01 16:21:18 UTC
I have added ui/actions/ContextAction.java and made our menu actions extend ContextAction instead of AbstractAction.
I also moved the call to if(!Mercurial.getInstance().isGoodVersionAndNotify()) return; to ContextAction.actionPerfomed.
Comment 5 Padraig Obriain 2008-02-05 08:56:17 UTC
changeset:   65546:6fe1f6d70356
user:        padraigob@netbeans.org
date:        Fri Feb 01 16:09:20 2008 +0000
files:       mercurial/src/org/netbeans/modules/mercurial/ui/actions/ContextAction.java
mercurial/src/org/netbeans/modules/mercurial/ui/add/AddAction.java
mercurial/src/org/netbeans/modules/mercurial/ui/annotate/AnnotateAction.java
mercurial/src/org/netbeans/modules/mercurial/ui/clone/CloneAction.java
mercurial/src/org/netbeans/modules/mercurial/ui/clone/CloneExternalAction.java
mercurial/src/org/netbeans/modules/mercurial/ui/commit/CommitAction.java
mercurial/src/org/netbeans/modules/mercurial/ui/commit/ExcludeFromCommitAction.java
mercurial/src/org/netbeans/modules/mercurial/ui/create/CreateAction.java
mercurial/src/org/netbeans/modules/mercurial/ui/diff/DiffAction.java
mercurial/src/org/netbeans/modules/mercurial/ui/diff/ExportDiffAction.java
mercurial/src/org/netbeans/modules/mercurial/ui/diff/ImportDiffAction.java
mercurial/src/org/netbeans/modules/mercurial/ui/ignore/IgnoreAction.java
mercurial/src/org/netbeans/modules/mercurial/ui/log/LogAction.java
mercurial/src/org/netbeans/modules/mercurial/ui/log/OutAction.java
mercurial/src/org/netbeans/modules/mercurial/ui/log/SearchHistoryAction.java
mercurial/src/org/netbeans/modules/mercurial/ui/merge/MergeAction.java
mercurial/src/org/netbeans/modules/mercurial/ui/properties/PropertiesAction.java
mercurial/src/org/netbeans/modules/mercurial/ui/pull/FetchAction.java
mercurial/src/org/netbeans/modules/mercurial/ui/pull/PullAction.java
mercurial/src/org/netbeans/modules/mercurial/ui/pull/PullOtherAction.java
mercurial/src/org/netbeans/modules/mercurial/ui/push/PushAction.java
mercurial/src/org/netbeans/modules/mercurial/ui/push/PushOtherAction.java
mercurial/src/org/netbeans/modules/mercurial/ui/remove/RemoveAction.java
mercurial/src/org/netbeans/modules/mercurial/ui/rollback/RollbackAction.java
mercurial/src/org/netbeans/modules/mercurial/ui/serve/ServeAction.java
mercurial/src/org/netbeans/modules/mercurial/ui/status/StatusAction.java
mercurial/src/org/netbeans/modules/mercurial/ui/update/ConflictResolvedAction.java
mercurial/src/org/netbeans/modules/mercurial/ui/update/ResolveConflictsAction.java
mercurial/src/org/netbeans/modules/mercurial/ui/update/RevertModificationsAction.java
mercurial/src/org/netbeans/modules/mercurial/ui/update/UpdateAction.java
mercurial/src/org/netbeans/modules/mercurial/ui/view/ViewAction.java
description:
126495: save changed files before executing menu item


changeset:   65835:47bec22ca462
tag:         tip
parent:      65546:6fe1f6d70356
parent:      65834:1bf83fdabaad
user:        padraigob@netbeans.org
date:        Tue Feb 05 08:49:49 2008 +0000
files:       gsf/src/org/netbeans/modules/gsfret/source/usages/NBLockFactory.java
ruby.railsprojects/src/org/netbeans/modules/ruby/railsprojects/server/Mongrel.java
ruby.railsprojects/src/org/netbeans/modules/ruby/railsprojects/server/RailsAppChildrenFactory.java
ruby.railsprojects/src/org/netbeans/modules/ruby/railsprojects/server/RailsServerManager.java
ruby.railsprojects/src/org/netbeans/modules/ruby/railsprojects/server/RubyServer.java
ruby.railsprojects/src/org/netbeans/modules/ruby/railsprojects/server/ServerRegistry.java
ruby.railsprojects/src/org/netbeans/modules/ruby/railsprojects/server/WEBrick.java
ruby.railsprojects/src/org/netbeans/modules/ruby/railsprojects/server/nodes/RubyServerNode.java
ruby.railsprojects/test/unit/src/org/netbeans/modules/ruby/railsprojects/server/RubyServerTest.java
spring.beans/src/org/netbeans/modules/spring/beans/completion/Bundle.properties
spring.beans/src/org/netbeans/modules/spring/beans/completion/CompletionManager.java
spring.beans/src/org/netbeans/modules/spring/beans/completion/SpringXMLConfigCompletionDoc.java
spring.beans/src/org/netbeans/modules/spring/beans/completion/SpringXMLConfigCompletionItem.java
spring.beans/src/org/netbeans/modules/spring/beans/completion/SpringXMLConfigCompletionProvider.java
versioning.util/src/org/netbeans/modules/versioning/util/CommandReport.form
versioning.util/src/org/netbeans/modules/versioning/util/CommandReport.java
websvc.saas.api/build/classes/org/netbeans/modules/websvc/saas/util/Bundle.properties
websvc.saas.api/src/org/netbeans/modules/websvc/saas/model/package-info.java
xml.tax/src/org/netbeans/modules/xml/tax/beans/beaninfo/Bundle.properties
xml.tax/src/org/netbeans/modules/xml/tax/beans/beaninfo/TreeAttlistDeclAttributeDefBeanInfo.java
xml.tax/src/org/netbeans/modules/xml/tax/beans/beaninfo/TreeAttlistDeclBeanInfo.java
xml.tax/src/org/netbeans/modules/xml/tax/beans/beaninfo/TreeAttributeBeanInfo.java
xml.tax/src/org/netbeans/modules/xml/tax/beans/beaninfo/TreeCDATASectionBeanInfo.java
xml.tax/src/org/netbeans/modules/xml/tax/beans/beaninfo/TreeCharacterReferenceBeanInfo.java
xml.tax/src/org/netbeans/modules/xml/tax/beans/beaninfo/TreeCommentBeanInfo.java
xml.tax/src/org/netbeans/modules/xml/tax/beans/beaninfo/TreeConditionalSectionBeanInfo.java
xml.tax/src/org/netbeans/modules/xml/tax/beans/beaninfo/TreeDTDBeanInfo.java
xml.tax/src/org/netbeans/modules/xml/tax/beans/beaninfo/TreeDocumentBeanInfo.java
xml.tax/src/org/netbeans/modules/xml/tax/beans/beaninfo/TreeDocumentFragmentBeanInfo.java
xml.tax/src/org/netbeans/modules/xml/tax/beans/beaninfo/TreeDocumentTypeBeanInfo.java
xml.tax/src/org/netbeans/modules/xml/tax/beans/beaninfo/TreeElementBeanInfo.java
xml.tax/src/org/netbeans/modules/xml/tax/beans/beaninfo/TreeElementDeclBeanInfo.java
xml.tax/src/org/netbeans/modules/xml/tax/beans/beaninfo/TreeEntityDeclBeanInfo.java
xml.tax/src/org/netbeans/modules/xml/tax/beans/beaninfo/TreeGeneralEntityReferenceBeanInfo.java
xml.tax/src/org/netbeans/modules/xml/tax/beans/beaninfo/TreeNodeFilterBeanInfo.java
xml.tax/src/org/netbeans/modules/xml/tax/beans/beaninfo/TreeNotationDeclBeanInfo.java
xml.tax/src/org/netbeans/modules/xml/tax/beans/beaninfo/TreeParameterEntityReferenceBeanInfo.java
xml.tax/src/org/netbeans/modules/xml/tax/beans/beaninfo/TreeProcessingInstructionBeanInfo.java
xml.tax/src/org/netbeans/modules/xml/tax/beans/beaninfo/TreeTextBeanInfo.java
xml.tax/src/org/netbeans/modules/xml/tax/beans/beaninfo/Util.java
description:
Automated merge with http://hg.netbeans.org/main


pushing to https://padraigob:WCOZzCfY@hg.netbeans.org/main
searching for changes
adding changesets
adding manifests
adding file changes
added 3 changesets with 48 changes to 46 files


By use of this website, you agree to the NetBeans Policies and Terms of Use. © 2014, Oracle Corporation and/or its affiliates. Sponsored by Oracle logo