This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 124320 - Unnecessary calls to HgUtils.isIgnored
Summary: Unnecessary calls to HgUtils.isIgnored
Status: RESOLVED FIXED
Alias: None
Product: versioncontrol
Classification: Unclassified
Component: Mercurial (show other bugs)
Version: 6.x
Hardware: Sun All
: P3 blocker (vote)
Assignee: issues@versioncontrol
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2007-12-20 13:24 UTC by Padraig Obriain
Modified: 2008-01-03 09:36 UTC (History)
0 users

See Also:
Issue Type: DEFECT
Exception Reporter:

Attachments
proposed patch (1.34 KB, patch)
2007-12-20 13:31 UTC, Padraig Obriain 		Details | Diff
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Padraig Obriain 2007-12-20 13:24:25 UTC 
In MercurialAnnotator there are calls to HgUtils.isIgnored in fileCreatedImpl and fileChangedImpl.

Because of issue 124262 Hgutils.isIgnored returns false for files which should be ignored. This suggests that the calls
to HgUtils.isIgnored are unnecessary and can be removed.
Comment 1 Padraig Obriain 2007-12-20 13:31:19 UTC 
Created attachment 54412 [details]
proposed patch
Comment 2 Padraig Obriain 2007-12-20 13:43:21 UTC 
IDE:-------------------------------------------------
IDE: [12/20/07 1:38 PM] Committing "MercurialInterceptor.java" started
Checking in MercurialInterceptor.java;
/shared/data/ccvs/repository/versioncontrol/mercurial/src/org/netbeans/modules/mercurial/MercurialInterceptor.java,v 
<--  MercurialInterceptor.java
new revision: 1.17; previous revision: 1.16
done
IDE: [12/20/07 1:38 PM] Committing "MercurialInterceptor.java" finished
Comment 3 Padraig Obriain 2007-12-20 13:48:23 UTC 
Patch committed