This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.
in ml builds, most of the visualweb/modules/ext localized files for all of the 3 sun supported locales are not being built. webui-jsf-dt_<locale>.jar webui-jsf-suntheme_<locale>.jar dataprovider_<locale>.jar defaulttheme_<locale>.jar defaulttheme-gray_<locale>.jar defaulttheme-green_<locale>.jar designtime_<locale>.jar designtime-base_<locale>.jar errorhandler_<locale>.jar sqlx_<locale>.jar The messages for these are in l10n kit, and a brief check of translatedfiles/src/visualweb showed that the translated messages had been put back. in visualweb1/modules/locale, the files are being built. the only localized in ml build now for visualweb1/modules/ext/locale are webui-jsf-dt_<locale>.jar webui-jsf-suntheme_<locale>.jar which I think are the ones delivered seprately from woodstock. this is p1 since translation teams need all the localized jars to check their own work.
I can try to take a look at it, but I've already left for Christmas break and will be back in work on Jan 2nd.
Thanks for looking at it. the translations for 6.0.1 ml nb for these areas are complete to my knowledge and translation teams need to check their translations for these modules now since the final builds are happening at second week of January. ken.frank@sun.com
Assigning to me
Starting
I'll continue next week. I've identified those missing jarfiles are mostly results of j2se library project builds, which are not running at NB IDE build time. The jarfiles are sort of "external libraries" made of locally available sources and rebuilt&committed only on demand. This approach made it impossible to include them in regular NB Build. I'll update build system of NB module projects, which include these jarfiles, that they have build also localized jarfiles for these "external libraries".
can you see if there are localized jars in other packs/dirs modules/ext dirs, that are not being built also, besides those in visualweb1 ? ken.frank@sun.com
Ken, I have no procedure how to match L10N kit content with ML build content. I have no idea if there are any other missing jarfiles.
Rudolf, I should have been more clear; what was really trying to say was are there any other localized jar files not being built because of the reasons you mention about the visualweb ones, ie "I've identified those missing jarfiles are mostly results of j2se library project builds, which are not running at NB IDE build time. The jarfiles are sort of "external libraries" made of locally available sources and rebuilt&committed only on demand" ken.frank@sun.com
Ken, I don't really know, nothing on my mind. With NB 6 consolidation we merged sources from several teams with similar, but still different approach to source code and dependency organization. This allows for many curious/unique/exceptional states in almost every module. AFAICT there's no easy automated way how to find missing jarfiles. The only way on my mind is to try identify L10N kit content files within full English IDE zipfile and try to determine these files in translatedfiles module and localized jarfile within full ML IDE zipfile. I can imagine technical solution, that it can be done. However it's pretty difficult one-time-not-to-be-used-again task and I would say it could be easier to go through it manually this time.
Created attachment 54759 [details] Patch to update several visualweb modules to build localized versions of their included J2SE libraries
Created attachment 54760 [details] Fix' commit log
Fixed
I don't see the following localized jars of these en ones in new build for visualweb1/modules/ext/locale yet the paths in the en jars do look like path of rave cvs and the bundle files in tnem are in the kit. (using first 0108 visualweb.zip file) I realize these were not listed in this issue originally, but it seems they too are from nb cvs. editor.jar jsfcl.jar webui.jar webui-jsf.jar also, but not sure if the files are in the kit. ---> can you add these to the ml build also ? ken.frank@sun.com
of the localized jars that are now there in modules/ext/locale from nb, I don't see any pt_BR ones - I have asked translation people if they have put them back but am mentioning here in case its that they are not being built as part of this fix. ken.frank@sun.com
Ken, re pt_BR: I found no xlated files in translatedfiles module. re webui-jsf.jar: localized jarfiles should be provided from Woodstock team, if required. Authoritative data source is https://woodstock.dev.java.net/files/documents/6231/78991/Woodstock.4.1.1-l10n-200712030852.jar . If we should include webui-jsf_${locale}.jar file, I don't know where exactly to put them within NB IDE files layout. It could be modules/ext as well as modules/ext/locale. It depends how this 3rd party binary and it's 3rd party localizations all work. re editors.jar, jsfcl.jar and webui.jar: I've prepared a patch and now doing full build test before checkin. -R
Created attachment 54808 [details] Patch for webui, editors and jsfcl libraries
Created attachment 54809 [details] Commit log for second part
Ken, Re: editors.jar, jsfcl.jar and webui.jar test build has been successful, change has been integrated. Re: webui-jsf_${locale}.jar file - I'll discuss with Woodstock team how to proceed, resp. where to put the files.
webui-jsf.jar localized versions - I asked vwp manager for info if the localized versions of it were delivered to us for nb6. But I see that those localized files are in the jar you mentioned so I think they also would go into modules/ext/locale, but its good to confirm with woodstock in case they need to be elsewhere. ken.frank@sun.com
will the woodstock delivered webui-jsf_<locale>.jars be put into ml build now, based on info gotten from ws team ? ken.frank@sun.com
I have added the woodstock localized jars to release6.0 branch. Here are the links to the commits http://visualweb.netbeans.org/source/browse/visualweb/woodstock/components/external/woodstock-components-4.1.1.zip?rev=1.1.4.2&content-type=text/vnd.viewcvs-markup http://visualweb.netbeans.org/source/browse/visualweb/woodstock/components/nbproject/project.properties?r1=1.7.4.1&r2=1.7.4.2
From this point it looks like it has been fixed. Please verify the same.
reopening since the webui-jsf_<locale>.jar is not in latest/first 0111 build (not in visualweb-ml.zip netbeans-6.0.1-200801110000-ml-visualweb.zip please advise if that build is too soon for the fix to have happened. ken.frank@sun.com
I confirm it's missing in that build. I'll check what happened. BTW: I don't think webui-jsf_${locale}.jar files should go to modules/ext/locale directory. These localization jarfiles are not handled by NetBeans' bundle localization/branding system. These are runtime localizations and are handled by NB-independent localization resource loaders from webui-jsf.jar runtime library. These localizations are in use when Web Application is running within J2EE web container, not in GUI of NB IDE. The runtime library webui-jsf.jar AFAICT expects these localization jarfiles in the same directory as is the webui-jsf.jar library itself. Correct me if I'm wrong.
I've identified the root cause, which actually related to the 'locale' subdirectory. I've got potential fix for visualweb/woodstock/components/nbproject/project.properties. I need a test case where I can check the localization is in the right place. Petr or Marian, please assign me QE engineer familiar with woodstock components, especially with functionality in webui-jsf.jar library (user/developer level). Thanks.
I've integrated a fix, which makes those jarfiles available for use in the IDE. There stays another question how developer can use and deploy these localizations with her/his application. There are at least two options how to resolve: #1 modify visualweb/project/jsf/libraries/woodstock-components.xml and explicitly refer those webui-jsf_${locale}.jar localization jarfiles as resources for Visual Web JSF projects. #2 document a process steps (workaround) where user/developer has to go to library management and use "Add a Jar" function to add necessary visualweb1/modules/ext/locale/webui-jsf_${locale}.jar localization jarfiles to "Web UI Components" library. Note: the same may (to certain extent) apply to suntheme localization(s).
as to the fix, does it mean those loclaized jars will now be in visualweb1/modules/ext/locale in the next build ? as regards how to use these kind of jars or their location, were these delivered jars in vwp in the past that was localized also, like for 551 ? or if so, is the problem that layout and process of things in nb6 now is different so that things that worked in 551 might not in 6.0 ? ken.frank@sun.com
> as to the fix, does it mean those loclaized jars will now be in visualweb1/modules/ext/locale > in the next build ? Yes. I'm sorry I was wrong regarding jarfiles location. They really belong to locales subdirectory, JSF project type is trying to look for them in locale subdirectory. > as regards how to use these kind of jars or their location, were these delivered jars > in vwp in the past that was localized also, like for 551 ? I don't really know. I've absolutely no knowledge about visualweb and woodstock components prior NB 6.0. > or if so, is the problem that layout and process of things in nb6 now is different so that > things that worked in 551 might not in 6.0 ? This could be part of the problem. Consolidation of visualweb into netbeans 6 was (afaik) pretty difficult, so there is great potential that "things that worked in 551 might not in 6.0". I repeat myself, I've got no knowledge about visualweb 551 so I cannot compare it with 60.
when using localized nb, and I have webui-jsf_<locale>.jar there in modules/ext/locale, it is added to the libraries section of the vwp libraries tab of a vwp project, along with localized versions of jsfcl, dataprovider, sqlx, webui-jsf-suntheme. (which also live in modules/ext/locale ken.frank@sun.com