This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 123593 - Redundent forceStatusRefresh() call in Revert Modifications
Summary: Redundent forceStatusRefresh() call in Revert Modifications
Status: RESOLVED FIXED
Alias: None
Product: versioncontrol
Classification: Unclassified
Component: Mercurial (show other bugs)
Version: 6.x
Hardware: All All
: P3 blocker (vote)
Assignee: issues@versioncontrol
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2007-12-06 20:21 UTC by John Rice
Modified: 2008-01-03 09:34 UTC (History)
0 users

See Also:
Issue Type: DEFECT
Exception Reporter:


Attachments
Proposed patch (1.03 KB, text/plain)
2007-12-06 20:22 UTC, John Rice
Details

Note You need to log in before you can comment on or make changes to this bug.
Description John Rice 2007-12-06 20:21:11 UTC
We are making a call to forceStatusRefresh() which is no longer required as we immediately call
org.openide.filesystems.FileSystem.refresh() which in turns triggers the MercurialInterceptor.fileChangedImpl() that
results in a call to forceStatusRefresh().

This should be removed, but was deemed to high a risk for release60 refresh, as we'd need to test all of the possible
change conditions on Revert to be sure it's safe to remove.
Comment 1 John Rice 2007-12-06 20:22:42 UTC
Created attachment 53964 [details]
Proposed patch
Comment 2 John Rice 2007-12-21 11:45:51 UTC
IDE:-------------------------------------------------
IDE: [21/12/07 11:45] Committing started
Checking in RevertModificationsAction.java;
/shared/data/ccvs/repository/versioncontrol/mercurial/src/org/netbeans/modules/mercurial/ui/update/RevertModificationsAction.java,v
 <--  RevertModificationsAction.java
new revision: 1.8; previous revision: 1.7
done
IDE: [21/12/07 11:45] Committing finished