This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 122934 - I18N - Diagram Name are default Chinese characters when create a new diagram
Summary: I18N - Diagram Name are default Chinese characters when create a new diagram
Status: VERIFIED FIXED
Alias: None
Product: uml
Classification: Unclassified
Component: General (show other bugs)
Version: 6.x
Hardware: Sun All
: P2 blocker (vote)
Assignee: Viktor Lapitski
URL:
Keywords: I18N
Depends on:
Blocks:
 
Reported: 2007-11-28 08:28 UTC by Will Zhang
Modified: 2008-03-28 08:08 UTC (History)
1 user (show)

See Also:
Issue Type: DEFECT
Exception Reporter:


Attachments
screenshot (49.55 KB, text/plain)
2007-11-28 08:31 UTC, Will Zhang
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Will Zhang 2007-11-28 08:28:31 UTC
build: nb6 ml 2007-11-26_17-08-21
#1. launch nb6 ml ide in zh
#2. create uml project
#3. create diagram
Diagram Name is default Chinese characters when create a new diagram
I will attach the screenshot.

In the create new diagram dialog, dialog type and dialog name use the same msg string:
uml/core/src/org/netbeans/modules/uml/ui/support/drawingproperties/Bundle.properties:IDS_CLASS_DIAGRAM
dialog type should be localized and dialog name should be NOI18N.
Please add another group msgs for dialog name

thank you,
Will
Comment 1 Will Zhang 2007-11-28 08:31:06 UTC
Created attachment 53583 [details]
screenshot
Comment 2 Ken Frank 2007-11-28 15:55:14 UTC
since the name of diagram that is seeded into the diagram name textfield is viewed as a suggestion to user
and that user can change it to whatever they want, is it ok for it to be this
way in that case ?

(that is, I think the behavior seen is same for english; uml team can comment more on if this
is accurate assumption)

ken.frank@sun.com

Comment 3 Craig Conover 2007-11-28 17:27:00 UTC
I'm not certain I understand the issue. Is the problem that the suggested diagram name is translated or not translated,
or something entirely different? The attached image is displaying as garbage so not sure what I should be seeing.

The intention of the suggested diagram name is it should be translated into the local language.
What is true for IDS_CLASS_DIAGRAM is also the same for the others like it: IDS_COLLABORATION_DIAGRAM,
IDS_COMPONENT_DIAGRAM, IDS_DEPLOYMENT_DIAGRAM, etc.
Comment 4 Yang Su 2007-11-28 17:49:36 UTC
Ken is right. The diagram type name is used to form a default suggested name for the new diagram, the "type + number"
naming scheme is a change from uniform "New Diagram" in previous releases to better differentiate instances, similar to
creating a new project, e.g "JavaApplication1", "UMLProject2".
Comment 5 Will Zhang 2007-11-29 03:10:16 UTC
Hi,

   Yes, in nb551 we used "New Diagram" and in nb60 we change it to "type + number" naming scheme.
   Basically l10n team didn't localize the project or component name when creating that project or component to avoid 
user to use default ml project or component name, since there might be some issues when user use ml project or 
component name. 
   You can see in ja/zh nb, when you create a project or component, e.g. "JavaApplication1", "UMLProject2", "New 
Diagram", the project or component name is still english. 
   So I filed this issue, i'd like to put the "diagram name" back to english and keep "diagram type" in chinese, but i 
find "diagram name" and "diagram type" use the same message string in property file, e.g class diagram,
uml/core/src/org/netbeans/modules/uml/ui/support/drawingproperties/Bundle.properties
IDS_CLASS_DIAGRAM=Class Diagram
   We need another message string, looks like
XXX_CLASS_DIAGRAM_XXX=Class Diagram
   This new string is NI18N and used to display "diagram name" and IDS_CLASS_DIAGRAM is localized to display diagram 
type.
   The other 7 diagrams have the same issue. so we need 8 extra strings for "diagram name", even if the string content 
are the same.
   Hope my explanation is clear. 

thank you,
Will
Comment 6 Ken Frank 2007-11-29 03:49:35 UTC
Will,

This is a request for next uml release, not nb6 ?  since nb6 is now fcs, and unless this would
be viewed as a showstopper, its not fixable for ml unless that would be allowed;  if ml does happen for 6.0.1 instead of
for 6.0 (still being discussed) perhaps it could be fixed but then it would need to be showstopper kind of situation.

but lets see what uml team says on this in any case.

ken.frank@sun.com
Comment 7 Will Zhang 2007-11-29 05:13:09 UTC
Thank you for your comments, Ken.
I agree with you, we may not fix it in nb6, but we need to consider it and fix in next nb release.

-W
Comment 8 Peter Lam 2007-11-29 16:52:41 UTC
I assume this issue is not specific to just the Chinese locale.
I believe this is also not a stopper for NB 6 in my opinion, but definitely a good candidate for next release.
Comment 9 Will Zhang 2007-11-30 06:28:55 UTC
Hi petersl,

    Totally agree. 
   Not only Chinese locale but alos other language have the same issue.
   This issue is not showstopper for nb6.
   Let's consider it now and see if we can fix it in nb next release.

thank you,
Will
Comment 10 Viktor Lapitski 2008-03-11 02:15:25 UTC
Fixed.

changeset:   72472:07331e29814d
tag:         tip
user:        lvv@netbeans.org
date:        Mon Mar 10 17:07:23 2008 -0800
summary:     Fix for 122934 I18N - Diagram Name are default Chinese characters w
hen create a new diagram

and

changeset:   71049:7d9175046a5e
tag:         tip
user:        lvv@netbeans.org
date:        Mon Mar 10 17:11:37 2008 -0800
summary:     Fix for 122934 I18N - Diagram Name are default Chinese characters w
hen create a new diagram

Comment 11 Will Zhang 2008-03-28 08:08:19 UTC
veryfied and fixed in Build 200803251204

thank you very much for fixing it in NB6.1
-will