This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 122864 - Added new NameKind in ClassIndex for code completion
Summary: Added new NameKind in ClassIndex for code completion
Status: VERIFIED FIXED
Alias: None
Product: java
Classification: Unclassified
Component: Source (show other bugs)
Version: 6.x
Hardware: All All
: P2 blocker (vote)
Assignee: Tomas Zezula
URL:
Keywords: API, API_REVIEW_FAST
Depends on:
Blocks:
 
Reported: 2007-11-27 15:57 UTC by Tomas Zezula
Modified: 2007-12-07 16:37 UTC (History)
1 user (show)

See Also:
Issue Type: DEFECT
Exception Reporter:


Attachments
Diff (3.14 KB, text/plain)
2007-11-27 15:57 UTC, Tomas Zezula
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Tomas Zezula 2007-11-27 15:57:14 UTC
New ClassIndex.NameKind added for code completion. This kind represents special "user friendly" type of camel case.
Comment 1 Tomas Zezula 2007-11-27 15:57:59 UTC
Created attachment 53556 [details]
Diff
Comment 2 Dusan Balek 2007-11-27 16:01:12 UTC
Proposed patch looks OK.
Comment 3 Jan Lahoda 2007-11-27 16:02:24 UTC
Seems fine to me.
Comment 4 Tomas Zezula 2007-11-27 16:10:36 UTC
Checking in src/org/netbeans/api/java/source/ClassIndex.java;
/cvs/java/source/src/org/netbeans/api/java/source/ClassIndex.java,v  <--  ClassIndex.java
new revision: 1.13; previous revision: 1.12
done
Checking in src/org/netbeans/modules/java/source/usages/LuceneIndex.java;
/cvs/java/source/src/org/netbeans/modules/java/source/usages/LuceneIndex.java,v  <--  LuceneIndex.java
new revision: 1.29; previous revision: 1.28
done
Comment 5 Jaroslav Tulach 2007-11-27 16:20:35 UTC
Y01 No test, no @since tag, no apichanges. 

Btw. why you integrated so early after announcing the review? Is there a reason to be in hurry?
Comment 6 Tomas Zezula 2007-11-27 16:44:35 UTC
Y01: Added since and apichanges. No test - well I believe there are lots of tests testing adding of 
enum entry into enums (about the API test). The test of implementation - currently implemented as merge
of CAMEL_CASE and CIPrefix both already covered and it will be rewritten to improve the performance.
API review very fast - it's needed to fix another issue. Anyway the only persons who know the ClassIndex
already reviewed it, there is no need to wait.

Checking in apichanges.xml;
/cvs/java/source/apichanges.xml,v  <--  apichanges.xml
new revision: 1.19; previous revision: 1.18
done
Checking in nbproject/project.properties;
/cvs/java/source/nbproject/project.properties,v  <--  project.properties
new revision: 1.41; previous revision: 1.40
done
Checking in src/org/netbeans/api/java/source/ClassIndex.java;
/cvs/java/source/src/org/netbeans/api/java/source/ClassIndex.java,v  <--  ClassIndex.java
new revision: 1.14; previous revision: 1.13
done
Comment 7 Jaroslav Tulach 2007-11-28 12:06:15 UTC
.