This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 121702 - typo in enterprise/wsdlextensions
Summary: typo in enterprise/wsdlextensions
Status: RESOLVED WONTFIX
Alias: None
Product: xml
Classification: Unclassified
Component: WSDL Model (show other bugs)
Version: 6.x
Hardware: Sun All
: P3 blocker (vote)
Assignee: Sherry Weng
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2007-11-12 09:00 UTC by Will Zhang
Modified: 2016-07-07 09:56 UTC (History)
2 users (show)

See Also:
Issue Type: DEFECT
Exception Reporter:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Will Zhang 2007-11-12 09:00:40 UTC
File:
enterprise/wsdlextensions/jms/src/org/netbeans/modules/wsdlextensions/jms/validator/Bundle.properties
Msg:
JMSMessage.TEXT_MESSAGE_CANNOT_HAVE_MAPMESSAGE_ELEM=Binding operation ''{0}'' has an invalid JMS {1} binding 
(jms:message) : the {1} binding ''{2}'' defines messageType as ''TextMessage'' but it contains a jms:mapmessage child 
element which is only valid for 'MapMessage' type

Please confirm if 'MapMessage' should be changed to ''MapMessage''

JMSMessage.MAP_MESSAGE_CANNOT_HAVE_TEXTPART_ATTR=Binding operation ''{0}'' has an invalid JMS {1} binding 
(jms:message) : the {1} binding ''{2}'' defines messageType as ''MapMessage'' but it defines the textPart attribute 
which is only valid for 'TextMessage' type

Please confirm if 'TextMessage' should be changed to ''TextMessage''
Thank you.
Comment 1 Sherry Weng 2007-11-12 22:35:44 UTC
I don't think we need 2 single quotes around the word TextMessage and MapMessage. 
So I would change the entries to:
JMSMessage.TEXT_MESSAGE_CANNOT_HAVE_MAPMESSAGE_ELEM=Binding operation ''{0}'' has an invalid JMS {1} binding 
(jms:message) : the {1} binding ''{2}'' defines messageType as 'TextMessage' but it contains a jms:mapmessage child 
element which is only valid for 'MapMessage' type

JMSMessage.MAP_MESSAGE_CANNOT_HAVE_TEXTPART_ATTR=Binding operation ''{0}'' has an invalid JMS {1} binding 
(jms:message) : the {1} binding ''{2}'' defines messageType as 'MapMessage' but it defines the textPart attribute 
which is only valid for 'TextMessage' type

CC'ed James here for his input.


Comment 2 Shivanand Kini 2007-11-12 22:41:55 UTC
Upon further investigation. I was able to see the message in the editor.
For eg. Error: Binding operation 'newWSDL4Operation' has an invalid JMS input binding (jms:message) : the input binding
'input1' defines messageType as 'TextMessage' but it contains a jms:mapmessage child element which is only valid for
MapMessage type

I think two quotes are needed for MapMessage too. James, confirm this though.

wzhang, if you think this needs to go in for 6.0 release, then the bug needs to be a P1 priority.

otherwise, James, fix in trunk.


Comment 3 Will Zhang 2007-11-13 02:25:57 UTC
It's not showstopper, Fixing it in trunk is ok.
Thank you.
Comment 4 Rebecca Liu 2007-11-13 02:28:45 UTC
Our consideration is that if one single quote ' appears with {1} in a message, ' will influence {1}. But from your
investigation, it seems that it doesn't influence {1} changes to "input". So I think it doesn't matter if you use one
single quote ' or two single quote ''.

But please advise when one single quote should be used and when two single quotes should be used, especially when such
expression {1} appears.

Rebecca
Comment 5 Ken Frank 2007-11-13 02:52:58 UTC
I think its a java and nb requirement to have 2 single quotes for msgs
that use MessageFormat class as does those
that use {} args.

The requirements, as I understand it, is that a single quote needs to
be changed to 2 single quotes for any part of a msg that gets
formatted with java.text.MessageFormat.  But one should not do this
to msgs that are not formatted with this class. 

But its not completely clear to me if the non {} parts need the double quotes also
or do they need them just so they will show as single quoted in ui,
which would be needed even if not in a value that has {} in it.

I think the answer could be in past translated nb files that have lines with both situations.

Also in some message files (not of this module) I see sometimes double quotes used
for the {} vs 2 single quotes, which are also seen.
\"{0}\".
"{0}"

am assuming both are ok ?

ken.frank@sun.com
Comment 6 Martin Balin 2016-07-07 09:56:44 UTC
This old bug may not be relevant anymore. If you can still reproduce it in 8.2 development builds please reopen this issue.

Thanks for your cooperation,
NetBeans IDE 8.2 Release Boss