This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.
It is required that if UML is installed, its library Tom Sawyer has a copyright notice visible in the Help/About dialog box. This is the case *only if* it is installed, for other cases the About box must not include the notice. In 5.5.x this was already resolved, but the code was available only on release55 and release551 branches. Main trunk did not include the code because at the time of 5.5 it was agreed that for 6.0 (1) it will not be the case anymore as UML will be rewritten to use Visual Library and (2) About box will be enhanced to provide a general API to plug in any additional info there. This did not happen. We have to reintroduce the friend API change into the 6.0 about box to allow UML to add the notice the same way it did in 5.5.x.
Created attachment 52726 [details] Diff of the change for review
Created attachment 52729 [details] How About will look after the fix when the extra copyright is not present (WinXP)
Created attachment 52731 [details] How About will look after the fix when the extra copyright is not present (GTKlaf)
Created attachment 52732 [details] How About will look after the fix when the extra copyright is there (WinXP)
Created attachment 52734 [details] How About will look after the fix when the extra copyright is there (GTKlaf)
code review: OK, simple and working, proven already in 5.5. But I'm missing API description in javadoc in api changes - however I'm not sure if we want to document this or not.
Checking in Bundle.properties; /shared/data/ccvs/repository/core/src/org/netbeans/core/ui/Bundle.properties,v <-- Bundle.properties new revision: 1.90.2.1; previous revision: 1.90 done Checking in ProductInformationPanel.java; /shared/data/ccvs/repository/core/src/org/netbeans/core/ui/ProductInformationPanel.java,v <-- ProductInformationPanel.java new revision: 1.44.2.1; previous revision: 1.44 done Checking in ProductInformationPanel.form; /shared/data/ccvs/repository/core/src/org/netbeans/core/ui/ProductInformationPanel.form,v <-- ProductInformationPanel.form new revision: 1.23.2.1; previous revision: 1.23 done
A bit of after-notes... To do it properly from UI point of view, the about box would eliminate the empty space dedicated for the Tom Sawyer notice if UML isn't installed. Currently on Win XP the big empty gap looks quite odd. On GTK it's better due to the line border around the license notice. I approved it for 6.0 and it's okay to leave it as it is. It should be fixed after 6.0.
Verified in: Product Version: NetBeans IDE 6.0 RC1 (Build 200711131200) Java: 1.6.0_03; Java HotSpot(TM) Client VM 1.6.0_03-b05 System: Linux version 2.6.22-14-generic running on i386; UTF-8; en_US (nb) Userdir: /home/petr/.netbeans/6.0rc1