This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 121248 - Lexer module cannot be built incrementally under JDK 5
Summary: Lexer module cannot be built incrementally under JDK 5
Status: CLOSED FIXED
Alias: None
Product: editor
Classification: Unclassified
Component: Lexer (show other bugs)
Version: 6.x
Hardware: All All
: P1 blocker (vote)
Assignee: issues@editor
URL:
Keywords: JDK_SPECIFIC, REGRESSION
Depends on:
Blocks:
 
Reported: 2007-11-06 07:31 UTC by Jesse Glick
Modified: 2011-06-09 09:56 UTC (History)
0 users

See Also:
Issue Type: DEFECT
Exception Reporter:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jesse Glick 2007-11-06 07:31:02 UTC 
ant -f lexer/build.xml
ant -f openide/util/build.xml clean netbeans
ant -f lexer/build.xml

Deleted 8 out of date files in 0 seconds
Compiling 47 source files to /space/src/nb_all/lexer/build/classes
/space/src/nb_all/lexer/src/org/netbeans/lib/lexer/TokenHierarchyOperation.java:770:
<T,ET>embeddedTokenList(org.netbeans.lib.lexer.TokenList<T>,int,org.netbeans.api.lexer.Language<ET>) in
org.netbeans.lib.lexer.EmbeddingContainer cannot be applied to (org.netbeans.lib.lexer.TokenList<capture of
?>,int,org.netbeans.api.lexer.Language<capture of ?>)
            EmbeddedTokenList<?> etl = EmbeddingContainer.embeddedTokenList(tokenList, indexes[i],
languagePath.language(i));
                                                         ^
1 error

BUILD FAILED

Looks like a javac bug - does not occur when using JDK 6 for compilation. Breaking trunk incremental builds frequently.
Comment 1 Jesse Glick 2007-11-06 07:32:55 UTC 
Caused, I guess, by mmetelka's recent changes in the Lexer API.
Comment 2 Miloslav Metelka 2007-11-06 08:19:19 UTC 
Apologies.
Checking in TokenHierarchyOperation.java;
/cvs/lexer/src/org/netbeans/lib/lexer/TokenHierarchyOperation.java,v  <--  TokenHierarchyOperation.java
new revision: 1.30; previous revision: 1.29
Comment 3 Jesse Glick 2007-11-06 09:43:23 UTC 
Thanks, workaround looks reasonable. Not sure whether this should be merged to release60. Unlikely to affect official
builds, which should be clean builds, but could possibly affect developers working on that branch in the future.
Comment 4 Miloslav Metelka 2007-11-06 10:21:53 UTC 
A simpler fix (just a variable for Language<?> is enough):
Checking in TokenHierarchyOperation.java;
/cvs/lexer/src/org/netbeans/lib/lexer/TokenHierarchyOperation.java,v  <--  TokenHierarchyOperation.java
new revision: 1.31; previous revision: 1.30

I will integrate to release60 too.
Comment 5 Miloslav Metelka 2007-11-12 09:11:56 UTC 
I would like to integrate the latest fix into release60 to prevent possible build failures. There is NO change in
functionality so it should not cause any regression.
Comment 7 Jesse Glick 2007-11-12 21:00:14 UTC 
Fix looks safe to me.
Comment 8 Miloslav Metelka 2007-11-16 11:06:59 UTC 
Integrated in release60:
Checking in src/org/netbeans/lib/lexer/TokenHierarchyOperation.java;
/cvs/lexer/src/org/netbeans/lib/lexer/TokenHierarchyOperation.java,v  <--  TokenHierarchyOperation.java
new revision: 1.29.2.1; previous revision: 1.29
Comment 9 Marian Mirilovic 2011-06-09 09:56:43 UTC 
v/c