This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 120787 - I18N - Please confirm NO I18N ENTIRE FILE
Summary: I18N - Please confirm NO I18N ENTIRE FILE
Status: CLOSED FIXED
Alias: None
Product: soa
Classification: Unclassified
Component: SQL Project (show other bugs)
Version: 6.x
Hardware: Sun All
: P2 blocker (vote)
Assignee: Venkat Srinivasan
URL:
Keywords: I18N
Depends on:
Blocks:
 
Reported: 2007-11-01 12:08 UTC by Will Zhang
Modified: 2007-11-06 08:14 UTC (History)
1 user (show)

See Also:
Issue Type: DEFECT
Exception Reporter:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Will Zhang 2007-11-01 12:08:17 UTC
File:
enterprise/sql/jdbcwizard/src/org/netbeans/modules/jdbcwizard/builder/Bundle.properties
Comments in the file:
# ------------------------------
# ---- NO I18N ENTIRE FILE! ----
# ------------------------------
Please confirm if l10n team don't need to localize this property files.
Comment 1 Ken Frank 2007-11-01 16:10:30 UTC
to dev team -- why is this file marked as not to translate ?
Is this a new change ? I don't see it in the product version
of this bundle file, using 1030 build.


are there any other such files in your areas ?

and why cannot these msgs be translated - if its to work around some issue
that does not seem the way to solve it.

am raising this to p2.

ken.frank@sun.com
Comment 2 Narayana Rallabandi 2007-11-02 10:55:56 UTC
Hi,

When I looked at the CVS History, from 1.1.2.1 1/17/2007 the file is having the same comments. I 'm looking into the
current issues, since a week's time (in fire fighting mode) and do not have any idea why it is so. I also do not see any
point in making the whole file no I18N. 

But there can be some words which make sense to JDBC API in some of the rows in the file which might nor be pars-able.

ERROR_NULL_RS = Must supply non-null ResultSet instance for parameter rs. # Here ResultSet 
ERROR_VALID_RS = Must supply valid ResultSet instance for parameter rs # Here also ResultSet
ERROR_VALID_RULE = Must supply valid value for newRule # this can be modified as New Rule
ERROR_INDEX_TYPE =Must supply valid index type value; {0} is out of range. 
ERROR_PARAMETER_NAME = Must supply non-empty String for parameter colName. # I m going to change this to Column Name 
ERROR_KEY = newList does not contain KeyColumn objects # KeyColumn is a JDBC word not pars-able.
ERROR_FK_KEY = newList does not contain ForeignKeyColumn objects! # ForeignKeyColumn is a JDBC word not pars-able.

I am removing the others for I18N and resolving this issue as Fixed. Let me know your thoughts.

Thanks,
Narayanaa
Comment 3 Will Zhang 2007-11-02 13:36:02 UTC
Thank you for fixing, Narayanaa.
As a normal way, if a msg is NOI18N, we add "#NOI18N" comments up one line of that msg, e.g. 
ERROR_NULL_RS is noi18n msg, it will be add the comments as below:
#NOI18N
ERROR_NULL_RS = Must supply non-null ResultSet instance for parameter rs.

As you know, we are using World Server to process the translation, unified comments format will make l10n team and 
translation vendor's work to be easy. 
Could you please move "#NOI18N" comments as above? 
Thank you for understanding.
- Will

Comment 4 Ken Frank 2007-11-02 15:58:35 UTC
We need to know which entries have been removed, so when we see them in ide as not translated,
we will know they are meant not to be translated.

ken.frank@sun.com
Comment 5 Ken Frank 2007-11-02 16:04:55 UTC
also, yes, please look into why the files in product are different than
in l10n kit; this is a problem and we should reopen issue until
that is solved since its not clear that translation people will be translating
the correct file.

and since this shows in this area, please check all the translatable files
in your l10n kit to make sure also -

kits are at
http://deadlock.netbeans.org/hudson/job/l10nkit/

get the 2nd file in the list, gunzip, then untar, then untar your kit tar files.

ken.frank@sun.com
Comment 6 Ken Frank 2007-11-02 16:17:20 UTC
am reopening as per last comment; its critical that kit files be same as product file.

ken.frank@sun.com
Comment 7 Ken Frank 2007-11-05 03:28:42 UTC
to developer, please confirm in this issue that current/latest kit files are
now exact same as bundle files in the current/latest product installed modules
for this area; then pleas close as verified.

ken.frank@sun.com
Comment 8 Narayana Rallabandi 2007-11-05 19:04:33 UTC
Fixed the code for conformance. The build later than that of http://deadlock.netbeans.org/hudson/job/trunk/4315 on 5th
November should contain the fix.

#NOI18N needs to be on the top of the line and not after the line which can not be translated for enabling World Server
to process the translation and also unified comments format will make l10n team and translation vendor's work to be easy.

Also verified for current/latest kit files are now exact same as bundle files in the current/latest product installed
modules for this area; Checked on 11/04 bundle. With the current fix we need to check the bundle on the 11/05 tar.gz.
Since they are now in sync., I am closing the issue.
Comment 9 Will Zhang 2007-11-06 08:14:02 UTC
verified and fixed. 
Thank you.