071023. Had added JavaHelp to a standalone module; then selected the package containing the JavaHelp in the Projects tab
and deleted it.
Created attachment 51520 [details]
Milan is responsible for PackageView
I assume it's not reproducible.
I was not able to reproduce it just now, probably a race condition.
I think it should be handled in SearchInfoFactory by checking if fo.isValid() before creating SimpleSearchInfo. Please
Looks really like a race condition. PackageViewChildren.createNodes checks if the folder is valid, but when PackageNode
later calls SearchInfoFactory, the folder is not valid anymore - so it had to be deleted in the meantime. But
SearchInfoFactory can't do anything reasonable if given a folder that is not valid - it can't return null, throwing
exception does not solve anything... To me it looks like PackageViewChildren should perhaps lock the folder to make sure
it is not deleted during creating PackageNode (or at least when calling SearchInfoFactory).
I do not think the folder can be locked in order not to be deleted/become invalid. SearchInfoFactory could return no-op
SearchInfo for invalid folders.
Reassigning back, see jlahoda's comment.
Correction - the link to the changeset is http://hg.netbeans.org/main/dev/bc10056e03e6
Correction - the link to the changeset is http://hg.netbeans.org/main/rev/bc10056e03e6