This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 117422 - Unneeded refreshing of node in TreeView
Summary: Unneeded refreshing of node in TreeView
Status: NEW
Alias: None
Product: versioncontrol
Classification: Unclassified
Component: CVS (show other bugs)
Version: 6.x
Hardware: All All
: P3 blocker (vote)
Assignee: issues@versioncontrol
URL:
Keywords:
: 118268 (view as bug list)
Depends on:
Blocks: 115358
  Show dependency tree
 
Reported: 2007-10-02 11:27 UTC by mslama
Modified: 2010-07-30 09:56 UTC (History)
1 user (show)

See Also:
Issue Type: DEFECT
Exception Reporter:

Attachments
Complete call stack (7.06 KB, text/plain)
2007-10-02 13:41 UTC, mslama 		Details
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description mslama 2007-10-02 11:27:37 UTC 
Steps to reproduce:
1.Start IDE.
2.Open Favorites view
3.Add some NB CVS module (checked out previously) eg. java
4.Start Delete action on java folder. Now it takes a few minutes to delete. All nodes in Favorites view are collapsed
and view is refreshed often during delete action. It should not happen as there is nothing to change in view - only
underlying deep nodes are deleted not root nodes.

Not sure if it should go to explorer or nodes.
Comment 1 mslama 2007-10-02 13:40:00 UTC 
There is too many VisibilityQuery ChangeEvents when deleting folder structure. According to Jarda surrounding line:


    private static void refreshVisibility() {
        if (instance != null) {
            instance.refreshVisibilityTask.schedule(100);
        }
   }

by AtomicAction should solve this problem as events would be fired after whole delete operation would be finished.
Comment 2 mslama 2007-10-02 13:41:21 UTC 
Created attachment 49980 [details]
Complete call stack
Comment 3 Maros Sandor 2007-10-02 14:02:05 UTC 
What is wrong with the stacktrace? It does not imply that the refresh is actually run - it is only being scheduled. I
can increase scheduling delay to 1000 or so, we'll see if that helps. Regarding AtomicAction; this would have to be done
several layers above CVS and synchronous callbacks involved here such as doDelete() would not be affected anyway.
Comment 4 mslama 2007-10-02 14:39:20 UTC 
Just try steps described above and you will see what is wrong. Too many events are comming to Favorites from
VisibilityQuery during delete.
Comment 5 mslama 2007-10-09 17:53:51 UTC 
*** Issue 118268 has been marked as a duplicate of this issue. ***