This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 11463 - CVS Commit prompting for the message multiple times.
Summary: CVS Commit prompting for the message multiple times.
Status: RESOLVED FIXED
Alias: None
Product: obsolete
Classification: Unclassified
Component: vcsgeneric (show other bugs)
Version: 3.x
Hardware: PC Windows 3.1/NT
: P4 blocker (vote)
Assignee: Martin Entlicher
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2001-04-17 05:31 UTC by Robert Watkins
Modified: 2005-05-02 11:16 UTC (History)
0 users

See Also:
Issue Type: ENHANCEMENT
Exception Reporter:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Robert Watkins 2001-04-17 05:31:35 UTC
Scenario: I have several changes to commit, spread over multiple packages. When 
I do the CVS commit on the parent package, I get prompted to enter my commit 
message multiple times. This is because the CVS command gets called once per 
directory, and only on the files in that directory. Each time it gets called, 
the message needs to be entered again.

The problem here is that some CVS commands (such as 'add') need to be invoked 
in the directory where the file exists. A change was made for this in build #20 
or #21 (see issue #11066). The remaining recursive commands (such as commit, 
update, etc) can be invoked on the root directory.

Also see issue #11400 (related, but not a duplicate).
Comment 1 Milos Kleint 2001-04-17 15:15:39 UTC
reassigning
Comment 2 Martin Entlicher 2001-04-17 16:18:26 UTC
This is consistent with cvs behavior. When you do a commit from the command
line, it probably behaves the exactly same way. The reason is, that you may have
different templates for different directories. Then commit has to show you the
changed files with the associated template.

If you agree, I would change this to an enhancement and lower its priority,
because:
1) this is definitely not going to be fixed to 3.2,
2) the behavior is consistent with command-line cvs

As a fix we should probably add a checkbox to the commit dialog about whether
this command should be applied to the whole folder.
(Currently the commit is applied only to files printed in the text area of the
commit dialog.)
Comment 3 Robert Watkins 2001-04-17 23:37:50 UTC
It's not consistent with command-line CVS.

If I have three directories like this:
dir1 <-- sub1
      \- sub2

and both sub1 and sub2 contain files needing commit, from the commandline, in 
dir1, I can do a cvs commit, and only have to enter the message once.

In earlier builds of netbeans (3.2 build #17 and earlier, at least), doing a 
CVS commit on root was the same. This was because CVS was invoked in the dir1 
directory.

In more recent builds, the behaviour was changed (see issue #11066) so that CVS 
is invoked in each directory. This results in CVS being called twice; once in 
sub1 and once in sub2. For non-recursive CVS commands (such as add), this is 
correct. For recursive commands (such as commit), this is not required.
Comment 4 Martin Entlicher 2001-04-26 11:36:13 UTC
Can you please enter your OS ? I'm afraid that we were not able to reproduce it
either on Win NT nor on Solaris.
Thanks.
Comment 5 Robert Watkins 2001-04-26 23:45:21 UTC
Happens on NT 4, sp6, with 3.2 RC2 build 29.
Comment 6 Jan Chalupa 2001-05-06 15:33:42 UTC
Target milestone -> 3.3
Comment 7 brenthale 2004-04-01 18:06:00 UTC
This seems to have gotten worse in v3.6.  It seems that before this 
things were working cleaner.  I think that the thing that has 
changed recently is that the "Previous" option doesn't get enabled 
for the subsequent dialogs and that it use to.  

The multiple dialogs may have always come up in the past, but the 
Previous always worked and I was able to retrieve the previous 
comment.  Now I'm in the habit of Copying my comments to the 
clipboard so that I can past them to the next commit window.

Something subtle changed between v3.5 and v3.6 RC1.
Comment 8 Martin Entlicher 2004-04-02 08:08:26 UTC
There's maybe related issue #41475. It looks like the mechanism of
storing the command options really got slightly broken.
Comment 9 Peter Pis 2005-04-27 16:24:02 UTC
It is ok now, Martine, can you check it?
Comment 10 Martin Entlicher 2005-05-02 11:16:30 UTC
The template loading was made optional => FIXED.