This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.
Steps to reproduce: 1) create web project with glassfish server (for example) 2) open project properties, change server to tomcat 3) ok and (usually) deadlock Deadlock is met on project mutex and project childer mutex afaik. The issue is reproducible on builds since the 30th of August. I will attach two different thread dumps indicating the same deadlock.
Created attachment 47991 [details] thread dump 1
Created attachment 47992 [details] thread dump 2
fixed CVS log: Checking in ModelSupport.java; /shared/data/ccvs/repository/cnd/modelimpl/src/org/netbeans/modules/cnd/modelimpl/platform/ModelSupport.java,v <-- ModelSupport.java new revision: 1.25; previous revision: 1.24 done
No change in behaviour. Still the same deadlock.
The issue probably arrives with the implementation of the fix for issue 91291.
Could you provide new stack?
It is also 100% reproducable when you add Struts or JSF framework in project properties dialog and click OK.
I don't see any connection between the issue and the C/C++ Development Pack. Do you?
Will be addressed in the Java project types.
Beta stopper.
Too hard to fix for beta. Will be temporarily fixed by removing the fix of issue 91291 in all project types and then downgraded to P2. Checking in j2ee/clientproject/src/org/netbeans/modules/j2ee/clientproject/ui/customizer/CustomizerProviderImpl.java; /cvs/j2ee/clientproject/src/org/netbeans/modules/j2ee/clientproject/ui/customizer/CustomizerProviderImpl.java,v <-- CustomizerProviderImpl.java new revision: 1.9; previous revision: 1.8 done Checking in j2ee/ejbjarproject/src/org/netbeans/modules/j2ee/ejbjarproject/ui/customizer/CustomizerProviderImpl.java; /cvs/j2ee/ejbjarproject/src/org/netbeans/modules/j2ee/ejbjarproject/ui/customizer/CustomizerProviderImpl.java,v <-- CustomizerProviderImpl.java new revision: 1.17; previous revision: 1.16 done Checking in java/j2seproject/src/org/netbeans/modules/java/j2seproject/ui/customizer/CustomizerProviderImpl.java; /cvs/java/j2seproject/src/org/netbeans/modules/java/j2seproject/ui/customizer/CustomizerProviderImpl.java,v <-- CustomizerProviderImpl.java new revision: 1.14; previous revision: 1.13 done Checking in web/project/src/org/netbeans/modules/web/project/ui/customizer/CustomizerProviderImpl.java; /cvs/web/project/src/org/netbeans/modules/web/project/ui/customizer/CustomizerProviderImpl.java,v <-- CustomizerProviderImpl.java new revision: 1.18; previous revision: 1.17 done
I've reviewed the commit and agree with it.
Seems good, feel free to integrate.
Integrated in release60_beta1. Checking in j2ee/clientproject/src/org/netbeans/modules/j2ee/clientproject/ui/customizer/CustomizerProviderImpl.java; /cvs/j2ee/clientproject/src/org/netbeans/modules/j2ee/clientproject/ui/customizer/CustomizerProviderImpl.java,v <-- CustomizerProviderImpl.java new revision: 1.8.2.1; previous revision: 1.8 done Checking in j2ee/ejbjarproject/src/org/netbeans/modules/j2ee/ejbjarproject/ui/customizer/CustomizerProviderImpl.java; /cvs/j2ee/ejbjarproject/src/org/netbeans/modules/j2ee/ejbjarproject/ui/customizer/CustomizerProviderImpl.java,v <-- CustomizerProviderImpl.java new revision: 1.16.2.1; previous revision: 1.16 done Checking in java/j2seproject/src/org/netbeans/modules/java/j2seproject/ui/customizer/CustomizerProviderImpl.java; /cvs/java/j2seproject/src/org/netbeans/modules/java/j2seproject/ui/customizer/CustomizerProviderImpl.java,v <-- CustomizerProviderImpl.java new revision: 1.13.2.1; previous revision: 1.13 done Checking in web/project/src/org/netbeans/modules/web/project/ui/customizer/CustomizerProviderImpl.java; /cvs/web/project/src/org/netbeans/modules/web/project/ui/customizer/CustomizerProviderImpl.java,v <-- CustomizerProviderImpl.java new revision: 1.17.2.1; previous revision: 1.17 done
Shouldn't we close this issue (as it is fixed), and rather reopen issues 91291 and 114345, which are currently NOT fixed?
Well, issue #91291 is fixed because it was about how project properties are saved and now there is API to save project properties outside of AWT thread, so we should probably create new issue for j2seproject.
j2seproject, why? As far as I know it's a generic problem of the new API contract affecting all project types which want to use this new API, the report came to web project. I am for reopening of the issue #91291.
Definitely this issue is fixed in beta1. No more deadlocks.
Verified in NB 6.0 Beta 1 (Build 200709070000).
I don't consider this a problem of the API contract, but of the project types. Thus I'm reopening this issue (as the beta 1 fix was just a temporary fix).
IMO we should create new issues for each project type to fix saving of properties by leveraging the API. This issue about deadlock is indeed fixed and issue #91291 is fixed as well.
OK, seems it's better to close this. I filed issue 116203 instead and made it block issue 114345.
Created attachment 49532 [details] Patch to add visualweb/complib as a friend module
Please ignore the attachment to this bug. I accidentally attached it to the wrong one.