This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 112012 - I18N - Button label is shared but mnemonic key is different
Summary: I18N - Button label is shared but mnemonic key is different
Status: VERIFIED FIXED
Alias: None
Product: cnd
Classification: Unclassified
Component: I18N (show other bugs)
Version: 5.x
Hardware: All All
: P1 blocker (vote)
Assignee: Thomas Preisler
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2007-08-06 08:54 UTC by Keiichi Oono
Modified: 2007-08-09 05:45 UTC (History)
1 user (show)

See Also:
Issue Type: DEFECT
Exception Reporter:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Keiichi Oono 2007-08-06 08:54:43 UTC 
5.5.1
cnd/makeproject/src/org/netbeans/modules/cnd/makeproject/ui/utils/Bundle.properties

In the DirectoryChooserPanel, the button label "Down" seems to be shared with ListEditorPanel
(TARGET_EDITOR_DOWN_BUTON). However, the different mnemonic key is assigned ("w" in the DirectoryChooserPanel, and "D"
in the ListEditorPanel). When the dialog is translating into Chinese or Japanese, mnemonic key is embedded in the button
label with bracket.
  see the following URL for image: http://java.sun.com/products/jlf/ed2/book/HIG.Issues3.html

I translate TARGET_EDITOR_DOWN_BUTTON to "DOWN_IN_JAPANESE (D)" for ListEditorPanel. In the DirectoryChooserPanel, the
button label should be "DOWN_IN_JAPANESE (W)", but "DOWN_IN_JAPANESE (D)" is used.

We can not use shared button label with different mnemonic keys in the localized version. Please create different button
label for DirectoryChooserPanel.
Comment 1 julieg 2007-08-06 19:38:18 UTC 
This bug should be fixed for CND 551U1.
Comment 2 Thomas Preisler 2007-08-07 00:27:12 UTC 
I understand and the fix is to override getDownButtonText in DirectoryChooserPanel:

public String getDownButtonText() {
    return getString("DOWN_BUTTON_TXT");
}

and add the following entry to the .../ui/utils/Bundle.properties file:

DOWN_BUTTON_TXT=Down

Agree?
Comment 3 Thomas Preisler 2007-08-07 00:29:03 UTC 
Please note the proposed fix will change the contents of the bundle file so you will need a new l10n kit. Just making
sure you are aware of this.
Comment 4 Keiichi Oono 2007-08-07 01:26:08 UTC 
Thank you for your fixing!
Yes, I agree with you to add DOWN_BUTTON_TXT in Bundle.properties.
And I make sure in the l10n team to get the new l10n-kit for this fixing.
Comment 5 Thomas Preisler 2007-08-07 19:24:32 UTC 
Fixed and committed to release551u1 branch.
Comment 6 Keiichi Oono 2007-08-09 05:45:36 UTC 
Verified in cnd Build070808.
Thank you for your prompt fixing!