This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 111987 - VMDNodeAnchor recalculates unnecessarily
Summary: VMDNodeAnchor recalculates unnecessarily
Status: RESOLVED FIXED
Alias: None
Product: platform
Classification: Unclassified
Component: Graph (show other bugs)
Version: 6.x
Hardware: All All
: P3 blocker (vote)
Assignee: issues@platform
URL:
Keywords: API_REVIEW_FAST
Depends on:
Blocks:
 
Reported: 2007-08-04 16:36 UTC by vieiro
Modified: 2007-08-21 09:48 UTC (History)
0 users

See Also:
Issue Type: DEFECT
Exception Reporter:

Attachments
Patch (7.81 KB, patch)
2007-08-06 08:57 UTC, David Kaspar 		Details | Diff
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description vieiro 2007-08-04 16:36:57 UTC 
In Visual Graph Library 2.0 pre3, in VMDNodeAnchor.java, the variable "requiresCalculation" is never set to false

(so VMDNodeAnchor is always recalculating?)

Suggestion: add "requiresCalculation = false" at the end of the "recalculate" method.

Cheers,
Antonio
Comment 1 David Kaspar 2007-08-06 08:56:39 UTC 
Yes, this is an issue and should be fixed as proposed. Additional there is a need for "Anchor.notifyRevalidate" method
to be called from "Anchor.revalidateDependency" to notify the anchor that related widget has be moved... Without this
new method the "requiresCalculation=false" cannot be applied.
Comment 2 David Kaspar 2007-08-06 08:57:05 UTC 
Created attachment 46173 [details]
Patch
Comment 3 David Kaspar 2007-08-06 08:58:43 UTC 
A patch has been attached. It contains the fix, the new "Anchor.notifyRevalidate" method and
apichange.AnchorNotificationTest test case.
Asking for fast API review.
Comment 4 David Kaspar 2007-08-21 09:48:45 UTC 
Patch committed to the main trunk.