This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 110954 - I18N Search bar too narrow if bigger font is used
Summary: I18N Search bar too narrow if bigger font is used
Status: VERIFIED FIXED
Alias: None
Product: editor
Classification: Unclassified
Component: Search (show other bugs)
Version: 6.x
Hardware: All All
: P2 blocker (vote)
Assignee: Jan Pokorsky
URL:
Keywords: I18N
Depends on:
Blocks:
 
Reported: 2007-07-25 15:17 UTC by Jiri Prox
Modified: 2007-11-05 13:42 UTC (History)
2 users (show)

See Also:
Issue Type: DEFECT
Exception Reporter:


Attachments
screenshot (5.73 KB, image/png)
2007-07-25 15:17 UTC, Jiri Prox
Details
sketch with pop-up panel (45.94 KB, image/png)
2007-07-31 12:57 UTC, Ondrej Langr
Details
screenshot 1024x768 (3.82 KB, image/png)
2007-08-08 16:12 UTC, Jan Pokorsky
Details
how StarOffice does it (46.95 KB, image/png)
2007-08-08 17:12 UTC, Ondrej Langr
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Jiri Prox 2007-07-25 15:17:13 UTC
Product Version: NetBeans IDE Dev (Build 200707211200) Java: 1.5.0_12; Java HotSpot(TM) Client VM 1.5.0_12-b04
System:Linux version 2.6.5-1.358 running on i386; UTF-8; ja_JP (nb) Userdir: /space/ui18n
font size 14
pseudolocalized

Search bar is too narrow if bigger font is used, there is no indication that some checkboxes are not visible.
Comment 1 Jiri Prox 2007-07-25 15:17:57 UTC
Created attachment 45676 [details]
screenshot
Comment 2 Vitezslav Stejskal 2007-07-26 11:34:39 UTC
It's a problem in English too. I've got Ubuntu/Gnome with screen resolution 1280x800 and with --fontsize 14 and the
standard window layout after starting netbeans the label of the last checkbox is not fully visible.

We can't do much about the screen space available for the search bar. The bar has to be small in order to be efficient
and easy to use. We could however think about reorganizing things that are shown on the bar. I can see several variants:

A. Do not use labels for prev/next buttons and use shorter labels for the checkboxes
B. Remove all checkboxes from the bar and add a special button for the search option that would show a dialog and let
user click the checkboxes. The button could be labeled with 'Options' or 'Search Options' or simply just '...' or
something else.

Ondro, what would you suggest? Any other ideas?
Comment 3 Ondrej Langr 2007-07-31 12:56:07 UTC
We considered 2) in the past, but I would suggest not to go with it because it adds an extra click overhead and forces
the user to move their attention from the bar to other dialog which can be IMO rather annoying for such frequently used
feature.

As for making the bar shorter, I agree with A): not displaying the labels for next/previous, ideally only when the bar
is too long. I can not really imagine making other labels shorter, maybe just Regular Expression -> Regexp with
appropriate tooltip, but I don't really like the idea.

Another solution would be to use approach similar to what windows or firefox use .. add a little icon to symbolize
presence of other options to the end of the search bar. When this icon is clicked, it'd open the list of options which
were not displayed (see attached file). But I am not sure if this is feasible to implement for 6.0. A lightweight
version of this is to only add the indication that part of the toolbar (it's most likely only going to be 'highlight
results' label) is hidden.

I personally do not consider a big issue if the 'Highlight Results' label is not displayed entirely in english version
of NetBeans. This option is a matter of user preference and as such is not going to be used frequently, but at least we
need to make sure that the checkbox is visible with default layout and lowest supported resolution, so that the user can
actually see that there's an option he might be interested in.
Comment 4 Ondrej Langr 2007-07-31 12:57:49 UTC
Created attachment 45933 [details]
sketch with pop-up panel
Comment 5 Jan Pokorsky 2007-08-08 16:10:56 UTC
Ondro, what is the lowest supported resolution? I tried this with 1024x768 and it looks OK. See the screenshot.

Jirko, what is the pseudolocalized version? It seems to me that for plain Japanese it is not an issue.
Comment 6 Jan Pokorsky 2007-08-08 16:12:14 UTC
Created attachment 46352 [details]
screenshot 1024x768
Comment 7 Ondrej Langr 2007-08-08 17:10:29 UTC
The lowest supported resolution is 1024x768 which you tried, so I agree it is not a problem for absolute majority of
users. However, some users use bigger fonts and in this case it might become an issue. Is it technically possible to do
something like e.g. openOffice does? (see screenshot). Or omitting the next/previous labels, if the bar exceeds the
displayed area, would do. 
Comment 8 Ondrej Langr 2007-08-08 17:12:22 UTC
Created attachment 46355 [details]
how StarOffice does it
Comment 9 Jan Pokorsky 2007-08-08 18:32:10 UTC
Yes, I guess it is possible. I am prototyping it. But it seems to me a bit inconsistent with other UI. Try to shrink
width of the running IDE and watch main menu, toolbars, editor tabs, ... I can see at least 4 different ways solving the
same, insufficient horizontal space. This would be the fifth.
Comment 10 Ondrej Langr 2007-08-08 18:57:02 UTC
I see your point. Of all the IDE elements, search bar is IMO closest to editor toolbar (by both function and position),
which right now, when rescaled, behaves the same as searchbar - the part beyond the visible area simply "disappears",
without any indication. This is surely wrong (but is not a real issue given the typical number of editor toolbar
buttons) and should be replaced by some other way. Which makes it still four :). The approach the main toolbar takes
(breaking into several lines) would be also fine. Only for the search bar it is IMO necessary to shrink back to one line
height when the window is made wide enough which main toolbar currently does not.
Comment 11 Jan Pokorsky 2007-08-13 14:12:00 UTC
fixed in

/cvs/editor/src/org/netbeans/modules/editor/impl/SearchBar.java
new revision: 1.14; previous revision: 1.13
/cvs/editor/src/org/netbeans/modules/editor/impl/Bundle.properties
new revision: 1.3; previous revision: 1.2
Comment 12 Ken Frank 2007-09-29 05:10:08 UTC
This looks ok using 14 pt font; Jirka, can you confirm if its ok for you also 
and then it can be verified.

ken.frank@sun.com
Comment 13 Jiri Prox 2007-10-01 08:56:25 UTC
it's ok now -> verified