110657 – Fix up nbbuild/ausrc, *.dtd

This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 110657 - Fix up nbbuild/ausrc, *.dtd

Summary: Fix up nbbuild/ausrc, *.dtd

Status:	RESOLVED FIXED

Alias:	None

Product:	platform
Classification:	Unclassified
Component:	Autoupdate (show other bugs)
Version:	6.x
Hardware:	All All

Importance:	P1 blocker (vote)
Assignee:	Jiri Rechtacek

URL:
Keywords:

Depends on:
Blocks:	110570
	Show dependency tree

Reported:	2007-07-24 00:00 UTC by Jesse Glick
Modified:	2007-09-28 15:44 UTC (History)
CC List:	1 user (show)

See Also:
Issue Type:	TASK
Exception Reporter:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Jesse Glick 2007-07-24 00:00:17 UTC

1. nbbuild/ausrc is probably to be obsolete; so, should be deleted.

2. DTDs (in autoupdate/services/libsrc/org/netbeans/updater/resources and www/www/dtds) should be updated as follows:

2a. Delete now obsolete autoupdate-info-3_0.dtd. It never actually contained anything useful; in fact it is a regression
from 2.4!

2b. Modify autoupdate-catalog-3_0.dtd (or rename to autoupdate-catalog-2_5.dtd): delete <feature> (and its ref from
<module_updates>), add eager and autoload attributes to <module> (permitted value '(true|false)'), leave new attrs on
<manifest>.

Comment 1 Jesse Glick 2007-07-24 00:01:25 UTC

I will use the new DTD ref in issue #110570. For now, assuming it will be autoupdate-catalog-2_5.dtd.

Comment 2 Jesse Glick 2007-07-24 00:18:50 UTC

Some refinements regarding (2):

autoupdate-info-2_5.dtd _does_ need to be created, to include added <manifest> attributes, such as
OpenIDE-Module-Recommends.

autoupdate-{catalog,info}-2.5.dtd should _not_ include the <manifest> attribute OpenIDE-Module-Friends. This is only
useful to the module system (when setting up class loader dependencies), not AU, since it can have no effect on module
enablement logic. OpenIDE-Module-Build-Version, OpenIDE-Module-Deprecated, and OpenIDE-Module-Deprecation-Message are of
questionable value; I assume AU does not use these at present and probably never will.

Comment 3 Jesse Glick 2007-07-24 00:25:25 UTC

I fixed <makenbm> to add AutoUpdate-* attrs to <manifest> in Info.xml:

Checking in MakeNBM.java;
/shared/data/ccvs/repository/nbbuild/antsrc/org/netbeans/nbbuild/MakeNBM.java,v  <--  MakeNBM.java
new revision: 1.75.28.1; previous revision: 1.75
done

And another note:

autoupdate-{catalog,info}-2.5.dtd must include AutoUpdate-Show-In-Client and AutoUpdate-Essential-Module as permitted
attributes of <manifest>. I will set the new DTD when either of these are present:

Checking in MakeNBM.java;
/shared/data/ccvs/repository/nbbuild/antsrc/org/netbeans/nbbuild/MakeNBM.java,v  <--  MakeNBM.java
new revision: 1.75.28.2; previous revision: 1.75.28.1
done

Comment 4 Jiri Rechtacek 2007-07-25 14:43:54 UTC

Task 1) will tracked separately as issue 110943.

Task 2) was fixed.

cvs server: scheduling file `autoupdate-catalog-2_5.dtd' for addition on branch `issue_110566'
cvs server: scheduling file `autoupdate-info-2_5.dtd' for addition on branch `issue_110566'
cvs server: use 'cvs commit' to add these files permanently
Removing autoupdate/services/libsrc/org/netbeans/updater/resources/autoupdate-info-1_0.dtd;
/shared/data/ccvs/repository/autoupdate/services/libsrc/org/netbeans/updater/resources/autoupdate-info-1_0.dtd,v  <-- 
autoupdate-info-1_0.dtd
new revision: delete; previous revision: 1.2.10
done
Removing autoupdate/services/libsrc/org/netbeans/updater/resources/autoupdate-info-2_3.dtd;
/shared/data/ccvs/repository/autoupdate/services/libsrc/org/netbeans/updater/resources/autoupdate-info-2_3.dtd,v  <-- 
autoupdate-info-2_3.dtd
new revision: delete; previous revision: 1.2.10
done
Removing autoupdate/services/libsrc/org/netbeans/updater/resources/autoupdate-catalog-2_3.dtd;
/shared/data/ccvs/repository/autoupdate/services/libsrc/org/netbeans/updater/resources/autoupdate-catalog-2_3.dtd,v  <--
 autoupdate-catalog-2_3.dtd
new revision: delete; previous revision: 1.2.10
done
Removing autoupdate/services/libsrc/org/netbeans/updater/resources/autoupdate-catalog-2_4.dtd;
/shared/data/ccvs/repository/autoupdate/services/libsrc/org/netbeans/updater/resources/autoupdate-catalog-2_4.dtd,v  <--
 autoupdate-catalog-2_4.dtd
new revision: delete; previous revision: 1.2.10
done
Removing autoupdate/services/libsrc/org/netbeans/updater/resources/autoupdate-info-2_2.dtd;
/shared/data/ccvs/repository/autoupdate/services/libsrc/org/netbeans/updater/resources/autoupdate-info-2_2.dtd,v  <-- 
autoupdate-info-2_2.dtd
new revision: delete; previous revision: 1.2.10
done
Removing autoupdate/services/libsrc/org/netbeans/updater/resources/autoupdate-catalog-2_2.dtd;
/shared/data/ccvs/repository/autoupdate/services/libsrc/org/netbeans/updater/resources/autoupdate-catalog-2_2.dtd,v  <--
 autoupdate-catalog-2_2.dtd
new revision: delete; previous revision: 1.2.10
done
Removing autoupdate/services/libsrc/org/netbeans/updater/resources/autoupdate-catalog-2_0.dtd;
/shared/data/ccvs/repository/autoupdate/services/libsrc/org/netbeans/updater/resources/autoupdate-catalog-2_0.dtd,v  <--
 autoupdate-catalog-2_0.dtd
new revision: delete; previous revision: 1.2.10
done
Removing autoupdate/services/libsrc/org/netbeans/updater/resources/autoupdate-catalog-1_0.dtd;
/shared/data/ccvs/repository/autoupdate/services/libsrc/org/netbeans/updater/resources/autoupdate-catalog-1_0.dtd,v  <--
 autoupdate-catalog-1_0.dtd
new revision: delete; previous revision: 1.2.10
done
Removing autoupdate/services/libsrc/org/netbeans/updater/resources/autoupdate-info-2_0.dtd;
/shared/data/ccvs/repository/autoupdate/services/libsrc/org/netbeans/updater/resources/autoupdate-info-2_0.dtd,v  <-- 
autoupdate-info-2_0.dtd
new revision: delete; previous revision: 1.2.10
done
Removing autoupdate/services/libsrc/org/netbeans/updater/resources/autoupdate-info-2_4.dtd;
/shared/data/ccvs/repository/autoupdate/services/libsrc/org/netbeans/updater/resources/autoupdate-info-2_4.dtd,v  <-- 
autoupdate-info-2_4.dtd
new revision: delete; previous revision: 1.2.10
done
Checking in autoupdate/services/src/org/netbeans/modules/autoupdate/updateprovider/AutoupdateCatalogParser.java;
/shared/data/ccvs/repository/autoupdate/services/src/org/netbeans/modules/autoupdate/updateprovider/AutoupdateCatalogParser.java,v
 <--  AutoupdateCatalogParser.java
new revision: 1.7.2.1; previous revision: 1.7
done
IDE: [7/25/07 3:31 PM] Diffing Files finished
RCS file:
/shared/data/ccvs/repository/autoupdate/services/src/org/netbeans/modules/autoupdate/updateprovider/dtds/Attic/autoupdate-catalog-2_5.dtd,v
done
Checking in autoupdate/services/src/org/netbeans/modules/autoupdate/updateprovider/dtds/autoupdate-catalog-2_5.dtd;
/shared/data/ccvs/repository/autoupdate/services/src/org/netbeans/modules/autoupdate/updateprovider/dtds/Attic/autoupdate-catalog-2_5.dtd,v
 <--  autoupdate-catalog-2_5.dtd
new revision: 1.1.2.1; previous revision: 1.1
done
RCS file:
/shared/data/ccvs/repository/autoupdate/services/src/org/netbeans/modules/autoupdate/updateprovider/dtds/Attic/autoupdate-info-2_5.dtd,v
done
Checking in autoupdate/services/src/org/netbeans/modules/autoupdate/updateprovider/dtds/autoupdate-info-2_5.dtd;
/shared/data/ccvs/repository/autoupdate/services/src/org/netbeans/modules/autoupdate/updateprovider/dtds/Attic/autoupdate-info-2_5.dtd,v
 <--  autoupdate-info-2_5.dtd
new revision: 1.1.2.1; previous revision: 1.1
done
Removing autoupdate/services/src/org/netbeans/modules/autoupdate/updateprovider/dtds/autoupdate-catalog-3_0.dtd;
/shared/data/ccvs/repository/autoupdate/services/src/org/netbeans/modules/autoupdate/updateprovider/dtds/autoupdate-catalog-3_0.dtd,v
 <--  autoupdate-catalog-3_0.dtd
new revision: delete; previous revision: 1.4.4
done
Removing autoupdate/services/src/org/netbeans/modules/autoupdate/updateprovider/dtds/autoupdate-info-3_0.dtd;
/shared/data/ccvs/repository/autoupdate/services/src/org/netbeans/modules/autoupdate/updateprovider/dtds/autoupdate-info-3_0.dtd,v
 <--  autoupdate-info-3_0.dtd
new revision: delete; previous revision: 1.3.4
done
Removing www/www/dtds/autoupdate-catalog-3_0.dtd;
/shared/data/ccvs/repository/www/www/dtds/autoupdate-catalog-3_0.dtd,v  <--  autoupdate-catalog-3_0.dtd
new revision: delete; previous revision: 1.3.2
done
RCS file: /shared/data/ccvs/repository/www/www/dtds/Attic/autoupdate-info-2_5.dtd,v
done
Checking in www/www/dtds/autoupdate-info-2_5.dtd;
/shared/data/ccvs/repository/www/www/dtds/Attic/autoupdate-info-2_5.dtd,v  <--  autoupdate-info-2_5.dtd
new revision: 1.1.2.1; previous revision: 1.1
done
RCS file: /shared/data/ccvs/repository/www/www/dtds/Attic/autoupdate-catalog-2_5.dtd,v
done
Checking in www/www/dtds/autoupdate-catalog-2_5.dtd;
/shared/data/ccvs/repository/www/www/dtds/Attic/autoupdate-catalog-2_5.dtd,v  <--  autoupdate-catalog-2_5.dtd
new revision: 1.1.2.1; previous revision: 1.1
done
Removing www/www/dtds/autoupdate-info-3_0.dtd;
/shared/data/ccvs/repository/www/www/dtds/autoupdate-info-3_0.dtd,v  <--  autoupdate-info-3_0.dtd
new revision: delete; previous revision: 1.2.2
done

Comment 5 Jesse Glick 2007-07-25 16:26:08 UTC

Why did you delete all the DTDs in libsrc?! XMLUtil.createAUResolver requires them to be there.

Comment 6 Jiri Rechtacek 2007-07-25 18:30:39 UTC

My fault. DTDs in Autoupdate were (faulty) duplicated in folders
autoupdate/services/src/org/netbeans/modules/autoupdate/updateprovider/dtds and
autoupdate/services/libsrc/org/netbeans/updater/resources. I had forget about XMLUtil.createAUResolver() when I was
removing them. I'll fix it (e.g. either move updateprovider/dtds to updater/resources or fix the path in
XMLUtil.createAUResolver()). Thanks for detection the problem.

Comment 7 Jiri Rechtacek 2007-07-26 14:30:53 UTC

Removing src/org/netbeans/modules/autoupdate/updateprovider/dtds/autoupdate-catalog-1_0.dtd;
/shared/data/ccvs/repository/autoupdate/services/src/org/netbeans/modules/autoupdate/updateprovider/dtds/autoupdate-catalog-1_0.dtd,v
 <--  autoupdate-catalog-1_0.dtd
new revision: delete; previous revision: 1.2.10
done
Removing src/org/netbeans/modules/autoupdate/updateprovider/dtds/autoupdate-catalog-2_4.dtd;
/shared/data/ccvs/repository/autoupdate/services/src/org/netbeans/modules/autoupdate/updateprovider/dtds/autoupdate-catalog-2_4.dtd,v
 <--  autoupdate-catalog-2_4.dtd
new revision: delete; previous revision: 1.2.10
done
Removing src/org/netbeans/modules/autoupdate/updateprovider/dtds/autoupdate-catalog-2_5.dtd;
/shared/data/ccvs/repository/autoupdate/services/src/org/netbeans/modules/autoupdate/updateprovider/dtds/Attic/autoupdate-catalog-2_5.dtd,v
 <--  autoupdate-catalog-2_5.dtd
new revision: delete; previous revision: 1.1.2.1
done
Removing src/org/netbeans/modules/autoupdate/updateprovider/dtds/autoupdate-info-2_4.dtd;
/shared/data/ccvs/repository/autoupdate/services/src/org/netbeans/modules/autoupdate/updateprovider/dtds/autoupdate-info-2_4.dtd,v
 <--  autoupdate-info-2_4.dtd
new revision: delete; previous revision: 1.2.10
done
Removing src/org/netbeans/modules/autoupdate/updateprovider/dtds/autoupdate-info-1_0.dtd;
/shared/data/ccvs/repository/autoupdate/services/src/org/netbeans/modules/autoupdate/updateprovider/dtds/autoupdate-info-1_0.dtd,v
 <--  autoupdate-info-1_0.dtd
new revision: delete; previous revision: 1.2.10
done
Removing src/org/netbeans/modules/autoupdate/updateprovider/dtds/autoupdate-info-2_5.dtd;
/shared/data/ccvs/repository/autoupdate/services/src/org/netbeans/modules/autoupdate/updateprovider/dtds/Attic/autoupdate-info-2_5.dtd,v
 <--  autoupdate-info-2_5.dtd
new revision: delete; previous revision: 1.1.2.1
done
Removing src/org/netbeans/modules/autoupdate/updateprovider/dtds/autoupdate-info-2_2.dtd;
/shared/data/ccvs/repository/autoupdate/services/src/org/netbeans/modules/autoupdate/updateprovider/dtds/autoupdate-info-2_2.dtd,v
 <--  autoupdate-info-2_2.dtd
new revision: delete; previous revision: 1.2.10
done
Removing src/org/netbeans/modules/autoupdate/updateprovider/dtds/autoupdate-catalog-2_2.dtd;
/shared/data/ccvs/repository/autoupdate/services/src/org/netbeans/modules/autoupdate/updateprovider/dtds/autoupdate-catalog-2_2.dtd,v
 <--  autoupdate-catalog-2_2.dtd
new revision: delete; previous revision: 1.2.10
done
Removing src/org/netbeans/modules/autoupdate/updateprovider/dtds/autoupdate-info-2_0.dtd;
/shared/data/ccvs/repository/autoupdate/services/src/org/netbeans/modules/autoupdate/updateprovider/dtds/autoupdate-info-2_0.dtd,v
 <--  autoupdate-info-2_0.dtd
new revision: delete; previous revision: 1.2.10
done
Removing src/org/netbeans/modules/autoupdate/updateprovider/dtds/autoupdate-catalog-2_0.dtd;
/shared/data/ccvs/repository/autoupdate/services/src/org/netbeans/modules/autoupdate/updateprovider/dtds/autoupdate-catalog-2_0.dtd,v
 <--  autoupdate-catalog-2_0.dtd
new revision: delete; previous revision: 1.2.10
done
Removing src/org/netbeans/modules/autoupdate/updateprovider/dtds/autoupdate-catalog-2_3.dtd;
/shared/data/ccvs/repository/autoupdate/services/src/org/netbeans/modules/autoupdate/updateprovider/dtds/autoupdate-catalog-2_3.dtd,v
 <--  autoupdate-catalog-2_3.dtd
new revision: delete; previous revision: 1.2.10
done
Removing src/org/netbeans/modules/autoupdate/updateprovider/dtds/autoupdate-info-2_3.dtd;
/shared/data/ccvs/repository/autoupdate/services/src/org/netbeans/modules/autoupdate/updateprovider/dtds/autoupdate-info-2_3.dtd,v
 <--  autoupdate-info-2_3.dtd
new revision: delete; previous revision: 1.2.10
done
Checking in libsrc/org/netbeans/updater/resources/autoupdate-info-2_2.dtd;
/shared/data/ccvs/repository/autoupdate/services/libsrc/org/netbeans/updater/resources/autoupdate-info-2_2.dtd,v  <-- 
autoupdate-info-2_2.dtd
new revision: 1.2.10.2; previous revision: 1.2.10.1
done
Checking in libsrc/org/netbeans/updater/resources/autoupdate-info-2_0.dtd;
/shared/data/ccvs/repository/autoupdate/services/libsrc/org/netbeans/updater/resources/autoupdate-info-2_0.dtd,v  <-- 
autoupdate-info-2_0.dtd
new revision: 1.2.10.2; previous revision: 1.2.10.1
done
RCS file:
/shared/data/ccvs/repository/autoupdate/services/libsrc/org/netbeans/updater/resources/Attic/autoupdate-catalog-2_5.dtd,v
done
Checking in libsrc/org/netbeans/updater/resources/autoupdate-catalog-2_5.dtd;
/shared/data/ccvs/repository/autoupdate/services/libsrc/org/netbeans/updater/resources/Attic/autoupdate-catalog-2_5.dtd,v
 <--  autoupdate-catalog-2_5.dtd
new revision: 1.1.2.1; previous revision: 1.1
done
Checking in libsrc/org/netbeans/updater/resources/autoupdate-info-1_0.dtd;
/shared/data/ccvs/repository/autoupdate/services/libsrc/org/netbeans/updater/resources/autoupdate-info-1_0.dtd,v  <-- 
autoupdate-info-1_0.dtd
new revision: 1.2.10.2; previous revision: 1.2.10.1
done
Checking in libsrc/org/netbeans/updater/resources/autoupdate-catalog-2_4.dtd;
/shared/data/ccvs/repository/autoupdate/services/libsrc/org/netbeans/updater/resources/autoupdate-catalog-2_4.dtd,v  <--
 autoupdate-catalog-2_4.dtd
new revision: 1.2.10.2; previous revision: 1.2.10.1
done
Checking in libsrc/org/netbeans/updater/resources/autoupdate-catalog-2_3.dtd;
/shared/data/ccvs/repository/autoupdate/services/libsrc/org/netbeans/updater/resources/autoupdate-catalog-2_3.dtd,v  <--
 autoupdate-catalog-2_3.dtd
new revision: 1.2.10.2; previous revision: 1.2.10.1
done
RCS file:
/shared/data/ccvs/repository/autoupdate/services/libsrc/org/netbeans/updater/resources/Attic/autoupdate-info-2_5.dtd,v
done
Checking in libsrc/org/netbeans/updater/resources/autoupdate-info-2_5.dtd;
/shared/data/ccvs/repository/autoupdate/services/libsrc/org/netbeans/updater/resources/Attic/autoupdate-info-2_5.dtd,v 
<--  autoupdate-info-2_5.dtd
new revision: 1.1.2.1; previous revision: 1.1
done
Checking in libsrc/org/netbeans/updater/resources/autoupdate-catalog-2_0.dtd;
/shared/data/ccvs/repository/autoupdate/services/libsrc/org/netbeans/updater/resources/autoupdate-catalog-2_0.dtd,v  <--
 autoupdate-catalog-2_0.dtd
new revision: 1.2.10.2; previous revision: 1.2.10.1
done
Checking in libsrc/org/netbeans/updater/resources/autoupdate-catalog-1_0.dtd;
/shared/data/ccvs/repository/autoupdate/services/libsrc/org/netbeans/updater/resources/autoupdate-catalog-1_0.dtd,v  <--
 autoupdate-catalog-1_0.dtd
new revision: 1.2.10.2; previous revision: 1.2.10.1
done
Checking in libsrc/org/netbeans/updater/resources/autoupdate-catalog-2_2.dtd;
/shared/data/ccvs/repository/autoupdate/services/libsrc/org/netbeans/updater/resources/autoupdate-catalog-2_2.dtd,v  <--
 autoupdate-catalog-2_2.dtd
new revision: 1.2.10.2; previous revision: 1.2.10.1
done
Checking in libsrc/org/netbeans/updater/resources/autoupdate-info-2_3.dtd;
/shared/data/ccvs/repository/autoupdate/services/libsrc/org/netbeans/updater/resources/autoupdate-info-2_3.dtd,v  <-- 
autoupdate-info-2_3.dtd
new revision: 1.2.10.2; previous revision: 1.2.10.1
done
Checking in libsrc/org/netbeans/updater/resources/autoupdate-info-2_4.dtd;
/shared/data/ccvs/repository/autoupdate/services/libsrc/org/netbeans/updater/resources/autoupdate-info-2_4.dtd,v  <-- 
autoupdate-info-2_4.dtd
new revision: 1.2.10.2; previous revision: 1.2.10.1
done
Checking in src/org/netbeans/modules/autoupdate/updateprovider/AutoupdateInfoParser.java;
/shared/data/ccvs/repository/autoupdate/services/src/org/netbeans/modules/autoupdate/updateprovider/AutoupdateInfoParser.java,v
 <--  AutoupdateInfoParser.java
new revision: 1.7.2.1; previous revision: 1.7
done
Checking in src/org/netbeans/modules/autoupdate/updateprovider/AutoupdateCatalogParser.java;
/shared/data/ccvs/repository/autoupdate/services/src/org/netbeans/modules/autoupdate/updateprovider/AutoupdateCatalogParser.java,v
 <--  AutoupdateCatalogParser.java
new revision: 1.7.2.2; previous revision: 1.7.2.1
done
Checking in libsrc/org/netbeans/updater/XMLUtil.java;
/shared/data/ccvs/repository/autoupdate/services/libsrc/org/netbeans/updater/XMLUtil.java,v  <--  XMLUtil.java
new revision: 1.2.10.1; previous revision: 1.2
done

Comment 8 _ sandipchitale 2007-08-17 19:28:19 UTC

The removal of 3_0 dtd is breaking the findbugs update center:

https://sqe.dev.java.net/updatecenters/sqe/catalog.xml

which refers to it.

Comment 9 Jesse Glick 2007-08-21 01:14:34 UTC

Please notify the maintainer of the FindBugs UC.

Comment 10 sreimers 2007-09-28 15:44:29 UTC

Just for the record, the SQE updatecenter has been fixed and is now available at
https://sqe.dev.java.net/updatecenters/sqe/updates.xml.