Create new WebApplication
create new tag library
Create new tagFile and add it into library
add this line into index.jsp:
<%@ taglib prefix="library" uri="/WEB-INF/tlds/library"%>
type <library:| and press Ctrl+Space to invoke cc in index.jsp
tag file is completed
open tag file add some required attribute:
<%@attribute name="title" required="true"%>
go back to index.jsp:
there is an error highlighted for library tag because of missing required attribute, but it's not offered by code completion
Created attachment 44994 [details]
Code completion takes the results from jsp parser so in this case it looks like erroneous data caching in the jsp parser.
The problem is that jspparser parses the page after a change in the page. If you create a page in the jsp, then the cc
I'm can reproduce this problem, but it seems that cc is refreshed after first edit action in jsp page. This is P4 issue
for me now - it was probably partially fixed in lates changes in jsp parser.
This problem has became more serious probably after latest changes in jsp parser -> no attributes are updated in
completion nor in error highlighting.
Use scenario described above, change tagfile attributes (rename, add, remove), no changes are propagated into jsp page.
Reopening jsp page doesn't help. Just ide restart works for me to update data in cc -> increasing priority.
Jindro, is there any change/regression in comparison with NB 6.0/5.5? Thanks.
In 6.0 attributes error highlighting was updated correctly and code completion was not always updated as described in
this issue, but it was updated after closing and reopening file. Actual behavior doesn't update after reopening page and
highlighting is not updated either.
OK, thanks for clarification.
Jindro, could you please try NB dev build from 20th of february? After that date I made some changes which could be
related to this regression. Thanks a lot.
I've tryed it on 200802191203 and doesn't work as well.
Fixed, please verify. Btw feel free to leave this issue reopened as a reminder for not refreshing of a page. Thanks.
user: Tomas Mysik <email@example.com>
date: Wed Feb 27 16:31:31 2008 +0100
summary: #109478: [cc] is not updated for changes in tagfiles
Adding Marek to CC because I think that we could probably solve the issue with not refreshing of a page (see the
comment 'jsedek Mon Oct 15 15:39:28 +0000 2007'). Now, JSP parser could fire event after its cache is recreated,
TagLibParseSupport could be listening to it. What do you think about it? Thanks.
To my previous comment - it's possible, I have working prototype.
So reopening, lowering priority and removing REGRESSION keyword.
I've done needed changes in JSP Parser. Marku, would it be possible to review patch for JSP Core? It's not completely
working, if the tab is not shown then the refresh does not work. But I hope it will be doable. Thanks.
Created attachment 57610 [details]
patch for JSP Core
Reassigning after a discussion with Marek. See my last comments for more information. Thanks.
I'm going to backport fix for this issue to release601_fixes branch.
I've backported changeset http://hg.netbeans.org/main?cmd=changeset;node=bded5870b4f2 to release601_fixes branch
IDE: [3/13/08 2:15 PM] Committing "WebAppParseSupport.java" started
Checking in WebAppParseSupport.java;
new revision: 188.8.131.52; previous revision: 184.108.40.206
IDE: [3/13/08 2:15 PM] Committing "WebAppParseSupport.java" finished
moving opened issues from TM <= 6.1 to TM=Dev
the patch looks ok to me, go ahead and integrate if you still need it.
Changing to ENHANCEMENT, I think that the patch didn't work correctly - when one switches to different tab
(file), "something" is not called/updated (there were no errors visible, only after some change so no improvement at
all). I will try to look at it.
This old bug may not be relevant anymore. If you can still reproduce it in 8.2 development builds please reopen this issue.
Thanks for your cooperation,
NetBeans IDE 8.2 Release Boss