This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 108903 - I18N - regenerate web samples to fix compilation warnings related to encoding
Summary: I18N - regenerate web samples to fix compilation warnings related to encoding
Status: VERIFIED FIXED
Alias: None
Product: javaee
Classification: Unclassified
Component: Web Project (show other bugs)
Version: 5.x
Hardware: All All
: P3 blocker (vote)
Assignee: Tomas Mysik
URL:
Keywords: I18N
Depends on:
Blocks: 120529
  Show dependency tree
 
Reported: 2007-07-04 18:49 UTC by Ken Frank
Modified: 2008-06-09 12:44 UTC (History)
3 users (show)

See Also:
Issue Type: DEFECT
Exception Reporter:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Ken Frank 2007-07-04 18:49:41 UTC
part of this might be related to new project encoding property and part is related to 
encoding handling for generating javadoc 

assumption here is that it is ok for user to change some labels or other ui items part of using the sample.
And it might be that the created project might have multibyte in it anyway if proct name has multibyte
in it and thats used as name of package or class, or that date is part of the temate and so would
have mbyte characters in it.

0. this is for the web sample projects -  this case if where  the encoding of the project is not changed - the default
case is that
utf-8 encoding is used but if encoding was changed in another project, that encodg becomes the global
encoding value.

1. when multibyte is added to some label and thus its then in the java code, when compiling the project
or when generating javadoc, some warnings about encoding are shown but the projecand javadoc compiles
ok.

2.  the fix for javadoc has been filed in various project types; the fix relates  
javadoc.encoding property defined in the project.properties
 wasn't used only defined.

3. the regeneration of the sample projects for nb6 could help with these warning since the build-impl.xml
will also be regenerated.   Tomas can provide more information on these topics.

4. Also, these samples might have jsp or html files in them and the 
encoding value used in creation of these files is different than in past, and works with the new project
encoding, so regeneration of the samples might help those files in the samples to be compatible with that.
Comment 1 Ken Frank 2007-09-18 18:30:26 UTC
please fix this soon so can be consistent with other projects and samples

it still uses encoding of locale user is in to set its project encoding
vs that of the current project encoding.

regular web application is ok; it does use the current value of project encoding for its project encoding.

also, since this was filed, the templates have been fixed so that html and jsp encoding tags are from
project properties value also - I dont think the web samples jsp files have such tags but think this
is ok as it will use encoding of the project as fallback.

ken.frank@sun.com
Comment 2 Tomas Mysik 2007-09-19 11:21:37 UTC
After the discussion reassigning to Tomasz.
Comment 3 Ken Frank 2007-10-03 19:19:38 UTC
request again to please fix soon so can have consistent behavior across all project types;
this is not related to tanslations or ml release but applies to en fcs release.

ken.frank@sun.com
Comment 4 Tomas Mysik 2007-10-31 12:45:47 UTC
I will look at it.
Comment 5 Tomas Mysik 2007-10-31 14:54:08 UTC
Should be fixed now, please verify.
Adding Dan to CC because of testing whether Web samples can be created, deployed, debugged etc. Thanks, Dan.

Checking in web/examples/jsp/nbproject/project.properties;
/cvs/web/examples/jsp/nbproject/project.properties,v  <--  project.properties
new revision: 1.11; previous revision: 1.10
done
Checking in web/examples/jstl/nbproject/project.properties;
/cvs/web/examples/jstl/nbproject/project.properties,v  <--  project.properties
new revision: 1.13; previous revision: 1.12
done
Checking in web/examples/nbproject/project.xml;
/cvs/web/examples/nbproject/project.xml,v  <--  project.xml
new revision: 1.9; previous revision: 1.8
done
Checking in web/examples/servlets/nbproject/project.properties;
/cvs/web/examples/servlets/nbproject/project.properties,v  <--  project.properties
new revision: 1.11; previous revision: 1.10
done
Checking in web/examples/src/org/netbeans/modules/web/examples/WebSampleProjectGenerator.java;
/cvs/web/examples/src/org/netbeans/modules/web/examples/WebSampleProjectGenerator.java,v  <--  
WebSampleProjectGenerator.java
new revision: 1.14; previous revision: 1.13
done
Comment 6 Tomas Mysik 2007-11-01 15:48:51 UTC
Additional fix - for more information see issue #108906.

Checking in web/examples/jsp/nbproject/project.properties;
/cvs/web/examples/jsp/nbproject/project.properties,v  <--  project.properties
new revision: 1.12; previous revision: 1.11
done
Checking in web/examples/jstl/nbproject/project.properties;
/cvs/web/examples/jstl/nbproject/project.properties,v  <--  project.properties
new revision: 1.14; previous revision: 1.13
done
Checking in web/examples/nbproject/project.xml;
/cvs/web/examples/nbproject/project.xml,v  <--  project.xml
new revision: 1.10; previous revision: 1.9
done
Checking in web/examples/servlets/nbproject/project.properties;
/cvs/web/examples/servlets/nbproject/project.properties,v  <--  project.properties
new revision: 1.12; previous revision: 1.11
done
Checking in web/examples/src/org/netbeans/modules/web/examples/WebSampleProjectGenerator.java;
/cvs/web/examples/src/org/netbeans/modules/web/examples/WebSampleProjectGenerator.java,v  <--  
WebSampleProjectGenerator.java
new revision: 1.15; previous revision: 1.14
done
Comment 7 Ken Frank 2007-11-04 20:01:16 UTC
Dan, can you confirm its ok in your env, then I can verify in other locales/
project encoding and using multibyte.

ken.frank@sun.com
Comment 8 Ken Frank 2007-11-11 17:47:59 UTC
in the web samples, 
the created html files have
charset tags of iso-8859-1

since now in nb, html files are
generated based on project encoding
property, is it ok that these files
are still generated using iso-8859-1 ?

I realize samples might be pre generated
and that could include all the files
in it, but since not sure am asking 
about it.

Also, Dan can you verify this issue itself as per developer request below ?

ken.frank@sun.com
Comment 9 kaa 2008-06-09 12:44:35 UTC
I tried to modify some labels in samples using mbyte chars. Compilation and javadoc generation looks ok.
Sample project encoding as well as its files encoding is always UTF-8