This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 108873 - Fix the expression evaluation algorithm
Summary: Fix the expression evaluation algorithm
Status: CLOSED FIXED
Alias: None
Product: debugger
Classification: Unclassified
Component: Java (show other bugs)
Version: 6.x
Hardware: All All
: P2 blocker (vote)
Assignee: Martin Entlicher
URL:
Keywords: UMBRELLA
Depends on: 118785 55674 59735 65173 67301 67937 70361 77701 80735 82771 84448 92045 111391 112962 115624 116866 123814
Blocks:
  Show dependency tree
 
Reported: 2007-07-04 14:42 UTC by Martin Entlicher
Modified: 2010-04-29 09:33 UTC (History)
0 users

See Also:
Issue Type: TASK
Exception Reporter:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Martin Entlicher 2007-07-04 14:42:04 UTC
The expression evaluation in debugger uses it's own Java parser. Now it's possible to take the advantage of Retouche
(compiler API) and take advantage of the existing parser. The evaluation process should be more reliable then.
Comment 1 Martin Entlicher 2007-07-04 14:49:03 UTC
This is an umbrella issue.
Comment 2 Martin Entlicher 2007-08-10 16:03:19 UTC
There's a first, incomplete, evaluator implementation via AST on branch AST_Evaluator:

Checking in nbproject/project.xml;
/shared/data/ccvs/repository/debuggerjpda/nbproject/project.xml,v  <--  project.xml
new revision: 1.21.8.1; previous revision: 1.21
done
Checking in projects/src/org/netbeans/modules/debugger/jpda/projects/EditorContextImpl.java;
/shared/data/ccvs/repository/debuggerjpda/projects/src/org/netbeans/modules/debugger/jpda/projects/EditorContextImpl.java,v
 <--  EditorContextImpl.java
new revision: 1.28.6.1; previous revision: 1.28
done
Checking in src/org/netbeans/modules/debugger/jpda/EditorContextBridge.java;
/shared/data/ccvs/repository/debuggerjpda/src/org/netbeans/modules/debugger/jpda/EditorContextBridge.java,v  <-- 
EditorContextBridge.java
new revision: 1.13.6.1; previous revision: 1.13
done
Checking in src/org/netbeans/modules/debugger/jpda/JPDADebuggerImpl.java;
/shared/data/ccvs/repository/debuggerjpda/src/org/netbeans/modules/debugger/jpda/JPDADebuggerImpl.java,v  <-- 
JPDADebuggerImpl.java
new revision: 1.125.6.1; previous revision: 1.125
done
Checking in src/org/netbeans/modules/debugger/jpda/breakpoints/BreakpointImpl.java;
/shared/data/ccvs/repository/debuggerjpda/src/org/netbeans/modules/debugger/jpda/breakpoints/BreakpointImpl.java,v  <--
 BreakpointImpl.java
new revision: 1.43.2.1; previous revision: 1.43
done
RCS file: /shared/data/ccvs/repository/debuggerjpda/src/org/netbeans/modules/debugger/jpda/expr/Attic/Assert2.java,v
done
Checking in src/org/netbeans/modules/debugger/jpda/expr/Assert2.java;
/shared/data/ccvs/repository/debuggerjpda/src/org/netbeans/modules/debugger/jpda/expr/Attic/Assert2.java,v  <-- 
Assert2.java
new revision: 1.1.2.1; previous revision: 1.1
done
Checking in src/org/netbeans/modules/debugger/jpda/expr/EvaluationContext.java;
/shared/data/ccvs/repository/debuggerjpda/src/org/netbeans/modules/debugger/jpda/expr/EvaluationContext.java,v  <-- 
EvaluationContext.java
new revision: 1.7.26.1; previous revision: 1.7
done
RCS file:
/shared/data/ccvs/repository/debuggerjpda/src/org/netbeans/modules/debugger/jpda/expr/Attic/EvaluationException2.java,v
done
Checking in src/org/netbeans/modules/debugger/jpda/expr/EvaluationException2.java;
/shared/data/ccvs/repository/debuggerjpda/src/org/netbeans/modules/debugger/jpda/expr/Attic/EvaluationException2.java,v
 <--  EvaluationException2.java
new revision: 1.1.2.1; previous revision: 1.1
done
RCS file:
/shared/data/ccvs/repository/debuggerjpda/src/org/netbeans/modules/debugger/jpda/expr/Attic/EvaluatorVisitor.java,v
done
Checking in src/org/netbeans/modules/debugger/jpda/expr/EvaluatorVisitor.java;
/shared/data/ccvs/repository/debuggerjpda/src/org/netbeans/modules/debugger/jpda/expr/Attic/EvaluatorVisitor.java,v  <--
 EvaluatorVisitor.java
new revision: 1.1.2.1; previous revision: 1.1
done
RCS file: /shared/data/ccvs/repository/debuggerjpda/src/org/netbeans/modules/debugger/jpda/expr/Attic/Expression2.java,v
done
Checking in src/org/netbeans/modules/debugger/jpda/expr/Expression2.java;
/shared/data/ccvs/repository/debuggerjpda/src/org/netbeans/modules/debugger/jpda/expr/Attic/Expression2.java,v  <-- 
Expression2.java
new revision: 1.1.2.1; previous revision: 1.1
done
RCS file: /shared/data/ccvs/repository/debuggerjpda/src/org/netbeans/modules/debugger/jpda/expr/Attic/TreeEvaluator.java,v
done
Checking in src/org/netbeans/modules/debugger/jpda/expr/TreeEvaluator.java;
/shared/data/ccvs/repository/debuggerjpda/src/org/netbeans/modules/debugger/jpda/expr/Attic/TreeEvaluator.java,v  <-- 
TreeEvaluator.java
new revision: 1.1.2.1; previous revision: 1.1
done
Comment 3 Martin Entlicher 2007-11-12 20:20:27 UTC
The prototype impl. merged into trunk, it can be turned on via an option, further development will be done in trunk.

/shared/data/ccvs/repository/debuggerjpda/nbproject/project.xml,v  <--  project.xml
new revision: 1.23; previous revision: 1.22

/shared/data/ccvs/repository/debuggerjpda/projects/src/org/netbeans/modules/debugger/jpda/projects/EditorContextImpl.java,v
 <--  EditorContextImpl.java
new revision: 1.41; previous revision: 1.40

/shared/data/ccvs/repository/debuggerjpda/src/org/netbeans/modules/debugger/jpda/EditorContextBridge.java,v  <-- 
EditorContextBridge.java
new revision: 1.16; previous revision: 1.15

/shared/data/ccvs/repository/debuggerjpda/src/org/netbeans/modules/debugger/jpda/JPDADebuggerImpl.java,v  <-- 
JPDADebuggerImpl.java
new revision: 1.133; previous revision: 1.132

/shared/data/ccvs/repository/debuggerjpda/src/org/netbeans/modules/debugger/jpda/breakpoints/BreakpointImpl.java,v  <--
 BreakpointImpl.java
new revision: 1.46; previous revision: 1.45

/shared/data/ccvs/repository/debuggerjpda/src/org/netbeans/modules/debugger/jpda/expr/Assert2.java,v  <--  Assert2.java
new revision: 1.2; previous revision: 1.1

/shared/data/ccvs/repository/debuggerjpda/src/org/netbeans/modules/debugger/jpda/expr/EvaluationContext.java,v  <-- 
EvaluationContext.java
new revision: 1.9; previous revision: 1.8

/shared/data/ccvs/repository/debuggerjpda/src/org/netbeans/modules/debugger/jpda/expr/EvaluationException2.java,v  <-- 
EvaluationException2.java
new revision: 1.2; previous revision: 1.1

/shared/data/ccvs/repository/debuggerjpda/src/org/netbeans/modules/debugger/jpda/expr/EvaluatorVisitor.java,v  <-- 
EvaluatorVisitor.java
new revision: 1.2; previous revision: 1.1

/shared/data/ccvs/repository/debuggerjpda/src/org/netbeans/modules/debugger/jpda/expr/Expression2.java,v  <-- 
Expression2.java
new revision: 1.2; previous revision: 1.1

/shared/data/ccvs/repository/debuggerjpda/src/org/netbeans/modules/debugger/jpda/expr/TreeEvaluator.java,v  <-- 
TreeEvaluator.java
new revision: 1.2; previous revision: 1.1
Comment 4 Martin Entlicher 2007-11-21 15:20:09 UTC
The operations are now intepreted:

/shared/data/ccvs/repository/debuggerjpda/src/org/netbeans/modules/debugger/jpda/expr/EvaluationContext.java,v  <-- 
EvaluationContext.java
new revision: 1.10; previous revision: 1.9

/shared/data/ccvs/repository/debuggerjpda/src/org/netbeans/modules/debugger/jpda/expr/EvaluatorVisitor.java,v  <-- 
EvaluatorVisitor.java
new revision: 1.3; previous revision: 1.2
Comment 5 Martin Entlicher 2007-12-13 17:12:35 UTC
The new implementation of evaluator is made default.
The old one is still available via option -J-Ddebugger.evaluatorOld=true and will be removed later.

/shared/data/ccvs/repository/debuggerjpda/src/org/netbeans/modules/debugger/jpda/JPDADebuggerImpl.java,v  <-- 
JPDADebuggerImpl.java
new revision: 1.134; previous revision: 1.133

/shared/data/ccvs/repository/debuggerjpda/src/org/netbeans/modules/debugger/jpda/expr/TreeEvaluator.java,v  <-- 
TreeEvaluator.java
new revision: 1.4; previous revision: 1.3
Comment 6 Quality Engineering 2010-04-29 09:33:55 UTC
Verified ... and Closing all issues resolved into NetBeans 6.7 and earlier.