This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 107910 - I18N - jsp files don't use and are not seeded with project encoding value
Summary: I18N - jsp files don't use and are not seeded with project encoding value
Status: VERIFIED FIXED
Alias: None
Product: javaee
Classification: Unclassified
Component: JSP (show other bugs)
Version: 6.x
Hardware: All All
: P2 blocker (vote)
Assignee: Marek Fukala
URL:
Keywords: I18N
Depends on: 110910
Blocks:
  Show dependency tree
 
Reported: 2007-06-23 01:30 UTC by Ken Frank
Modified: 2007-11-29 16:20 UTC (History)
0 users

See Also:
Issue Type: DEFECT
Exception Reporter:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Ken Frank 2007-06-23 01:30:57 UTC
now there is new project and file encoding values

the jsp files are seeded with utf-8, the html files are seeded with
encoding of users locale in the meta charset tag - when these files are created.

encoding of new projects are seeded with current value of global encoding
or use utf-8 by default.

from mail discussions with Tomas, the jsp needs to get its encoding from the project
encoding value, and also its better to place that encoding in the charset notation
of the jsp file.

(similar issues are filed on html and xml files)

(information from Tomas is that the encoding of the html or jsp or xml
file is the one used in the editor and other non runtime operations
of these files - besides being for the runtime information.)
Comment 1 Marek Fukala 2007-06-27 22:08:50 UTC
I'll fix the file from templates creation so it creates the files with the proper FEQ encoding + I'll try to fix the JSP
template so it contains proper <%@page encoding="enc_from_FEQ"%> attribute.
Comment 2 Ken Frank 2007-06-27 23:41:25 UTC
does this all sync up with recent fixes related to project and file encoding in
97871 and 97851 ?

It will be good to have it all synched and done so testing wont have dependencies on other
parts of the feq or related implementation still in progress.

ken.frank@sun.com
Comment 3 Ken Frank 2007-07-01 19:12:57 UTC
in the template editor, there are some under web beside jsp that have encoding value set - like tag file,
as well as some under Java Server Faces section and Visual Web JSF 1.2 section - should these be
part of this issue or should separate issues be created ?

ken.frank@sun.com
Comment 4 Marek Fukala 2007-07-25 12:22:15 UTC
The solution depends on issue #110910, I have prepared patch for html editor which I'll commit after the issue is resolved.
Comment 5 Marek Fukala 2007-07-31 12:51:35 UTC
fixed

Checking in jsploader/JspDataObject.java;
/cvs/web/core/src/org/netbeans/modules/web/core/jsploader/JspDataObject.java,v  <--  JspDataObject.java
new revision: 1.70; previous revision: 1.69
done
Checking in resources/layer.xml;
/cvs/web/core/src/org/netbeans/modules/web/core/resources/layer.xml,v  <--  layer.xml
new revision: 1.101; previous revision: 1.100
done
Checking in resources/templates/JSP.template;
/cvs/web/core/src/org/netbeans/modules/web/core/resources/templates/JSP.template,v  <--  JSP.template
new revision: 1.9; previous revision: 1.8
done
Comment 6 Marek Fukala 2007-07-31 13:01:56 UTC
Checking in templates/JSPDoc.template;
/cvs/web/core/src/org/netbeans/modules/web/core/resources/templates/JSPDoc.template,v  <--  JSPDoc.template
new revision: 1.6; previous revision: 1.5
done
Checking in layer.xml;
/cvs/web/core/src/org/netbeans/modules/web/core/resources/layer.xml,v  <--  layer.xml
new revision: 1.102; previous revision: 1.101
done
Comment 7 Ken Frank 2007-09-30 03:44:27 UTC
verifying for regular jsp files, not for the visualweb ones; there is a separate issue on that.

ken.frank@sun.com
Comment 8 kaa 2007-11-29 16:20:32 UTC
re-verified: jsp files use project encoding, build 1123, XP, ja_JP