This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 105470 - Changes to nbrubyide $nbexec eval break nbbuild/hudson/ruby-etcconf
Summary: Changes to nbrubyide $nbexec eval break nbbuild/hudson/ruby-etcconf
Status: RESOLVED FIXED
Alias: None
Product: ruby
Classification: Unclassified
Component: Code (show other bugs)
Version: 6.x
Hardware: Macintosh All
: P3 blocker (vote)
Assignee: Torbjorn Norbye
URL:
Keywords:
Depends on: 104622
Blocks:
  Show dependency tree
 
Reported: 2007-06-02 10:38 UTC by simon_nicholls
Modified: 2007-07-03 14:45 UTC (History)
1 user (show)

See Also:
Issue Type: DEFECT
Exception Reporter:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description simon_nicholls 2007-06-02 10:38:05 UTC 
With the most recent builds, nbrubyide wraps single quotes around many
parameters passed to the eval call.

This breaks nbbuild/hudson/ruby-etcconf, since it uses sed to scan for text
without those quotes.
Comment 1 Torbjorn Norbye 2007-06-02 15:19:41 UTC 
Thanks, Simon! I made a simple fix, build 1509 should contain it; I'll look at that build result and see if I 
need to do anything else.
Comment 2 simon_nicholls 2007-06-02 15:54:45 UTC 
I tried it with no joy. I think you might need to replace the single quote sed
string with double quotes, and escape with backslash
Comment 3 simon_nicholls 2007-06-02 16:03:07 UTC 
This kind of thing works locally for me:

sed "s/Xdock:name=\'\"\$APPNAME\"\'/Xdock:name=RubyNetBeans
\"-J-Xdock:icon=$progdir\/..\/nb6.0\/netbeans.icns\"/g"

I don't think single quotes can sit within other single quotes, even when escaped.
Comment 4 Torbjorn Norbye 2007-06-02 16:12:57 UTC 
Ugh. Trial and error programming :) I've done a full CVS update of my NetBeans tree so I can actually test 
this on my own side now before comitting again.
Comment 6 simon_nicholls 2007-06-04 16:00:25 UTC 
Only a minor escaping tweak needed to close out the fix. Sed is pattern matching
the launcher changes fine, but due to quote switch to double quotes, an output
dollar sign needs escaping to preserve $progdir literal.
Comment 7 simon_nicholls 2007-06-05 09:51:50 UTC 
Fixed as of #1594. Thanks Tor.
Comment 8 Jiri Kovalsky 2007-07-03 14:14:58 UTC 
Reassigning this issue to newly created 'ruby' component.
Comment 9 Jiri Kovalsky 2007-07-03 14:45:39 UTC 
Changing target milestone of all resolved Ruby issues from TBD to 6.0 Beta 1 build.