This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 104413 - EL inside html tag breaks coloring and code completion
Summary: EL inside html tag breaks coloring and code completion
Status: VERIFIED FIXED
Alias: None
Product: javaee
Classification: Unclassified
Component: JSF (show other bugs)
Version: 6.x
Hardware: All All
: P2 blocker (vote)
Assignee: Marek Fukala
URL:
Keywords:
: 104938 108549 108942 (view as bug list)
Depends on: 87014
Blocks:
  Show dependency tree
 
Reported: 2007-05-21 14:18 UTC by tomzi
Modified: 2008-06-19 12:53 UTC (History)
3 users (show)

See Also:
Issue Type: DEFECT
Exception Reporter:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description tomzi 2007-05-21 14:18:31 UTC
When I create following statement in a valid jsf file:

<h:inputText id="lname" value="#{UserBean.lastName}" 
                                    required="true"/>

1.) syntax coloring colores ... "required="true"/> in black
2.) An annotation is created with the tooltip "Unfinished tag."
Comment 1 novakm 2007-05-23 12:05:44 UTC
Reassigning to web - jsf
Comment 2 Joseph Silber 2007-06-28 13:04:35 UTC
Adding target milestone. 
It seems to me we shouldn't worry our users that good code is somehow less than valid.
Comment 3 Marek Fukala 2007-07-10 15:52:31 UTC
This issue is caused by issue #87014 - the part of jsp tag after the expression language is lexed as a plain text
instead of jsp tag. I cannot do much for that than just wait for Mila Metelka to fix the issue.
Comment 4 Marek Fukala 2007-07-10 17:01:56 UTC
*** Issue 104938 has been marked as a duplicate of this issue. ***
Comment 5 Marek Fukala 2007-07-13 11:13:48 UTC
*** Issue 108549 has been marked as a duplicate of this issue. ***
Comment 6 Marek Fukala 2007-07-23 15:41:45 UTC
code completion doesn't work as well behind the EL as an effect of invalid lexing.
Comment 7 Marek Fukala 2007-07-23 15:42:17 UTC
*** Issue 108942 has been marked as a duplicate of this issue. ***
Comment 8 Vince Kraemer 2007-07-23 20:02:03 UTC
Shouldn't this get marked as a P2... since it was used to close a high visibility P2 issue 108942
Comment 9 Marek Fukala 2007-07-24 09:23:50 UTC
Increasing priority, though this issue fully depends on issue #87014 which is a P1.
Comment 10 Marek Fukala 2007-09-06 10:00:42 UTC
Issue #87014 has been fixed, the transfer of the states works well, I did some small fixes in the lexers as well and now
the described usecase works as well. However html code completion doesn't work after the embedded EL, it is not easy to
fix, maybe it will work once Mila implements the joined token sequences and we migrate the code to them.

Checking in web/jspsyntax/lexer/src/org/netbeans/lib/jsp/lexer/JspLexer.java;
/cvs/web/jspsyntax/lexer/src/org/netbeans/lib/jsp/lexer/JspLexer.java,v  <--  JspLexer.java
new revision: 1.27; previous revision: 1.26
done
Checking in html/lexer/src/org/netbeans/lib/html/lexer/HTMLLexer.java;
/cvs/html/lexer/src/org/netbeans/lib/html/lexer/HTMLLexer.java,v  <--  HTMLLexer.java
new revision: 1.18; previous revision: 1.17
done
Comment 11 polan 2008-06-19 12:53:53 UTC
Verified.