This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 101734 - Menu separators are not coloured the same as the gutter lines
Summary: Menu separators are not coloured the same as the gutter lines
Status: RESOLVED FIXED
Alias: None
Product: versioncontrol
Classification: Unclassified
Component: Code (show other bugs)
Version: 5.x
Hardware: PC Windows Vista
: P3 blocker (vote)
Assignee: issues@versioncontrol
URL:
Keywords: L&F
: 101544 117045 (view as bug list)
Depends on:
Blocks:
 
Reported: 2007-04-19 11:12 UTC by ecmel
Modified: 2007-10-10 15:18 UTC (History)
1 user (show)

See Also:
Issue Type: DEFECT
Exception Reporter:


Attachments
Test Case (9.97 KB, application/octet-stream)
2007-04-23 13:14 UTC, ecmel
Details
Screenshot on Vista (45.36 KB, application/octet-stream)
2007-04-23 13:41 UTC, ecmel
Details
Screenshot on XP (15.33 KB, application/octet-stream)
2007-04-24 14:20 UTC, ecmel
Details

Note You need to log in before you can comment on or make changes to this bug.
Description ecmel 2007-04-19 11:12:46 UTC
With JDK 6.0 update 1, JMenu.addSeparator() creates a Vista style separator 
but new JSeparator() creates a simple black line.

Global menu in Netbeans seems to use the latter approach, hence it does not 
look native. The same applies to Matisse generated menus.

On the other hand, context menus draws fine.

I am not sure this should be fixed in Netbeans, but JDK team may consider this 
an application issue.
Comment 1 Peter Pis 2007-04-22 17:46:14 UTC
Can we do something with it? "core"...
Comment 2 Marian Mirilovic 2007-04-22 21:37:59 UTC
Dafe, 
JDK bug ?
Comment 3 David Simonek 2007-04-23 09:10:23 UTC
reporter, could you please create small test demonstrating the difference
between JMenu.addSeparator() and new JSeparator()? We should enter JDK bug and
attach the test.

Passing to our Vista guru Standa.
Comment 4 ecmel 2007-04-23 13:14:24 UTC
Created attachment 41446 [details]
Test Case
Comment 5 ecmel 2007-04-23 13:16:28 UTC
By the way, there is a difference on Windows XP as well. JMenu.addSeparator() 
creates a more native looking one. 
Comment 6 ecmel 2007-04-23 13:41:48 UTC
Created attachment 41450 [details]
Screenshot on Vista
Comment 7 ecmel 2007-04-24 14:20:24 UTC
Created attachment 41547 [details]
Screenshot on XP
Comment 8 Stanislav Aubrecht 2007-09-10 13:20:57 UTC
*** Issue 101544 has been marked as a duplicate of this issue. ***
Comment 9 Stanislav Aubrecht 2007-09-10 13:30:21 UTC
fixed in openide-loaders. there's still one outstanding issue with versioning menu - reassigning
Comment 10 Stanislav Aubrecht 2007-09-10 13:31:31 UTC
forgot to attach commit log:

/cvs/openide/loaders/src/org/openide/awt/DynaMenuModel.java,v  <--  DynaMenuModel.java
new revision: 1.11; previous revision: 1.10
Comment 11 Maros Sandor 2007-09-10 14:39:27 UTC
Fixing across VCS modules - using menu.addSeparator() instead of menu.add(new JSeparator()).

/shared/data/ccvs/repository/javacvs/cvsmodule/src/org/netbeans/modules/versioning/system/cvss/ui/actions/annotate/AnnotationBar.java,v
 <--  AnnotationBar.java
new revision: 1.35; previous revision: 1.34
/shared/data/ccvs/repository/javacvs/cvsmodule/src/org/netbeans/modules/versioning/system/cvss/ui/syncview/SyncTable.java,v
 <--  SyncTable.java
new revision: 1.34; previous revision: 1.33
/shared/data/ccvs/repository/subversion/main/src/org/netbeans/modules/subversion/ui/blame/AnnotationBar.java,v  <-- 
AnnotationBar.java
new revision: 1.17; previous revision: 1.16
/shared/data/ccvs/repository/subversion/main/src/org/netbeans/modules/subversion/ui/status/SyncTable.java,v  <-- 
SyncTable.java
new revision: 1.19; previous revision: 1.18
/shared/data/ccvs/repository/versioncontrol/src/org/netbeans/modules/versioning/Utils.java,v  <--  Utils.java
new revision: 1.9; previous revision: 1.8
/shared/data/ccvs/repository/versioncontrol/src/org/netbeans/modules/versioning/VersioningMainMenu.java,v  <-- 
VersioningMainMenu.java
new revision: 1.9; previous revision: 1.8
/shared/data/ccvs/repository/versioncontrol/src/org/netbeans/modules/versioning/ProjectMenuItem.java,v  <-- 
ProjectMenuItem.java
new revision: 1.12; previous revision: 1.11
/shared/data/ccvs/repository/versioncontrol/src/org/netbeans/modules/versioning/VersioningAnnotationProvider.java,v  <--
 VersioningAnnotationProvider.java
new revision: 1.16; previous revision: 1.15
Comment 12 Stanislav Aubrecht 2007-10-10 15:18:30 UTC
*** Issue 117045 has been marked as a duplicate of this issue. ***