This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 101491 - Getting a NPE in DDNodeBean after modifying web.xml
Summary: Getting a NPE in DDNodeBean after modifying web.xml
Status: RESOLVED FIXED
Alias: None
Product: serverplugins
Classification: Unclassified
Component: Sun Appserver 9 (show other bugs)
Version: 6.x
Hardware: All All
: P1 blocker (vote)
Assignee: _ pcw
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2007-04-18 00:31 UTC by Peter Liu
Modified: 2007-04-21 02:49 UTC (History)
2 users (show)

See Also:
Issue Type: DEFECT
Exception Reporter:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Peter Liu 2007-04-18 00:31:44 UTC 
I get the following NPE after programmatically modifying the web.xml:

java.lang.NullPointerException
	at org.netbeans.modules.j2ee.sun.share.config.DDNodeBean.<init>(DDNodeBean.java:31)
	at
org.netbeans.modules.j2ee.sun.share.config.ModuleDDSupport.getBean(ModuleDDSupport.java:385)
	at
org.netbeans.modules.j2ee.sun.share.config.ModuleDDSupport.propertyChange(ModuleDDSupport.java:616)
	at
org.openide.util.WeakListenerImpl$PropertyChange.propertyChange(WeakListenerImpl.java:164)
	at
java.beans.PropertyChangeSupport.firePropertyChange(PropertyChangeSupport.java:333)
	at org.netbeans.modules.schema2beans.BeanProp.notifyInternal(BeanProp.java:1518)
	at org.netbeans.modules.schema2beans.BaseBean.notifyInternal(BaseBean.java:1205)
	at org.netbeans.modules.schema2beans.BeanProp.notifyInternal(BeanProp.java:1555)
	at org.netbeans.modules.schema2beans.BeanProp.notifyInternal(BeanProp.java:1490)
	at org.netbeans.modules.schema2beans.BeanProp.removeElement(BeanProp.java:1108)
	at org.netbeans.modules.schema2beans.BeanProp.removeValue(BeanProp.java:846)
	at org.netbeans.modules.schema2beans.BaseBean.removeValue(BaseBean.java:452)
	at org.netbeans.modules.schema2beans.BaseBean.removeValue(BaseBean.java:487)
	at
org.netbeans.modules.j2ee.dd.impl.web.model_2_5.WebApp.removeSecurityConstraint(WebApp.java:1722)
	at
org.netbeans.modules.j2ee.dd.impl.web.WebAppProxy.removeSecurityConstraint(WebAppProxy.java:555)
	at
org.netbeans.modules.identity.profile.ui.support.J2eeProjectHelper.removeAMSecurityConstraint(J2eeProjectHelper.java:912)
	at
org.netbeans.modules.identity.profile.ui.support.J2eeProjectHelper.disableLiberty(J2eeProjectHelper.java:850)
	at
org.netbeans.modules.identity.profile.ui.support.J2eeProjectHelper.enableWSCSecurity(J2eeProjectHelper.java:761)
	at
org.netbeans.modules.identity.profile.ui.WSCSecurityPanel.save(WSCSecurityPanel.java:241)
	at
org.netbeans.modules.identity.profile.ui.WSCSectionNode.save(WSCSectionNode.java:53)
	at org.netbeans.modules.identity.profile.ui.SecurityView.save(SecurityView.java:74)
	at
org.netbeans.modules.identity.profile.ui.editor.SecurityWSEditor.save(SecurityWSEditor.java:107)
[catch] at
org.netbeans.modules.websvc.core.wseditor.support.EditWSAttributesCookieImpl$1.run(EditWSAttributesCookieImpl.java:90)
	at java.awt.event.InvocationEvent.dispatch(InvocationEvent.java:209)
	at java.awt.EventQueue.dispatchEvent(EventQueue.java:461)
	at
java.awt.EventDispatchThread.pumpOneEventForHierarchy(EventDispatchThread.java:242)
	at
java.awt.EventDispatchThread.pumpEventsForHierarchy(EventDispatchThread.java:163)
	at java.awt.EventDispatchThread.pumpEvents(EventDispatchThread.java:157)
	at java.awt.EventDispatchThread.pumpEvents(EventDispatchThread.java:149)
	at java.awt.EventDispatchThread.run(EventDispatchThread.java:110)
Comment 1 Petr Jiricka 2007-04-19 16:49:36 UTC 
Hi Peter, what's the status of this issue? Are you working on this? Thanks.
Comment 2 _ pcw 2007-04-19 17:42:57 UTC 
yes, I've read it, was looking into it last night.  Will fix today.
Comment 3 _ pcw 2007-04-20 03:49:03 UTC 
This will have to wait until tomorrow, a fire alarm in SCA 14 just sent me home
for the evening (I was on a roll too, someone hates me :( )

The problem here is that the DDNode tree (our wrapper around schema2beans nodes
for web.xml) is unstable.  It's unstable because of the some broken code added
for the ddbean removal in this area that I was unaware of.  Additionally, I
found out on Wednesday that various pieces of DDBean->DConfigBean code that
appeared to be working is working only by accident, and incorrectly at that.

The proper fix for all of the above is to completely disable the above system,
but if I do only that, no sun-web.xml will be created for new projects, which
kills JSP debugging.

So I'm doing a full rewrite of default file creation, and set/getContextRoot for
ModuleConfiguration (formerly ConfigurationSupport) api.  It's almost done.

FWIW, I don't think this issue is a P1 so I lowered it to P2.  But it needs to
be fixed ASAP.  Barring anymore ill timed fire alarms and all-hands meetings, it
will be fixed by COB Friday.