Bug 101331 - Hide factory methods in VCSContext
Hide factory methods in VCSContext
Product: versioncontrol
Classification: Unclassified
Component: Code
All All
: P2 (vote)
: 6.x
Assigned To: issues@versioncontrol
Depends on:
  Show dependency treegraph
Reported: 2007-04-17 12:52 UTC by Maros Sandor
Modified: 2007-06-14 09:00 UTC (History)
0 users

See Also:
Issue Type: DEFECT


Note You need to log in before you can comment on or make changes to this bug.
Description Maros Sandor 2007-04-17 12:52:37 UTC
TCR from Issue #97278: use trampoline to hide factory methods in VCSContext
Comment 1 Maros Sandor 2007-06-06 11:02:57 UTC
I am asking for the permission to keep the forNodes(Node[]) method in the SPI in
some form (forLookup being an alternative). The method can also be in
VersioningSupport class. I'll elaborate more:

Clients are passed VCSContext when asked to annotate nodes or provide actions
for them. So their Actions take VCSContext as argument and perform versioning
actions on that context. However, there are other scenarios when clients use
these actions. For example, in the CVS (Versioning) view, the table lists
changed files and there are actions available on them via the popup menu. To
simply re-use Actions for those menus clients would need to somehow create
VCSContext out of nodes in the table. If clients are unable to create VCSContext
they need to have TWO ways of providing input to every Ation, which is inconvenient.

If there are no objections, I'll leave forNodes() method there as is.
Comment 2 Maros Sandor 2007-06-14 09:00:12 UTC

By use of this website, you agree to the NetBeans Policies and Terms of Use. © 2014, Oracle Corporation and/or its affiliates. Sponsored by Oracle logo