This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 10126 - Add notification about Local files before commit on directory
Summary: Add notification about Local files before commit on directory
Status: RESOLVED WORKSFORME
Alias: None
Product: obsolete
Classification: Unclassified
Component: vcscvs (show other bugs)
Version: 3.x
Hardware: All All
: P4 blocker (vote)
Assignee: issues@obsolete
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2001-03-09 10:25 UTC by phamernik
Modified: 2012-09-27 18:39 UTC (History)
0 users

See Also:
Issue Type: ENHANCEMENT
Exception Reporter:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description phamernik 2001-03-09 10:25:56 UTC
The following description is copied from issue #10125, because javacvs and 
vcscvs modules are similar.
see: http://www.netbeans.org/issues/show_bug.cgi?id=10125+
---------------------------------------------------------
It would be useful to notify user about all [Local] files, when he/she is 
starting 'commit' command on whole directory.
It is very frequent developer's mistake that (s)he forget 'add' files before 
commit.

I could imagine the warning dialog saying something like: 
"You are about commit all changes in <somedir> directory and all sub-
directories. These files: 
<list_of_local_files> are local and were not added to CVS repository. Didn't 
you want to add them before commit?" 
[x] Do not show this message again.
Comment 1 Martin Entlicher 2001-03-09 16:44:51 UTC
I'm not sure if this is not much work with effect only for users, that are too
lazy to run Find... on the folder they are committing.

IMO it is wery helpful to get used to run Find..., select the Status tab and set
Up-to-date with "Match only files that do not meet the selected criteria"
checked on. And you get info of not only [Local] files, but of [Needs Patch],
Conflict after merge, etc.

Perhaps we should think up how to tell people to use that search tool.

Any comments ?
Comment 2 Milos Kleint 2001-03-09 17:28:37 UTC
Yes, that's true.
Just one more remark. Since Find... works with Statuses of files, it displays 
only what is in cache. If the user wants to have uptodate info, he/she should 
run refresh first.

Comment 3 phamernik 2001-03-09 17:42:52 UTC
The reason such a warning came from the frequent broken builds of our CVS 
repository.
I think that most frequent developer's mistake is that he/she forget to add 
files. I don't have exact statistics, but I remember some examples. So, I 
didn't mean it should be a feature for lazy developers, but rather a last 
minute warning about potential problem.
I don't know exactly how difficult is the implementation.
Comment 4 Martin Entlicher 2001-03-09 18:08:54 UTC
I see the reasons for this enhancement. The problem is, that presence of local
files might not signal any omission (I usually keep in my sources some local
files, which are some tests or sources, which are not supposed to integrate to
cvs). If the user will have several local files intentionally in the working
directory, he will probably ignore this warning or turn it off (I thing, that it
should be possible to turn it off). And we are where we were before.

Another problem is, that commit does not provide any information of local files.
We will have to run another cvs command (i.e. cvs status) to get that
information.

It depends on how much intelligent we want to make our software. We can
implement it, but with a possibility to turn it off. Then it will depend again
on the user if s/he would like to have this extra check or not.
Comment 5 marco76 2012-09-27 18:39:37 UTC
This issue is related to javacvs that is no more integrated in Nerbeans. The user request didn't have any following in the last 10 years. The bug can be closed. If the announcer think that this feature is still necessary he can reopen a new and updated bug.