This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 100178 - I18N - might need to implement new nb encoding api/features - FEQ
Summary: I18N - might need to implement new nb encoding api/features - FEQ
Status: RESOLVED FIXED
Alias: None
Product: javaee
Classification: Unclassified
Component: JSP Parser (show other bugs)
Version: 6.x
Hardware: All All
: P3 blocker (vote)
Assignee: Anton Chechel
URL:
Keywords: I18N
: 94505 (view as bug list)
Depends on:
Blocks: 97848
  Show dependency tree
 
Reported: 2007-04-06 03:10 UTC by Ken Frank
Modified: 2011-04-20 14:48 UTC (History)
4 users (show)

See Also:
Issue Type: DEFECT
Exception Reporter:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Ken Frank 2007-04-06 03:10:46 UTC
Now that vwp project is part of web apps project -

New nb implementation of 42638 and related issues resulted in infrastructure for
providing a per project endoding property.

Now 97848 is an umbrella issue for the actual per-project type  implementation
of it, which has refs to
issues filed so far for some other project types - from comments in that issue

-The guidelines for project types about this is:

Every project type should provide the FileEncodingQueryImplementation. There is
already an issue for j2ee project (enterprise).  If you know about some other
project type not covered
by dependent issues create a task for it.

There is already a task on this for web projects, but Mark mentioned that
vwp does introduce a DataObject (JsfDataObject) which may need some attention. 
If it does, please file a task on that or use this issue to track.
---> Please file such a task if this would apply separately to vwp; there is a
task in iz already for web apps;
its one of the ones referred to in 97848. (and put that issue id in the depends
on field in 97848 )

For more information see 97848 and 42638. Tomas Zezula is a developer who can
explain more about this.
Comment 1 _ potingwu 2007-04-06 19:57:20 UTC
I think Quy will look into the JsfDataObject issue.
Comment 2 Ken Frank 2007-06-05 22:21:45 UTC
please consider fixing this soon - 

web project has had this implenented already as has most of the nb core project
and file types, so it will really help to have this done soon, so we can fully
test it as part of general testing of project file encoding for web apps
and other project types.

also we need to see how the jsp and html charset tags work with the project encoding
properties.

ken.frank@sun.com
Comment 3 Quy Nguyen 2007-06-20 23:15:30 UTC
The EditorSupport for the visualweb project-specific files derive from DataEditorSupport, so based on IZ 97848 this
shouldn't be an issue for visualweb projects.  Is there a test case to determine if this is the case?
Comment 4 _ potingwu 2007-06-22 17:58:39 UTC
*** Issue 94505 has been marked as a duplicate of this issue. ***
Comment 5 Quy Nguyen 2007-07-03 02:01:06 UTC
Implemented the file encoding for the JsfJspDataObjects.

Checking in src/org/netbeans/modules/visualweb/project/jsfloader/Bundle.properties;
/cvs/visualweb/project/jsfloader/src/org/netbeans/modules/visualweb/project/jsfloader/Bundle.properties,v  <-- 
Bundle.properties
new revision: 1.2; previous revision: 1.1
done
Checking in src/org/netbeans/modules/visualweb/project/jsfloader/JsfJspDataLoader.java;
/cvs/visualweb/project/jsfloader/src/org/netbeans/modules/visualweb/project/jsfloader/JsfJspDataLoader.java,v  <-- 
JsfJspDataLoader.java
new revision: 1.6; previous revision: 1.5
done
Checking in src/org/netbeans/modules/visualweb/project/jsfloader/JsfJspDataNode.java;
/cvs/visualweb/project/jsfloader/src/org/netbeans/modules/visualweb/project/jsfloader/JsfJspDataNode.java,v  <-- 
JsfJspDataNode.java
new revision: 1.3; previous revision: 1.2
done
Checking in src/org/netbeans/modules/visualweb/project/jsfloader/JsfJspDataObject.java;
/cvs/visualweb/project/jsfloader/src/org/netbeans/modules/visualweb/project/jsfloader/JsfJspDataObject.java,v  <-- 
JsfJspDataObject.java
new revision: 1.6; previous revision: 1.5
done
Checking in src/org/netbeans/modules/visualweb/project/jsfloader/JsfJspEditorSupport.java;
/cvs/visualweb/project/jsfloader/src/org/netbeans/modules/visualweb/project/jsfloader/JsfJspEditorSupport.java,v  <-- 
JsfJspEditorSupport.java
new revision: 1.3; previous revision: 1.2
done
Comment 6 Ken Frank 2007-07-13 16:34:05 UTC
Quy, 

if the putback below fixes this issue, could you put into resolved state,
and then we can test it in builds as part of testing the web app project
and file encoding.

Could you tell me what functionality/scenarios from user view that this
fix handles, and we will focus on that for the testing ?

ken.frank@sun.com
Comment 7 Quy Nguyen 2007-07-13 18:06:49 UTC
I implemented the fix for the DataObject, but I was not able to verify the fix due to other issues.
Comment 8 Ken Frank 2007-07-24 20:19:04 UTC
Quy, for the fix you did  in this issue- what are the scenarios - we want to use them for verifying this.

and are there some other blocking issues  that would not allow this one to be verified by us now -  like 108682 for
templates and jsf
or other jsp related encoding handling done by other team ?

- 97871 for jsp and feq is done, but I need to find out how to verify.
- 107910 for jsp and seeding encoding value with project encoding, is not yet done

Thanks - Ken

ken.frank@sun.com
Comment 9 Ken Frank 2007-10-12 03:16:50 UTC
Quy mentioned that the scenario for this one is that if user puts an incorrect/unsupported
encoding in the jsp file header, that there would be a warning dialog.

This does not happen for vwp jsp files like Page1.java, whether changing the xml encoding
part or the jsp charset/encoding parts.

If create a regular jsp file in the vwp project, the warning is there, and that has been
verified in a different issue in web component.

Thus will reopen this issue.

ken.frank@sun.com
Comment 10 Quy Nguyen 2007-10-12 22:33:21 UTC
When I initially fixed the issue, the warning message was working.  Now, it seems that the TagLibParseCookie support
that we use to determine the JSP page encoding doesn't recognize the encoding changes in the visualweb jsp pages.  It
may have something to do with the structure of the jsp page in visual web, which is different from plain jsp files.  I'm
not sure if the problem is caused by changes in the vw jsp template or by something in the TagLibParseSupport web/core api.

In any case, I don't think this is still a P2 issue since it is a corner case and the problem that occurs is not too severe.
Comment 11 Petr Jiricka 2007-10-13 08:49:25 UTC
Ok, changing priority to P3.
Comment 12 Jiri Prox 2008-04-11 01:15:01 UTC
moving opened issues from TM <= 6.1 to TM=Dev
Comment 13 Anton Chechel 2011-04-20 14:48:52 UTC
Visual Web is not supported anymore.
This issue is already fixed for JSP.