This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.
Summary: | Remove default server residues from the API | ||
---|---|---|---|
Product: | serverplugins | Reporter: | Sherold Dev <sherold> |
Component: | Infrastructure | Assignee: | Petr Hejl <phejl> |
Status: | RESOLVED FIXED | ||
Severity: | blocker | CC: | mkleint, pbuzek |
Priority: | P1 | ||
Version: | 6.x | ||
Hardware: | All | ||
OS: | All | ||
Issue Type: | TASK | Exception Reporter: | |
Bug Depends on: | 132418, 132421, 132423, 133138 | ||
Bug Blocks: | |||
Attachments: |
diff
javadoc full diff |
Description
Sherold Dev
2006-08-31 14:54:28 UTC
Created attachment 33503 [details]
diff
Created attachment 33504 [details]
javadoc
list of impacted interfaces: org.netbeans.modules.j2ee.deployment.devmodules.api.Deployment org.netbeans.modules.j2ee.deployment.devmodules.spi.InstanceListener org.netbeans.modules.j2ee.deployment.devmodules.spi.J2eeModuleProvider org.netbeans.modules.j2ee.deployment.plugins.api.InstanceProperties Although this is an incompatible change, it should not break anything, since the being removed API has been broken for quite a while and is not even fixable -> using the API_REVIEW_FAST keyword. Please review this API change is this targetting 5.5? I would rather not as this seems to break the mevenide j2ee specific codebase. While I don't have a problem with 6.0 timeframe, 5.5 is too close to get a version out that supports both 5.0 and 5.5. what is the intended replacement code algorithm supposed to look like? I mean how do I find out what to fallback when server instance is not defined? Yes, it is targeting 5.5, but if it is really a problem, we can postpone it till 6.0. Are you really sure that it would break the meven ide? If it does it means that it relies on something that does not work properly, so it should be probably fixed there. Projects should use one of the Deployment.getServerInstanceIDs() methods to pick a server they should be deployed to based on the projects requirements. well, it's calling the methods that you want to remove, it calls super.<method> in the subclasses and similar stuff. I keep the mevenide modules working on both 5.0 and 5.5/6.0, this change so late in the dev cycle would mean quite a bit of testing for me and also the need to push a new version early enough so that people don't get stuck when upgrading the IDE. please postpone to 6.0 timeframe. OK, lets postpone it to 6.0. TM -> Dev Created attachment 33581 [details]
full diff
Since this is more a clean up than an actual defect changing the type to TASK. Milos is is the default server stuff still needed? Thanks, P. feel free to do it for 6.5, I'll accomodate the maven source code once it's done. Should be done for 6.5. Fixed 8611bf021a37. |